dohertj2/mxaccessgw
1
0
Fork 0
Code Issues 43 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Python client: make Session.close() concurrency-safe and cache the real reply (R21-O26 / CLI-27) #202

New Issue
Open
opened 2026-11-06 15:25:08 -05:00 by dohertj2 · 0 comments
dohertj2 commented 2026-11-06 15:25:08 -05:00
Owner
Copy Link
Copy Source

Session.close() has no lock around _closed, and a repeat close returns a synthesized reply.

Source: archreview/2026-10-21/remediation/00-tracking.md row R21-O26 (cycle-1 CLI-27)

Next step (from the tracker): Guard with an asyncio.Lock and cache the real reply, as .NET and Go do.

Current-state evidence: the row is still Open/Deferred in the latest (2026-10-21) tracker, and a code check on local main @ 8c0a51d (2026-11-06) found it still present unless noted below.

`Session.close()` has no lock around `_closed`, and a repeat close returns a synthesized reply. Source: `archreview/2026-10-21/remediation/00-tracking.md` row R21-O26 (cycle-1 CLI-27) Next step (from the tracker): Guard with an `asyncio.Lock` and cache the real reply, as .NET and Go do. Current-state evidence: the row is still `Open`/`Deferred` in the latest (2026-10-21) tracker, and a code check on local `main` @ `8c0a51d` (2026-11-06) found it still present unless noted below.
dohertj2 added the area:client-pythontype:review-findingpriority:p3migrated labels 2026-11-06 15:25:08 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area:auth
Authentication and authorization
 area:client-dotnet
.NET client library
 area:client-go
Go client library
 area:client-java
Java client library
 area:client-python
Python client library
 area:client-rust
Rust client library
 area:contracts
Protocol and generated contract work
 area:dashboard
Blazor dashboard work
 area:docs
Documentation
 area:gateway
Gateway server work
 area:tests
Automated and live tests
 area:worker
MXAccess worker process work
 blocked
Blocked by dependency
 cross-repo
Needs coordinated change in another family repo (wire contract etc.)
 migrated
Migrated from a markdown backlog (2026-11 standardization)
 priority:p0
Must-have / blocking
 priority:p1
High priority
 priority:p2
Normal priority
 priority:p3
Low priority / nice to have
 type:bug
Defect in shipped behaviour
 type:debt
Technical debt / hygiene
 type:deploy-gate
Rollout/deploy/migration step not yet done on an environment
 type:docs
Documentation work
 type:feature
Feature implementation
 type:followup
Follow-up deferred from a plan, PR or gate
 type:infra
Infrastructure and scaffolding
 type:review-finding
Unfixed finding from an architecture/code review
 type:test
Test work
No Label area:client-python migrated priority:p3 type:review-finding
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/mxaccessgw#202
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?