dohertj2/mxaccessgw
1
0
Fork 0
Code Issues 43 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

mxgateway.sessions.open gauge never decremented for sessions closed by the timed sweep #168

New Issue
Closed
opened 2026-10-22 06:05:32 -04:00 by dohertj2 · 1 comment
dohertj2 commented 2026-10-22 06:05:32 -04:00
Owner
Copy Link
Copy Source

TryBeginCloseIfExpired sets _closeStarted, so CloseSessionCoreAsync skips SessionClosed() and the open-sessions gauge drifts upward even after reaping. Found during the OtOpcUa 2026-10-21 review cross-check (lmxopcua#735). Fix: decrement on every close path, including sweep closes.

`TryBeginCloseIfExpired` sets `_closeStarted`, so `CloseSessionCoreAsync` skips `SessionClosed()` and the open-sessions gauge drifts upward even after reaping. Found during the OtOpcUa 2026-10-21 review cross-check (lmxopcua#735). Fix: decrement on every close path, including sweep closes.
dohertj2 commented 2026-11-06 15:59:05 -05:00
Author
Owner
Copy Link
Copy Source

Fixed on origin/main and verified (closing as part of #169).

  • 09666cc ("account SessionClosed for sweep-driven closes", merged in 7f0720f). SessionManager.CloseSessionCoreAsync now calls _metrics.SessionClosed() whenever !wasClosed && !result.AlreadyClosed && session.OpenRecorded. That includes the sweep path, where TryBeginCloseIfExpired has already set _closeStarted, and the SessionCloseStartedException path.
  • Test: SessionManagerTests.CloseExpiredLeasesAsync_SweptClose_AccountsSessionClosedExactlyOnce (theory over the sweep kinds) is green on macOS, and the full gateway suite is 1349/1349 on windev at 777fef9.
Fixed on origin/main and verified (closing as part of #169). - 09666cc ("account SessionClosed for sweep-driven closes", merged in 7f0720f). `SessionManager.CloseSessionCoreAsync` now calls `_metrics.SessionClosed()` whenever `!wasClosed && !result.AlreadyClosed && session.OpenRecorded`. That includes the sweep path, where `TryBeginCloseIfExpired` has already set `_closeStarted`, and the `SessionCloseStartedException` path. - Test: `SessionManagerTests.CloseExpiredLeasesAsync_SweptClose_AccountsSessionClosedExactlyOnce` (theory over the sweep kinds) is green on macOS, and the full gateway suite is 1349/1349 on windev at 777fef9.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area:auth
Authentication and authorization
 area:client-dotnet
.NET client library
 area:client-go
Go client library
 area:client-java
Java client library
 area:client-python
Python client library
 area:client-rust
Rust client library
 area:contracts
Protocol and generated contract work
 area:dashboard
Blazor dashboard work
 area:docs
Documentation
 area:gateway
Gateway server work
 area:tests
Automated and live tests
 area:worker
MXAccess worker process work
 blocked
Blocked by dependency
 cross-repo
Needs coordinated change in another family repo (wire contract etc.)
 migrated
Migrated from a markdown backlog (2026-11 standardization)
 priority:p0
Must-have / blocking
 priority:p1
High priority
 priority:p2
Normal priority
 priority:p3
Low priority / nice to have
 type:bug
Defect in shipped behaviour
 type:debt
Technical debt / hygiene
 type:deploy-gate
Rollout/deploy/migration step not yet done on an environment
 type:docs
Documentation work
 type:feature
Feature implementation
 type:followup
Follow-up deferred from a plan, PR or gate
 type:infra
Infrastructure and scaffolding
 type:review-finding
Unfixed finding from an architecture/code review
 type:test
Test work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/mxaccessgw#168
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?