refactor(sessions): remove the dead ISessionManager.ReadEventsAsync chain

ISessionManager.ReadEventsAsync had zero production call sites: the worker
event channel is drained once by GatewaySession.MapWorkerEventsAsync (the
distributor pump), and every consumer — gRPC subscribers, the dashboard
mirror, the alarm monitor — attaches to the distributor. The interface
member, SessionManager's forwarder, and GatewaySession.ReadEventsAsync are
gone; IWorkerClient/WorkerClient.ReadEventsAsync is untouched, it is the
live worker-channel claim.

No test was removed or rewired: nothing invoked the member through the
interface. Nine ISessionManager test fakes carried a required-member stub
(seven threw NotSupportedException or yielded nothing; EventStreamServiceTests
and GatewaySessionDashboardMirrorTests forwarded to the session; the two
MxAccessGatewayService fakes yielded their Events list) — all nine stubs were
deleted. The MxAccessGatewayService suites' streaming tests already run
through FakeEventStreamService, which reads the same Events list, so their
coverage is unchanged; only the now-inaccurate doc comments on Events /
LastReadEventsSessionId were reworded.

The MapWorkerEventsAsync comment no longer describes a twin to keep in step;
it now states the single-reader claim directly. docs/Sessions.md drops
ReadEventsAsync from the SessionManager member list and from the Run-state
prose. The 2026-08-15 deferred-remediation as-built note records the removal.

This commit is contained in:

Joseph Doherty

2026-08-17 03:46:41 -04:00

parent af9f185d32

commit fa9eb0c0b4

15 changed files with 12 additions and 133 deletions

									
										src/ZB.MOM.WW.MxGateway.Tests/Gateway/Dashboard/DashboardSessionAdminServiceTests.cs
									
		-8
	
												View File
												
				@@ -370,14 +370,6 @@ public sealed class DashboardSessionAdminServiceTests

				            throw new NotSupportedException();

				        }

				        /// <inheritdoc />

				        public IAsyncEnumerable<WorkerEvent> ReadEventsAsync(

				            string sessionId,

				            CancellationToken cancellationToken)

				        {

				            throw new NotSupportedException();

				        }

				        /// <inheritdoc />

				        public Task<SessionCloseResult> CloseSessionAsync(

				            string sessionId,