fix(alarms): truncation-safe transitions; perf: single-pass alarm parse; configurable poll cadence

2026-08-15 17:04:06 -04:00
parent 94fdc18c3c
commit f3e1de5f37
10 changed files with 910 additions and 33 deletions
@@ -163,6 +163,103 @@ public sealed class GatewayOptionsValidatorTests
            Tls = source.Tls,
        };

+    /// <summary>Verifies the alarm poll cadence and per-fetch cap defaults pass validation.</summary>
+    [Fact]
+    public void Validate_Succeeds_WithDefaultAlarmPollCadenceAndFetchCap()
+    {
+        AlarmsOptions alarms = new();
+        Assert.Equal(500, alarms.PollIntervalMilliseconds);
+        Assert.Equal(1024, alarms.MaxAlarmsPerFetch);
+
+        ValidateOptionsResult result = new GatewayOptionsValidator()
+            .Validate(null, CloneWithAlarms(ValidOptions(), alarms));
+        Assert.True(result.Succeeded);
+    }
+
+    /// <summary>
+    ///     A poll cadence below the 100 ms floor must fail validation. Both
+    ///     values are stamped onto every worker launch environment, so they
+    ///     are validated whether or not the central alarm monitor is enabled.
+    /// </summary>
+    /// <param name="pollIntervalMilliseconds">Cadence under test.</param>
+    /// <param name="alarmsEnabled">Whether the central alarm monitor is on.</param>
+    [Theory]
+    [InlineData(99, false)]
+    [InlineData(0, false)]
+    [InlineData(-1, false)]
+    [InlineData(99, true)]
+    public void Validate_Fails_WhenAlarmPollIntervalBelowFloor(
+        int pollIntervalMilliseconds,
+        bool alarmsEnabled)
+    {
+        GatewayOptions options = CloneWithAlarms(
+            ValidOptions(),
+            new AlarmsOptions
+            {
+                Enabled = alarmsEnabled,
+                DefaultArea = "Galaxy",
+                PollIntervalMilliseconds = pollIntervalMilliseconds,
+            });
+
+        ValidateOptionsResult result = new GatewayOptionsValidator().Validate(null, options);
+
+        Assert.False(result.Succeeded);
+        Assert.Contains(
+            result.Failures!,
+            f => f.Contains("MxGateway:Alarms:PollIntervalMilliseconds", StringComparison.Ordinal));
+    }
+
+    /// <summary>
+    ///     A per-fetch cap below the 64-record floor must fail validation. The
+    ///     cap doubles as the truncation-detection threshold in the worker, so
+    ///     a tiny cap would make almost every fetch read as truncated.
+    /// </summary>
+    /// <param name="maxAlarmsPerFetch">Cap under test.</param>
+    /// <param name="alarmsEnabled">Whether the central alarm monitor is on.</param>
+    [Theory]
+    [InlineData(63, false)]
+    [InlineData(0, false)]
+    [InlineData(-1, false)]
+    [InlineData(63, true)]
+    public void Validate_Fails_WhenMaxAlarmsPerFetchBelowFloor(
+        int maxAlarmsPerFetch,
+        bool alarmsEnabled)
+    {
+        GatewayOptions options = CloneWithAlarms(
+            ValidOptions(),
+            new AlarmsOptions
+            {
+                Enabled = alarmsEnabled,
+                DefaultArea = "Galaxy",
+                MaxAlarmsPerFetch = maxAlarmsPerFetch,
+            });
+
+        ValidateOptionsResult result = new GatewayOptionsValidator().Validate(null, options);
+
+        Assert.False(result.Succeeded);
+        Assert.Contains(
+            result.Failures!,
+            f => f.Contains("MxGateway:Alarms:MaxAlarmsPerFetch", StringComparison.Ordinal));
+    }
+
+    /// <summary>Verifies the floor values themselves are accepted.</summary>
+    [Fact]
+    public void Validate_Succeeds_AtAlarmPollCadenceAndFetchCapFloors()
+    {
+        GatewayOptions options = CloneWithAlarms(
+            ValidOptions(),
+            new AlarmsOptions
+            {
+                Enabled = true,
+                DefaultArea = "Galaxy",
+                PollIntervalMilliseconds = 100,
+                MaxAlarmsPerFetch = 64,
+            });
+
+        ValidateOptionsResult result = new GatewayOptionsValidator().Validate(null, options);
+        Assert.True(result.Succeeded);
+    }
+
    /// <summary>Verifies an invalid fallback mode is not validated when alarms are disabled.</summary>
    [Fact]
    public void Validate_Succeeds_WhenAlarmsDisabled_FallbackNotValidated()