From f3827c71c9e5245dcf8356cfde5fc4579ad9d623 Mon Sep 17 00:00:00 2001 From: Joseph Doherty Date: Tue, 25 Aug 2026 11:01:38 -0400 Subject: [PATCH] docs: record batch I verification --- .../2026-08-19/remediation/00-tracking.md | 21 ++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/archreview/2026-08-19/remediation/00-tracking.md b/archreview/2026-08-19/remediation/00-tracking.md index bec8644..a133987 100644 --- a/archreview/2026-08-19/remediation/00-tracking.md +++ b/archreview/2026-08-19/remediation/00-tracking.md @@ -27,7 +27,8 @@ This plan is executed as **seven parallel batches**, each by one subagent workin |---|---|---| | TST-32 | Blocked (external) | Gitea runner registration-token reset is a web-UI action on the Gitea admin page; no repo change. Operator to-do. | | SEC-37 | Blocked (external) | Family-wide: TLS on the shared GLAuth lives in `scadaproj/infra/glauth/` (separate repo + docker host). Plan separately; after it lands, move the deployed service to `Production`. | -| CLI-47/48/49/50, IPC-36/37, TST-35, GWC-33/35, SEC-38/39 | Not started | Activated by the 2026-08-25 P2 continuation below. | +| CLI-47/48/49/50, IPC-36/37, TST-35 | Not started | Activated by the 2026-08-25 P2 continuation below. | +| GWC-33/35, SEC-38/39 | Done | Closed by continuation batch I; regression counts and commits are recorded below. | | GWC-36, IPC-38, TST-33/34/36 | Done | Closed by continuation batch H; verification and commit are recorded below. | | WRK-34 | Done | Completed opportunistically in batch F (`3679e59`): watchdog faults use `CommandMethod=Watchdog` and carry the stuck correlation ID in the diagnostic message. Tracker correction recorded by the continuation audit. | @@ -106,7 +107,7 @@ The continuation runs serially in the isolated `.worktrees/c3-p2-followups` work | Batch | Findings / follow-ups | Codex model | Status | Exit gate | |---|---|---|---|---| | H — tracker and currency | WRK-34 record, GWC-36, IPC-38, TST-33/34/36 | `gpt-5.6-terra` medium | Done | Currency greps clean; README check in portable CI; NonWindows build clean | -| I — gateway correctness/security | GWC-33/35, SEC-38/39 | `gpt-5.6-sol` high | Not started | Focused regression tests green; NonWindows build clean | +| I — gateway correctness/security | GWC-33/35, SEC-38/39 | `gpt-5.6-sol` high | Done | Focused regression tests green; NonWindows build clean | | J — secondary contracts | IPC-36/37 | `gpt-5.6-sol` high | Not started | Shared launch constants and descriptor parity tests green | | K — client alarm parity | CLI-47/48/49/50 | `gpt-5.6-terra` high | Not started | All five client suites green | | L — live watch-list/proto wave | watch-list refresh follow-up + WRK-32 proto comment | `gpt-5.6-sol` high | Not started | Codegen clean; portable alarm/contract tests green; windev Worker.Tests green | @@ -133,11 +134,17 @@ succeeded with **0 warnings / 0 errors** in 1.59 s. Batch commit: `92aae28`. #### I — gateway correctness and security -- [ ] GWC-33: unregister terminal clients from the event-queue-depth gauge without shortening fault retention. -- [ ] GWC-35: repair acknowledged-to-active snapshot deltas with a Raise transition and instance identity. -- [ ] SEC-38: feed/consult the aggregate for valid key IDs that overflow the peer partition cap. -- [ ] SEC-39: prove a null effective key ID cannot reset the shared fallback partition. -- [ ] Run focused tests and clean NonWindows build; record counts and commits here. +- [x] GWC-33: unregister terminal clients from the event-queue-depth gauge without shortening fault retention. +- [x] GWC-35: repair acknowledged-to-active snapshot deltas with a Raise transition and instance identity. +- [x] SEC-38: feed/consult the aggregate for valid key IDs that overflow the peer partition cap. +- [x] SEC-39: prove a null effective key ID cannot reset the shared fallback partition. +- [x] Run focused tests and clean NonWindows build; record counts and commits here. + +Batch-I verification (2026-08-25): the combined `WorkerClientTests`, +`GatewayAlarmMonitorAttachOrderTests`, and `ApiKeyFailureLimiterTests` filter passed +**55/55** tests in 12 s; `dotnet build src/ZB.MOM.WW.MxGateway.NonWindows.slnx` +succeeded with **0 warnings / 0 errors** in 3.42 s. Finding commits: GWC-33 +`b0156c6`, GWC-35 `7807201`, and SEC-38/SEC-39 `1875426`. #### J — secondary contracts