ci: drop the nightly-windev schedule; run the deep windev tier on demand
ci / portable (push) Failing after 10m10s
ci / java (push) Failing after 20m12s
ci / windows-x86 (push) Failing after 22m40s

The scheduled nightly-windev job failed most nights for host reasons and
filed a Gitea issue each time. Remove the cron trigger and the job, and add
a workflow_dispatch trigger whose windev_mode input (test/build/live) drives
the windows-x86 job, so the live tier runs on demand - from the Actions page
or via scripts/ci/run-windev-ci.sh live - the same way clients are packed and
published on demand. Docs updated to match.

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Joseph Doherty
2026-11-15 09:42:13 -05:00
parent 26a90883fa
commit e74918ccfb
7 changed files with 65 additions and 85 deletions
+23 -53
View File
@@ -3,19 +3,29 @@
# Scope note: the x86 Worker (src/ZB.MOM.WW.MxGateway.Worker) and Worker.Tests target
# .NET Framework 4.8 / x86 and need MXAccess COM installed, so they build ONLY on a Windows host.
# They are out of scope for this Linux `portable` job — the `windows-x86` job below builds and
# tests them on windev (10.100.0.48) over SSH (see scripts/ci/run-windev-ci.sh), and the nightly
# `nightly-windev` job additionally runs the full solution build, gateway suite, and live-MXAccess
# smoke, which are scheduled-only so they never gate a push.
# tests them on windev (10.100.0.48) over SSH (see scripts/ci/run-windev-ci.sh).
#
# There is no scheduled run. The deep windev tier (full-slnx build, gateway suite, live-MXAccess
# smoke) is on demand, the same way the clients are packed and published on demand: either
# dispatch this workflow by hand with `windev_mode: live`, or run
# `CI_SHA=<sha> scripts/ci/run-windev-ci.sh live` from a machine with SSH access to windev.
# The old `nightly-windev` cron job failed on most nights for host reasons and filed an issue
# each time, so it was removed (2026-11-15).
name: ci
on:
push:
pull_request:
schedule:
# 06:00 UTC nightly: x86 Worker build + Worker.Tests, full-slnx build, gateway tests, then the
# live-MXAccess smoke (MXGATEWAY_RUN_LIVE_MXACCESS_TESTS=1), serialized on windev's host lock.
# Push/PR runs skip it — the job is gated `if: github.event_name == 'schedule'`.
- cron: '0 6 * * *'
workflow_dispatch:
inputs:
windev_mode:
description: 'windev tier for the windows-x86 job (test = x86 Worker build + Worker.Tests; live = test + full slnx + gateway suite + live-MXAccess smoke)'
type: choice
options:
- test
- build
- live
default: test
jobs:
portable:
@@ -165,12 +175,6 @@ jobs:
# actions), and a `runs-on` gate with no matching runner wedges the queue in "queued" forever.
# An unreachable windev fails this job RED (loud), never leaves it stuck. A red job can mean the
# Windows tier is down rather than the change — see docs/GatewayTesting.md § Continuous Integration.
#
# Skipped on the schedule: nightly-windev's `live` mode already runs this exact build + test as
# its first two tiers, and running both made every scheduled run start two windev sessions in
# the same second, contending for the one CI clone (the 2026-09-22 index.lock failure, run 827,
# mxaccessgw#150) and doubling the nightly's load on a host that was already short of memory.
if: github.event_name != 'schedule'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
@@ -183,47 +187,13 @@ jobs:
WINDEV_SSH_KEY: ${{ secrets.WINDEV_SSH_KEY }}
WINDEV_SSH_USER: ${{ vars.WINDEV_SSH_USER }}
CI_SHA: ${{ github.sha }}
# Push/PR runs have no inputs, so they fall back to `test`; a manual dispatch picks the mode.
WINDEV_MODE: ${{ inputs.windev_mode || 'test' }}
# `test` = x86 build + Worker.Tests (~50s measured on windev). Demote to `build` only if the
# test step ever exceeds ~10 min; the x86 build alone still guards the net48/CS0246/x86 class.
run: ./scripts/ci/run-windev-ci.sh test
nightly-windev:
# TST-35: scheduled deep run — Worker, full-slnx, gateway, and live-smoke tiers on windev.
# Gated to the schedule event via `if:` (not an unsatisfiable `runs-on`), so push/PR runs mark it
# skipped, not queued. Never gates a push. On failure it opens a Gitea issue so a red nightly is
# visible even though nobody watches the Actions page.
if: github.event_name == 'schedule'
runs-on: ubuntu-latest
env:
# `github.server_url` is the URL Gitea hands the runner — the docker-network-internal
# `http://gitea:3000`. That is the right base for the issue-creation API call below (the job
# container resolves `gitea` only on that network, and has no LAN egress to the public origin),
# but it is useless as a link a human clicks out of the issue. So browser-facing URLs in the
# issue body use the public origin instead. TST-25 acceptance Check 6 caught this: every
# nightly issue since #126 carried an unreachable `http://gitea:3000/...` run link.
PUBLIC_SERVER_URL: https://gitea.dohertylan.com
steps:
- uses: actions/checkout@v4
- name: Worker + gateway tests + live-MXAccess smoke on windev
env:
# WINDEV_SSH_KEY is stored base64-encoded (single line) so Gitea's line-oriented secret
# masker redacts it in the step env echo; run-windev-ci.sh decodes it. A raw multiline PEM
# would leak in cleartext here (TST-25 acceptance: no key material in logs). Known-hosts is
# public and comes from the committed scripts/ci/windev.known_hosts pin (no secret needed).
WINDEV_SSH_KEY: ${{ secrets.WINDEV_SSH_KEY }}
WINDEV_SSH_USER: ${{ vars.WINDEV_SSH_USER }}
CI_SHA: ${{ github.sha }}
run: ./scripts/ci/run-windev-ci.sh live
- name: Report a red nightly as a Gitea issue
if: failure()
run: |
curl -sSf -X POST \
-H "Authorization: token ${{ github.token }}" \
-H "Content-Type: application/json" \
"${{ github.server_url }}/api/v1/repos/${{ github.repository }}/issues" \
-d "{\"title\":\"nightly-windev failed on ${{ github.sha }}\",\"body\":\"The scheduled windev Worker + live-MXAccess run failed: ${PUBLIC_SERVER_URL}/${{ github.repository }}/actions/runs/${{ github.run_id }} . A red nightly may mean the Windows tier is down rather than the change — see docs/GatewayTesting.md (Continuous Integration).\"}"
run: ./scripts/ci/run-windev-ci.sh "$WINDEV_MODE"
# NOTE: there is intentionally no native `windows` runner job. act_runner v0.6.1 host-mode on
# Windows is broken and Windows containers are impractical for the net48/x86/MXAccess Worker, so the
# Windows tier runs via the SSH-driven `windows-x86` (per-push) and `nightly-windev` (scheduled)
# jobs above. Restore a native job only alongside a Windows runner that actually works.
# Windows tier runs via the SSH-driven `windows-x86` job above (per push/PR, or on demand with a
# chosen mode via workflow_dispatch). Restore a native job only alongside a Windows runner that actually works.