fix(IPC-36,IPC-37): guard secondary contracts

src/ZB.MOM.WW.MxGateway.Worker/Bootstrap/WorkerOptions.cs

@@ -1,10 +1,13 @@
 namespace ZB.MOM.WW.MxGateway.Worker.Bootstrap;
 
+using ZB.MOM.WW.MxGateway.Contracts;
+
 /// <summary>Worker bootstrap options passed via environment variables and named pipes.</summary>
 public sealed class WorkerOptions
 {
     /// <summary>Environment variable name for the worker nonce.</summary>
-    public const string NonceEnvironmentVariableName = "MXGATEWAY_WORKER_NONCE";
+    [Obsolete("Use WorkerLaunchEnvironment.WorkerNonce.")]
+    public const string NonceEnvironmentVariableName = WorkerLaunchEnvironment.WorkerNonce;
 
     /// <summary>Initializes worker options from a bootstrap handshake.</summary>
     /// <param name="sessionId">Identifier of the session.</param>

src/ZB.MOM.WW.MxGateway.Worker/Bootstrap/WorkerOptionsParser.cs

@@ -75,7 +75,7 @@ public sealed class WorkerOptionsParser
                 [$"Unsupported protocol version '{protocolVersionText}'."]);
         }
 
-        string? nonce = _environment.GetEnvironmentVariable(WorkerOptions.NonceEnvironmentVariableName);
+        string? nonce = _environment.GetEnvironmentVariable(WorkerLaunchEnvironment.WorkerNonce);
 
         if (string.IsNullOrWhiteSpace(nonce))
         {

src/ZB.MOM.WW.MxGateway.Worker/Ipc/WorkerPipeClient.cs

@@ -4,6 +4,7 @@ using System.IO;
 using System.IO.Pipes;
 using System.Threading;
 using System.Threading.Tasks;
+using ZB.MOM.WW.MxGateway.Contracts;
 using ZB.MOM.WW.MxGateway.Worker.Bootstrap;
 using Polly;
 using Polly.Retry;
@@ -22,8 +23,9 @@ public sealed class WorkerPipeClient : IWorkerPipeClient
     public const int DefaultConnectAttemptTimeoutMilliseconds = 2000;
 
     /// <summary>Environment variable for overriding the per-attempt connection timeout.</summary>
+    [Obsolete("Use WorkerLaunchEnvironment.PipeConnectAttemptTimeoutMilliseconds.")]
     public const string ConnectAttemptTimeoutEnvironmentVariableName =
-        "MXGATEWAY_WORKER_PIPE_CONNECT_ATTEMPT_TIMEOUT_MS";
+        WorkerLaunchEnvironment.PipeConnectAttemptTimeoutMilliseconds;
 
     private readonly int _connectTimeoutMilliseconds;
     private readonly int _connectAttemptTimeoutMilliseconds;
@@ -255,7 +257,8 @@ public sealed class WorkerPipeClient : IWorkerPipeClient
 
     private static int ResolveDefaultConnectAttemptTimeoutMilliseconds()
     {
-        string? configuredValue = Environment.GetEnvironmentVariable(ConnectAttemptTimeoutEnvironmentVariableName);
+        string? configuredValue = Environment.GetEnvironmentVariable(
+            WorkerLaunchEnvironment.PipeConnectAttemptTimeoutMilliseconds);
         return int.TryParse(configuredValue, out int milliseconds) && milliseconds > 0
             ? milliseconds
             : DefaultConnectAttemptTimeoutMilliseconds;

src/ZB.MOM.WW.MxGateway.Worker/MxAccess/MxAccessEventQueue.cs

@@ -5,6 +5,7 @@ using System.Threading;
 using System.Threading.Tasks;
 using Google.Protobuf;
 using Google.Protobuf.WellKnownTypes;
+using ZB.MOM.WW.MxGateway.Contracts;
 using ZB.MOM.WW.MxGateway.Contracts.Proto;
 
 namespace ZB.MOM.WW.MxGateway.Worker.MxAccess;
@@ -45,8 +46,6 @@ public sealed class MxAccessEventQueue
     ///     <see cref="DefaultCapacity"/> — a bad environment value must never
     ///     keep the session from starting.
     /// </summary>
-    internal const string CapacityEnvironmentVariableName = "MXGATEWAY_EVENT_QUEUE_CAPACITY";
-
     /// <summary>
     ///     Floor on the resolved capacity. Mirrors the gateway-side
     ///     <c>MxGateway:Worker:EventQueueCapacity</c> minimum so a value that
@@ -140,7 +139,7 @@ public sealed class MxAccessEventQueue
     /// <returns>The capacity to construct the outbound event queue with.</returns>
     internal static int ResolveCapacity()
     {
-        string? value = Environment.GetEnvironmentVariable(CapacityEnvironmentVariableName);
+        string? value = Environment.GetEnvironmentVariable(WorkerLaunchEnvironment.EventQueueCapacity);
         return int.TryParse(
                 value,
                 NumberStyles.Integer,

src/ZB.MOM.WW.MxGateway.Worker/MxAccess/MxAccessStaSession.cs

@@ -3,6 +3,7 @@ using System.Collections.Generic;
 using System.Diagnostics;
 using System.Threading;
 using System.Threading.Tasks;
+using ZB.MOM.WW.MxGateway.Contracts;
 using ZB.MOM.WW.MxGateway.Contracts.Proto;
 using ZB.MOM.WW.MxGateway.Worker.Conversion;
 using ZB.MOM.WW.MxGateway.Worker.Sta;
@@ -16,17 +17,11 @@ public sealed class MxAccessStaSession : IWorkerRuntimeSession
     ///     MxGateway:Worker:WriteCompletionWaitMilliseconds. 0 disables the
     ///     write-completion wait (pure fire-and-forget replies).
     /// </summary>
-    internal const string WriteCompletionWaitEnvironmentVariableName =
-        "MXGATEWAY_WORKER_WRITE_COMPLETION_WAIT_MS";
-
     /// <summary>
     ///     Environment variable the gateway's WorkerProcessLauncher sets from
     ///     MxGateway:Alarms:PollIntervalMilliseconds. A missing or invalid
     ///     value falls back to <see cref="DefaultAlarmPollInterval"/>.
     /// </summary>
-    internal const string AlarmPollIntervalEnvironmentVariableName =
-        "MXGATEWAY_ALARM_POLL_INTERVAL_MS";
-
     /// <summary>
     ///     Floor on the resolved alarm poll cadence. Mirrors the gateway-side
     ///     MxGateway:Alarms:PollIntervalMilliseconds minimum so a value that
@@ -211,7 +206,7 @@ public sealed class MxAccessStaSession : IWorkerRuntimeSession
     /// </summary>
     internal static TimeSpan ResolveWriteCompletionTimeout()
     {
-        string? value = Environment.GetEnvironmentVariable(WriteCompletionWaitEnvironmentVariableName);
+        string? value = Environment.GetEnvironmentVariable(WorkerLaunchEnvironment.WriteCompletionWaitMilliseconds);
         return int.TryParse(
                 value,
                 System.Globalization.NumberStyles.Integer,
@@ -233,7 +228,7 @@ public sealed class MxAccessStaSession : IWorkerRuntimeSession
     /// <returns>The cadence the alarm poll loop waits between polls.</returns>
     internal static TimeSpan ResolveAlarmPollInterval()
     {
-        string? value = Environment.GetEnvironmentVariable(AlarmPollIntervalEnvironmentVariableName);
+        string? value = Environment.GetEnvironmentVariable(WorkerLaunchEnvironment.AlarmPollIntervalMilliseconds);
         if (!int.TryParse(
                 value,
                 System.Globalization.NumberStyles.Integer,

src/ZB.MOM.WW.MxGateway.Worker/MxAccess/WnWrapAlarmConsumer.cs

@@ -5,6 +5,7 @@ using System.Globalization;
 using System.Runtime.InteropServices;
 using System.Xml;
 using WNWRAPCONSUMERLib;
+using ZB.MOM.WW.MxGateway.Contracts;
 
 namespace ZB.MOM.WW.MxGateway.Worker.MxAccess;
 
@@ -75,9 +76,6 @@ public sealed class WnWrapAlarmConsumer : IMxAccessAlarmConsumer
     ///     <see cref="DefaultMaxAlarmsPerFetch"/> — a bad environment value
     ///     must never keep the alarm consumer from starting.
     /// </summary>
-    internal const string MaxAlarmsPerFetchEnvironmentVariableName =
-        "MXGATEWAY_ALARM_MAX_ALARMS_PER_FETCH";
-
     /// <summary>
     ///     Minimum gap between truncated-fetch warnings. A galaxy parked above
     ///     the cap truncates on *every* poll, so an unthrottled warning would
@@ -156,7 +154,7 @@ public sealed class WnWrapAlarmConsumer : IMxAccessAlarmConsumer
     /// <returns>The cap passed to <c>GetXmlCurrentAlarms2</c>.</returns>
     internal static int ResolveMaxAlarmsPerFetch()
     {
-        string? value = Environment.GetEnvironmentVariable(MaxAlarmsPerFetchEnvironmentVariableName);
+        string? value = Environment.GetEnvironmentVariable(WorkerLaunchEnvironment.MaxAlarmsPerFetch);
         return int.TryParse(
                 value,
                 NumberStyles.Integer,