Fix reliability findings

2026-04-28 06:27:01 -04:00
parent 907aa49aea
commit b0041c5d18
9 changed files with 233 additions and 21 deletions
@@ -184,8 +184,11 @@ public sealed class SessionManager : ISessionManager
                    exception,
                    "Graceful shutdown failed for session {SessionId}; killing worker.",
                    session.SessionId);
-                session.KillWorker(GatewayShutdownReason);
-                await RemoveSessionAsync(session).ConfigureAwait(false);
+                if (_registry.TryGet(session.SessionId, out _))
+                {
+                    session.KillWorker(GatewayShutdownReason);
+                    await RemoveSessionAsync(session).ConfigureAwait(false);
+                }
            }
        }
    }
@@ -210,7 +213,13 @@ public sealed class SessionManager : ISessionManager
        catch (Exception exception)
        {
            session.MarkFaulted(exception.Message);
+            if (!wasClosed)
+            {
+                _metrics.SessionRemoved();
+            }
+
            _metrics.Fault(SessionManagerErrorCode.CloseFailed.ToString());
+            await RemoveSessionAsync(session).ConfigureAwait(false);
            throw new SessionManagerException(
                SessionManagerErrorCode.CloseFailed,
                $"Failed to close session {session.SessionId}.",