test(WRK-21): keep the drain-to-empty walk inside the pipe harness envelope
ci / nightly-windev (push) Has been skipped
ci / windows-x86 (push) Successful in 1m14s
ci / java (push) Successful in 2m12s
ci / portable (push) Successful in 8m2s

PipePair runs both ends of a duplex pipe in one process with blocking
FlushFileBuffers under every frame write, so it wedges after roughly 85 large
round trips. Drain the full 10,000 byte-heavy events to empty at the queue layer,
where the no-loss property actually lives, and keep the pipe walk at 1,000 events
(29 replies) so it still proves the split end to end. Also give the truncation
test's budget slack: item handle 0 is a proto3 default and is not serialized, so
the probe measurement is a lower bound on the fixture's per-event cost.
This commit is contained in:
Joseph Doherty
2026-08-07 06:50:17 -04:00
parent 7c2eaf09e2
commit a2565604df
2 changed files with 70 additions and 12 deletions
@@ -20,15 +20,17 @@ public sealed class WorkerPipeSessionTests
private const string Nonce = "nonce-secret";
// Byte-heavy drain fixture (WRK-21). 10,000 events at ~1.7 KiB each is ~17 MB of queue — far
// more than one frame — so DrainEvents must split across replies.
// more than one frame — so DrainEvents must truncate.
//
// The negotiated frame maximum is deliberately small. What is under test is the byte cap, and
// it behaves identically at any frame size, but this harness is not the production gateway:
// PipePair has no continuous read pump, so the test thread only drains the pipe while it sits
// in ReadUntilAsync. Multi-megabyte frames interleaved with the heartbeat loop can therefore
// wedge both ends inside FlushFileBuffers, each waiting for the other to read. A frame maximum
// well under the pipe buffer keeps the harness honest without weakening a single assertion.
// Two limits below are harness accommodations, not properties of the fix. PipePair runs both
// ends of a duplex pipe inside one process, with no continuous read pump and with blocking
// FlushFileBuffers under every frame write, so it tolerates neither multi-megabyte frames nor
// hundreds of large round trips before both ends wedge waiting on each other. Hence a small
// negotiated frame maximum, and a smaller queue for the drain-to-empty walk. The byte cap
// behaves identically at any frame size; exhaustive no-loss over the full 10,000 events is
// covered without a pipe by MxAccessEventQueueTests.
private const int ByteHeavyEventCount = 10_000;
private const int RepeatedDrainEventCount = 1_000;
private const int ByteHeavyEventPayloadBytes = 1_800;
private const uint NegotiatedMaxFrameBytes = 128 * 1024;
@@ -576,7 +578,7 @@ public sealed class WorkerPipeSessionTests
FakeRuntimeSession runtime = new()
{
SuppressDrainForBatchSize = 128,
BackingQueue = CreateByteHeavyQueue(ByteHeavyEventCount, ByteHeavyEventPayloadBytes),
BackingQueue = CreateByteHeavyQueue(RepeatedDrainEventCount, ByteHeavyEventPayloadBytes),
};
WorkerPipeSession session = CreatePipeSession(pipePair.WorkerStream, runtime);
Task runTask = session.RunAsync(cancellation.Token);
@@ -616,13 +618,13 @@ public sealed class WorkerPipeSessionTests
recovered.Add(drained.WorkerSequence);
}
Assert.True(replyCount < 1_000, "DrainEvents made no progress across 1,000 replies.");
Assert.True(replyCount < 200, "DrainEvents made no progress across 200 replies.");
}
// More than one reply proves the drain really split; every event came back exactly once, in
// enqueue order.
Assert.True(replyCount > 2, $"Expected the byte cap to split the drain, saw {replyCount} replies.");
Assert.Equal(ByteHeavyEventCount, recovered.Count);
Assert.Equal(RepeatedDrainEventCount, recovered.Count);
for (int index = 0; index < recovered.Count; index++)
{
Assert.Equal((ulong)(index + 1), recovered[index]);