dohertj2/mxaccessgw
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(clients): resolve 2026-06-18 array-write review findings

Browse Source 
- Client.Dotnet-030: add advise-supervisory to IsKnownGatewayCommand (was dead/unreachable, exit 2)
- Client.Go-035/036/037: usage+README list advise-supervisory; add session-id guard test; fix write2 README wording
- Client.Python-037/038: drop regressed 'scaffold' from pyproject; add advise-supervisory CLI tests
- Client.Rust-039/040: document write_array_elements/advise-supervisory in design doc; pin outer MxValue data_type==0
- Client.Java-049/050/051: sync CLIENT_VERSION to 0.1.2; add advise-supervisory test; guard negative uint32 inputs (pending windev gradle verification)

Client READMEs also updated for Server-057 add-family normalization wording.
.NET/Go/Python/Rust verified green locally; Java pending windev.
This commit is contained in:
Joseph Doherty
2026-06-18 10:58:33 -04:00
parent 85ef453d0d
commit 6c853b43af
22 changed files with 404 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files
clients/java/zb-mom-ww-mxgateway-cli/src/test/java/com/zb/mom/ww/mxgateway/cli/MxGatewayCliTests.java
+24 -3
View File
@@ -56,7 +56,7 @@ final class MxGatewayCliTests {
assertEquals(0, run.exitCode());
assertEquals("", run.errors());
assertTrue(run.output().contains("mxgateway-java 0.1.1"));
assertTrue(run.output().contains("mxgateway-java 0.1.2"));
assertTrue(run.output().contains("gatewayProtocolVersion=3"));
assertTrue(run.output().contains("workerProtocolVersion=1"));
}
@@ -86,7 +86,7 @@ final class MxGatewayCliTests {
CliRun run = execute(new FakeClientFactory(), "version", "--json");
assertEquals(0, run.exitCode());
assertTrue(run.output().contains("\"clientVersion\":\"0.1.1\""));
assertTrue(run.output().contains("\"clientVersion\":\"0.1.2\""));
assertTrue(run.output().contains("\"gatewayProtocolVersion\":3"));
}
@@ -148,6 +148,26 @@ final class MxGatewayCliTests {
assertTrue(run.output().contains("\"itemHandle\":7"));
}
@Test
void adviseSupervisoryCommandCallsAdviseSupervisoryRaw() {
// Client.Java-050: dedicated test for advise-supervisory, using a
// separate adviseSupervisoryCalled flag so it cannot be masked by the
// plain advise path that shares adviseCalled.
FakeClientFactory factory = new FakeClientFactory();
CliRun run = execute(
factory,
"advise-supervisory",
"--session-id", "session-cli",
"--server-handle", "12",
"--item-handle", "34",
"--json");
assertEquals(0, run.exitCode());
assertTrue(factory.client.session.adviseSupervisoryCalled);
assertFalse(factory.client.session.adviseCalled, "plain advise must not be called");
assertTrue(run.output().contains("\"kind\":\"MX_COMMAND_KIND_ADVISE_SUPERVISORY\""));
}
// ---- ping subcommand (D4) ----
@Test
@@ -1235,6 +1255,7 @@ final class MxGatewayCliTests {
private boolean registerCalled;
private boolean addItemCalled;
private boolean adviseCalled;
private boolean adviseSupervisoryCalled;
private MxValue lastWriteValue;
private String lastPingMessage;
private long lastReadBulkTimeoutMs;
@@ -1304,7 +1325,7 @@ final class MxGatewayCliTests {
@Override
public MxCommandReply adviseSupervisoryRaw(int serverHandle, int itemHandle) {
adviseCalled = true;
adviseSupervisoryCalled = true;
return MxCommandReply.newBuilder()
.setKind(MxCommandKind.MX_COMMAND_KIND_ADVISE_SUPERVISORY)
.setProtocolStatus(ok())