gateway: alarm-RPC dispatcher seam (PRs A.6 + A.7)

Replaces the inline diagnostic strings in PR A.3's AcknowledgeAlarm + QueryActiveAlarms handlers with an IAlarmRpcDispatcher seam. - IAlarmRpcDispatcher (new) — gateway-side abstraction over the worker-RPC path that fronts AlarmClient.AlarmAckByGUID and the active-alarm walk. AcknowledgeAsync returns the AcknowledgeAlarmReply directly; QueryActiveAlarmsAsync yields an IAsyncEnumerable<ActiveAlarmSnapshot>. - NotWiredAlarmRpcDispatcher (new, default impl) — returns PROTOCOL_STATUS_OK with a structured worker-pending diagnostic on Acknowledge, yields an empty stream on QueryActiveAlarms. Same observable shape as PR A.3, but the integration seam is now in code instead of hardcoded inside the handler. - MxAccessGatewayService — handlers delegate to the dispatcher. Constructor accepts an optional IAlarmRpcDispatcher (default NotWiredAlarmRpcDispatcher); a future WorkerAlarmRpcDispatcher registration in DI swaps in the live worker-IPC routing without changing the public RPC surface. - 2 new dispatcher tests pin the not-wired contract; 279 → 281 total tests, all green. Worker-side dispatch (translating Acknowledge / QueryActiveAlarms to the IPC method that calls IMxAccessAlarmConsumer from PR A.5) is the dev-rig follow-up — it depends on validating the AVEVA GetAlarmChangesCompleted event subscription against a live alarm provider before pinning a wire format. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-30 22:47:42 -04:00
parent c7d5b83390
commit 6b3c117d1e
4 changed files with 171 additions and 13 deletions
@@ -0,0 +1,54 @@
+using System.Threading;
+using System.Threading.Tasks;
+using MxGateway.Contracts.Proto;
+using MxGateway.Server.Sessions;
+
+namespace MxGateway.Tests.Gateway.Sessions;
+
+/// <summary>
+///     PR A.6 / A.7 — pins the not-yet-wired dispatcher's behaviour:
+///     AcknowledgeAsync returns OK with a worker-pending diagnostic and
+///     QueryActiveAlarmsAsync yields an empty stream. Production
+///     <c>WorkerAlarmRpcDispatcher</c> (dev-rig follow-up) replaces this
+///     impl in DI without changing the gateway handler shape.
+/// </summary>
+public sealed class NotWiredAlarmRpcDispatcherTests
+{
+    [Fact]
+    public async Task AcknowledgeAsync_returns_ok_with_worker_pending_diagnostic()
+    {
+        IAlarmRpcDispatcher dispatcher = new NotWiredAlarmRpcDispatcher();
+
+        AcknowledgeAlarmReply reply = await dispatcher.AcknowledgeAsync(
+            new AcknowledgeAlarmRequest
+            {
+                SessionId = "session-1",
+                ClientCorrelationId = "corr-1",
+                AlarmFullReference = "Tank01.Level.HiHi",
+                Comment = "investigating",
+                OperatorUser = "alice",
+            },
+            CancellationToken.None);
+
+        Assert.Equal(ProtocolStatusCode.Ok, reply.ProtocolStatus.Code);
+        Assert.Equal("session-1", reply.SessionId);
+        Assert.Equal("corr-1", reply.CorrelationId);
+        Assert.Contains("worker", reply.DiagnosticMessage, System.StringComparison.OrdinalIgnoreCase);
+    }
+
+    [Fact]
+    public async Task QueryActiveAlarmsAsync_yields_no_snapshots()
+    {
+        IAlarmRpcDispatcher dispatcher = new NotWiredAlarmRpcDispatcher();
+
+        int count = 0;
+        await foreach (ActiveAlarmSnapshot _ in dispatcher.QueryActiveAlarmsAsync(
+            new QueryActiveAlarmsRequest { SessionId = "session-1" },
+            CancellationToken.None))
+        {
+            count++;
+        }
+
+        Assert.Equal(0, count);
+    }
+}