ci(tst-03): fix orphan-terminator test on Linux + refresh stale java worker codegen
ci / live-mxaccess (push) Waiting to run
ci / java (push) Successful in 1m56s
ci / portable (push) Failing after 7m32s
ci / windows (push) Failing after 8s

Two real defects the CI run surfaced (driving to fully green):

- OrphanWorkerTerminatorTests hard-coded a Windows path (C:\...); on the Linux
  runner Path.GetFullPath does not root it, so the terminator's exact-path match
  found nothing (Expected 2/1 kills, Actual 0). Use an OS-appropriate normalized
  path so the matching logic is validated on every platform (5/5 pass locally).
- clients/java generated MxaccessWorker.java was stale — missing the canonical
  max_frame_bytes field. Refreshed via `gradle generateProto` (protobuf 4.33.1,
  the pinned version — the diff is purely the field, no version churn). Broaden
  the ci.yml churn-revert to both generated aggregates so verify-clean still
  guards real drift elsewhere.

Claude-Session: https://claude.ai/code/session_01DMXXvNuPekkkrTEyPNxEkW
This commit is contained in:
Joseph Doherty
2026-07-10 04:01:33 -04:00
parent 866d053ec2
commit 576179bd3f
3 changed files with 193 additions and 61 deletions
+5 -1
View File
@@ -112,7 +112,11 @@ jobs:
working-directory: clients/java
run: gradle test
- name: Revert spurious protobuf-version churn (no .proto changed)
run: git checkout -- clients/java/src/main/generated/main/java/mxaccess_gateway/v1/MxaccessGateway.java || true
# Both generated aggregates can pick up protobuf-runtime-version churn on regen; revert
# both so verify-clean still catches a real, uncommitted proto/codegen change elsewhere.
run: |
git checkout -- clients/java/src/main/generated/main/java/mxaccess_gateway/v1/MxaccessGateway.java || true
git checkout -- clients/java/src/main/generated/main/java/mxaccess_worker/v1/MxaccessWorker.java || true
- name: Verify generated tree is clean
run: git diff --exit-code -- clients/java/src/main/generated