fix(dashboard): pilot native dialog focus and safe dismissal

This commit is contained in:
Joseph Doherty
2026-11-13 17:51:02 -05:00
parent 3e004708d4
commit 260d58afa1
32 changed files with 1750 additions and 40 deletions
@@ -0,0 +1,26 @@
"""Focused validation/focus contract, not an additional visual polish pass."""
import json,sys
from pathlib import Path
from playwright.sync_api import sync_playwright
ROOT=Path(__file__).resolve().parent
sys.path.insert(0,'/Users/dohertj2/.codex/worktrees/scada-ui-consistency/scadaproj/components/ui-theme/validation/theme-1.0.0/canary')
from browser_zoom import zoom_browser,set_browser_zoom
BASE=json.load(open('/tmp/mx-ui-canary-state.json'))['origin'];measurements=[]
with sync_playwright() as p:
with zoom_browser(p) as (ctx,worker):
page=ctx.new_page()
for width,zoom in [(1440,1),(390,1),(1440,2)]:
page.set_viewport_size({'width':width,'height':900});page.goto(BASE);page.wait_for_selector('html[data-mx-ready="true"]');set_browser_zoom(worker,page,zoom)
page.get_by_role('button',name='Create API Key',exact=True).click();page.locator('dialog:modal').wait_for()
page.wait_for_function("document.querySelector('#keyId')===document.activeElement")
initial=page.locator('#keyId').evaluate('(e)=>{const r=e.getBoundingClientRect();return r.top>=0&&r.bottom<=innerHeight}')
samples=[]
for _ in range(60):
page.keyboard.press('Tab');samples.append(page.evaluate("({inside:document.querySelector('dialog:modal').contains(document.activeElement),documentHasFocus:document.hasFocus()})"))
assert all(s['inside'] or not s['documentHasFocus'] for s in samples)
page.get_by_role('button',name='Save',exact=True).click();page.locator('dialog:modal').get_by_role('alert').wait_for()
measure=page.locator('dialog:modal').get_by_role('alert').evaluate('''e=>{const r=e.getBoundingClientRect(),d=e.closest('dialog').getBoundingClientRect();const scroll=e.closest('.modal-body');const s=scroll?.getBoundingClientRect();return {alert:{top:r.top,bottom:r.bottom},dialog:{top:d.top,bottom:d.bottom},body:s?{top:s.top,bottom:s.bottom}:null,visible:r.top>=Math.max(0,d.top,s?.top??0)&&r.bottom<=Math.min(innerHeight,d.bottom,s?.bottom??innerHeight)}}''')
measure.update(width=page.evaluate('innerWidth'),zoom=zoom,initialKeyIdVisible=initial,tabSamples=len(samples),chromeSamples=sum(not s['documentHasFocus'] for s in samples));measurements.append(measure)
page.keyboard.press('Escape');page.wait_for_function("!document.querySelector('dialog:modal')");set_browser_zoom(worker,page,1)
path=ROOT/'evidence/mx02'/sys.argv[1];path.write_text(json.dumps(measurements,indent=2));print(json.dumps(measurements,indent=2))
assert all(m['visible'] and m['initialKeyIdVisible'] for m in measurements),'Validation or initial field outside visible modal viewport'