dohertj2/mxaccessgw
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Point the Python client at the StreamAlarms alarm feed

Browse Source 
Regenerate the Python protobuf stubs and replace query_active_alarms
with stream_alarms, an AsyncIterator over AlarmFeedMessage served by
the gateway's central alarm monitor (snapshot, snapshot_complete, then
live transitions). Drops session_id from the acknowledge surface.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Joseph Doherty
2026-05-21 16:45:53 -04:00
parent 9328c4f657
commit 1ad0be8276
5 changed files with 165 additions and 152 deletions
Download Patch File Download Diff File Expand all files Collapse all files
clients/python/tests/test_alarms.py
+62 -61
View File
@@ -1,8 +1,7 @@
"""Tests for the AcknowledgeAlarm + QueryActiveAlarms client surface (PR E.3)."""
"""Tests for the AcknowledgeAlarm + StreamAlarms client surface."""
from __future__ import annotations
import asyncio
from typing import Any
import grpc
@@ -18,7 +17,6 @@ async def test_acknowledge_alarm_sends_request_and_returns_reply() -> None:
stub = FakeGatewayStub()
stub.acknowledge_alarm.replies = [
pb.AcknowledgeAlarmReply(
session_id="session-1",
correlation_id="corr-7",
protocol_status=pb.ProtocolStatus(code=pb.PROTOCOL_STATUS_CODE_OK),
status=pb.MxStatusProxy(success=1, category=pb.MX_STATUS_CATEGORY_OK),
@@ -31,7 +29,6 @@ async def test_acknowledge_alarm_sends_request_and_returns_reply() -> None:
reply = await client.acknowledge_alarm(
pb.AcknowledgeAlarmRequest(
session_id="session-1",
client_correlation_id="corr-7",
alarm_full_reference="Tank01.Level.HiHi",
comment="investigating",
@@ -61,7 +58,6 @@ async def test_acknowledge_alarm_unauthenticated_raises_typed_error() -> None:
with pytest.raises(MxGatewayAuthenticationError):
await client.acknowledge_alarm(
pb.AcknowledgeAlarmRequest(
session_id="session-1",
alarm_full_reference="Tank01.Level.HiHi",
comment="",
operator_user="alice",
@@ -81,7 +77,6 @@ async def test_acknowledge_alarm_permission_denied_raises_typed_error() -> None:
with pytest.raises(MxGatewayAuthorizationError):
await client.acknowledge_alarm(
pb.AcknowledgeAlarmRequest(
session_id="session-1",
alarm_full_reference="Tank01.Level.HiHi",
comment="",
operator_user="alice",
@@ -90,84 +85,90 @@ async def test_acknowledge_alarm_permission_denied_raises_typed_error() -> None:
@pytest.mark.asyncio
async def test_query_active_alarms_streams_snapshots() -> None:
snapshots = [
pb.ActiveAlarmSnapshot(
alarm_full_reference="Tank01.Level.HiHi",
current_state=pb.ALARM_CONDITION_STATE_ACTIVE,
severity=750,
async def test_stream_alarms_streams_snapshot_then_snapshot_complete() -> None:
messages = [
pb.AlarmFeedMessage(
active_alarm=pb.ActiveAlarmSnapshot(
alarm_full_reference="Tank01.Level.HiHi",
current_state=pb.ALARM_CONDITION_STATE_ACTIVE,
severity=750,
),
),
pb.ActiveAlarmSnapshot(
alarm_full_reference="Tank02.Level.HiHi",
current_state=pb.ALARM_CONDITION_STATE_ACTIVE_ACKED,
severity=750,
pb.AlarmFeedMessage(
active_alarm=pb.ActiveAlarmSnapshot(
alarm_full_reference="Tank02.Level.HiHi",
current_state=pb.ALARM_CONDITION_STATE_ACTIVE_ACKED,
severity=750,
),
),
pb.AlarmFeedMessage(snapshot_complete=True),
]
stream = FakeSnapshotStream(snapshots)
stub = FakeGatewayStub(snapshot_stream=stream)
stream = FakeAlarmFeedStream(messages)
stub = FakeGatewayStub(alarm_feed_stream=stream)
client = await GatewayClient.connect(
ClientOptions(endpoint="fake", api_key="mxgw_test_secret", plaintext=True),
stub=stub,
)
received: list[pb.ActiveAlarmSnapshot] = []
async for snapshot in client.query_active_alarms(
pb.QueryActiveAlarmsRequest(session_id="session-1"),
):
received.append(snapshot)
received: list[pb.AlarmFeedMessage] = []
async for message in client.stream_alarms(pb.StreamAlarmsRequest()):
received.append(message)
assert len(received) == 2
assert received[0].alarm_full_reference == "Tank01.Level.HiHi"
assert received[0].current_state == pb.ALARM_CONDITION_STATE_ACTIVE
assert received[1].current_state == pb.ALARM_CONDITION_STATE_ACTIVE_ACKED
assert stub.query_metadata == (("authorization", "Bearer mxgw_test_secret"),)
assert len(received) == 3
assert received[0].active_alarm.alarm_full_reference == "Tank01.Level.HiHi"
assert received[0].active_alarm.current_state == pb.ALARM_CONDITION_STATE_ACTIVE
assert received[1].active_alarm.current_state == pb.ALARM_CONDITION_STATE_ACTIVE_ACKED
assert received[2].snapshot_complete is True
assert stub.stream_metadata == (("authorization", "Bearer mxgw_test_secret"),)
@pytest.mark.asyncio
async def test_query_active_alarms_passes_filter_prefix() -> None:
stream = FakeSnapshotStream([])
stub = FakeGatewayStub(snapshot_stream=stream)
async def test_stream_alarms_passes_filter_prefix() -> None:
stream = FakeAlarmFeedStream([])
stub = FakeGatewayStub(alarm_feed_stream=stream)
client = await GatewayClient.connect(
ClientOptions(endpoint="fake", api_key="mxgw_test_secret", plaintext=True),
stub=stub,
)
iterator = client.query_active_alarms(
pb.QueryActiveAlarmsRequest(session_id="session-1", alarm_filter_prefix="Tank01."),
iterator = client.stream_alarms(
pb.StreamAlarmsRequest(alarm_filter_prefix="Tank01."),
)
# Drain to trigger the stub call.
async for _ in iterator:
pass
assert stub.query_request is not None
assert stub.query_request.alarm_filter_prefix == "Tank01."
assert stub.stream_request is not None
assert stub.stream_request.alarm_filter_prefix == "Tank01."
@pytest.mark.asyncio
async def test_query_active_alarms_cancels_underlying_stream_on_close() -> None:
snapshots = [
pb.ActiveAlarmSnapshot(
alarm_full_reference="Tank01.Level.HiHi",
current_state=pb.ALARM_CONDITION_STATE_ACTIVE,
async def test_stream_alarms_cancels_underlying_stream_on_close() -> None:
messages = [
pb.AlarmFeedMessage(
active_alarm=pb.ActiveAlarmSnapshot(
alarm_full_reference="Tank01.Level.HiHi",
current_state=pb.ALARM_CONDITION_STATE_ACTIVE,
),
),
]
stream = FakeSnapshotStream(snapshots)
stub = FakeGatewayStub(snapshot_stream=stream)
stream = FakeAlarmFeedStream(messages)
stub = FakeGatewayStub(alarm_feed_stream=stream)
client = await GatewayClient.connect(
ClientOptions(endpoint="fake", api_key="mxgw_test_secret", plaintext=True),
stub=stub,
)
iterator = client.query_active_alarms(pb.QueryActiveAlarmsRequest(session_id="session-1"))
iterator = client.stream_alarms(pb.StreamAlarmsRequest())
first = await anext(iterator)
await iterator.aclose()
assert first.alarm_full_reference == "Tank01.Level.HiHi"
assert first.active_alarm.alarm_full_reference == "Tank01.Level.HiHi"
assert stream.cancelled
class FakeGatewayStub:
def __init__(self, snapshot_stream: "FakeSnapshotStream | None" = None) -> None:
def __init__(self, alarm_feed_stream: "FakeAlarmFeedStream | None" = None) -> None:
self.open_session = FakeUnary(
[
pb.OpenSessionReply(
@@ -179,19 +180,19 @@ class FakeGatewayStub:
self.acknowledge_alarm = FakeUnary([])
self.OpenSession = self.open_session
self.AcknowledgeAlarm = self.acknowledge_alarm
self._snapshot_stream = snapshot_stream or FakeSnapshotStream([])
self.query_request: pb.QueryActiveAlarmsRequest | None = None
self.query_metadata: tuple[tuple[str, str], ...] | None = None
self._alarm_feed_stream = alarm_feed_stream or FakeAlarmFeedStream([])
self.stream_request: pb.StreamAlarmsRequest | None = None
self.stream_metadata: tuple[tuple[str, str], ...] | None = None
def QueryActiveAlarms(
def StreamAlarms(
self,
request: pb.QueryActiveAlarmsRequest,
request: pb.StreamAlarmsRequest,
*,
metadata: tuple[tuple[str, str], ...],
) -> "FakeSnapshotStream":
self.query_request = request
self.query_metadata = metadata
return self._snapshot_stream
) -> "FakeAlarmFeedStream":
self.stream_request = request
self.stream_metadata = metadata
return self._alarm_feed_stream
class FakeUnary:
@@ -214,18 +215,18 @@ class FakeUnary:
return self.replies.pop(0)
class FakeSnapshotStream:
def __init__(self, snapshots: list[pb.ActiveAlarmSnapshot]) -> None:
self._snapshots = list(snapshots)
class FakeAlarmFeedStream:
def __init__(self, messages: list[pb.AlarmFeedMessage]) -> None:
self._messages = list(messages)
self.cancelled = False
def __aiter__(self) -> "FakeSnapshotStream":
def __aiter__(self) -> "FakeAlarmFeedStream":
return self
async def __anext__(self) -> pb.ActiveAlarmSnapshot:
if not self._snapshots:
async def __anext__(self) -> pb.AlarmFeedMessage:
if not self._messages:
raise StopAsyncIteration
return self._snapshots.pop(0)
return self._messages.pop(0)
def cancel(self) -> None:
self.cancelled = True
clients/python/tests/test_stream_timeout_fallback.py
+16 -10
View File
@@ -1,6 +1,6 @@
"""Regression tests for Client.Python-003: stream timeout-kwarg fallback.
`stream_events_raw` and `query_active_alarms` must tolerate a fake/older stub
`stream_events_raw` and `stream_alarms` must tolerate a fake/older stub
that does not accept a ``timeout`` keyword argument, matching the fallback
already present in `galaxy.watch_deploy_events` and the unary `_unary` helper.
"""
@@ -51,9 +51,9 @@ class _NoTimeoutStubStreamEvents:
self.StreamEvents = stream
class _NoTimeoutStubQueryAlarms:
class _NoTimeoutStubStreamAlarms:
def __init__(self, stream: _NoTimeoutStream) -> None:
self.QueryActiveAlarms = stream
self.StreamAlarms = stream
@pytest.mark.asyncio
@@ -78,24 +78,30 @@ async def test_stream_events_raw_falls_back_when_stub_rejects_timeout() -> None:
@pytest.mark.asyncio
async def test_query_active_alarms_falls_back_when_stub_rejects_timeout() -> None:
async def test_stream_alarms_falls_back_when_stub_rejects_timeout() -> None:
stream = _NoTimeoutStream(
[pb.ActiveAlarmSnapshot(alarm_full_reference="Tank01.Level.HiHi")],
[
pb.AlarmFeedMessage(
active_alarm=pb.ActiveAlarmSnapshot(
alarm_full_reference="Tank01.Level.HiHi",
),
),
],
)
client = await GatewayClient.connect(
ClientOptions(endpoint="fake", plaintext=True, stream_timeout=5.0),
stub=_NoTimeoutStubQueryAlarms(stream),
stub=_NoTimeoutStubStreamAlarms(stream),
)
received = [
snapshot
async for snapshot in client.query_active_alarms(
pb.QueryActiveAlarmsRequest(session_id="session-1"),
message
async for message in client.stream_alarms(
pb.StreamAlarmsRequest(),
)
]
assert len(received) == 1
assert received[0].alarm_full_reference == "Tank01.Level.HiHi"
assert received[0].active_alarm.alarm_full_reference == "Tank01.Level.HiHi"
@pytest.mark.asyncio