fix(gateway): GatewaySession implements IAsyncDisposable; drop dead KillWorker(string) (mxaccessgw#191)
R21-O12: GatewaySession already owned an async DisposeAsync teardown but did not declare IAsyncDisposable, so anything holding it as IAsyncDisposable (or a DI container) could not find the teardown. Declaring it changes no call site; the existing await-using sites bound to the same method by pattern. R21-O13: KillWorker(string) had no callers and was an ungated kill that bypassed _closeLock. Deleted it; docs/Sessions.md and the test comments now name KillWorkerWithCloseGateAsync, the real kill path. Regression test: GatewaySessionTests.GatewaySession_ImplementsIAsyncDisposable (fails before the interface is declared). Claude-Session: https://claude.ai/code/session_01GT67AEHd2Acv1YPwGfXEoV
This commit is contained in:
+1
-1
@@ -62,7 +62,7 @@ Tags gate **visibility only**: which sessions' event metadata a dashboard user m
|
||||
`CloseSessionAsync` and `KillWorkerAsync` are both end-of-life paths but differ in what they offer the worker:
|
||||
|
||||
- `CloseSessionAsync` is the graceful path: it calls `GatewaySession.CloseAsync`, which asks the worker to shut down via `IWorkerClient.ShutdownAsync` and only kills the process as a fallback if shutdown fails.
|
||||
- `KillWorkerAsync` is the forceful path used by the dashboard's admin Kill button: it calls `GatewaySession.KillWorker` directly, which kills the worker process immediately with no graceful-shutdown attempt and transitions the session to `Closed`.
|
||||
- `KillWorkerAsync` is the forceful path used by the dashboard's admin Kill button: it calls `GatewaySession.KillWorkerWithCloseGateAsync`, which takes the per-session close gate (so it serializes with a concurrent `CloseAsync`), kills the worker process immediately with no graceful-shutdown attempt, and transitions the session to `Closed`. There is no ungated kill primitive on `GatewaySession`.
|
||||
|
||||
Both paths converge on the same registry/metrics cleanup, so the open-session slot is released and `mxgateway.sessions.closed` is incremented either way.
|
||||
|
||||
|
||||
Reference in New Issue
Block a user