c73a33edd8
Path A landed for R3/R4. The byte->MxStatus synthesizer in Lmx.dll is
FUN_10100ce0 (`analysis/ghidra/exports/Lmx.dll.synthesizer-helpers2-decompile.md`),
a 4-byte u32 LE -> 4-tuple MxStatus decoder used by every NMX-frame
parser in Lmx.dll. The kernel is byte-deterministic and context-free,
so it ports as a pure function -- the operation-tracking state
machine the original verdict deferred is NOT required for synthesis.
Bit layout (per FUN_10100ce0 lines 21-24):
bit 31: success (-1 if set, 0 if clear)
bits 27..24: category (4 bits)
bits 23..20: detected_by (4 bits)
bits 15..0: detail (i16 -- low 16 bits, signed)
bits 30..28, 19..16: reserved/padding
Codec changes:
- MxStatus::from_packed_u32() / ::to_packed_u32() -- the kernel +
inverse for round-trip parity.
- MxStatus::from_nmx_response_code() -- the constructed-from-response-
code switch in FUN_1010bd10:741-770 (six proven mappings: 0x01, 0x02
-> CommunicationError + RequestingNmx; 0x03 -> ConfigurationError +
RequestingNmx; 0x04 -> ConfigurationError + RespondingNmx; 0x05 ->
CommunicationError + RespondingNmx; 0x1A -> CommunicationError +
RequestingNmx).
- MxStatusCategory / MxStatusSource: from_i16/to_i16 promoted to const
fn so MxStatus::from_packed_u32 can be const.
- NmxOperationStatusMessage::try_parse_process_data_received_body() --
thin wrapper that peels the outer NmxObservedEnvelope before
delegating to try_parse_inner. Mirrors
NmxOperationStatusMessage.TryParseProcessDataReceivedBody (.NET cs:20-32).
- NmxOperationStatusMessage::promote_to_typed() -- entry point that
returns the existing Status field. Documented as a no-op pass-through
for now (the 5-byte inner-body wire shape is NOT the same field as
the 4-byte packed-u32 the kernel decodes); kept for API symmetry.
- 22 new round-trip tests covering the kernel, the response-code
switch, the proven 0x00/0x41/0xEF completion bytes, and round-trip
for every canonical sentinel.
mxaccess (Session) changes:
- New OperationKind enum (Write/WriteSecured/Read/Subscribe/
Unsubscribe/Activate/Suspend/Other).
- New OperationContext struct (correlation_id, op_kind, reference,
retry_count) -- ground for the F54 follow-on per-operation
correlation work.
- New OperationStatus event type {raw, status, context,
is_during_recovery}, mirroring MxNativeOperationStatusEvent (cs:73-78)
with the typed-MxStatus addition.
- Session::operation_status_events() -> broadcast::Receiver<Arc<
OperationStatus>> + operation_status_stream() Stream variant.
- callback_router() now tries operation-status parsing first, falling
through to subscription messages -- matches MxNativeSession
.OnCallbackReceived dispatch order (cs:574,582,590).
- recover_connection() flips a recovery_active counter (Arc<AtomicU32>
shared with the router) so OperationStatus.is_during_recovery is
populated correctly. Mirrors MxNativeSession._recoveryActive
Volatile.Read at cs:573.
- 3 new router tests covering: status-word frame dispatch + typed
promotion to WriteCompleteOk; completion-only frames stay verbatim;
is_during_recovery is stamped from the live counter.
Per-operation context tracking (correlating completion frames back to
outstanding writes/subscribes via the correlation_id) is filed as F54
in design/followups.md. The synthesizer kernel itself is byte-
deterministic, so the kernel and the correlation work are decoupled.
Ghidra evidence (the next-ring xref walk beyond FUN_10114a90):
- analysis/ghidra/exports/Lmx.dll.set-attribute-result-xrefs.md --
xrefs to OnSetAttributeResult / CancelWithStatus / OperationComplete.
- analysis/ghidra/exports/Lmx.dll.vtable-data-xrefs.md -- vtable-slot
data xrefs for the virtual-dispatch path.
- analysis/ghidra/exports/Lmx.dll.synthesizer-decompile.md --
ScanOnDemandCallback::OperationComplete/MultipleOperationComplete
(FUN_1010b990), RemotePlatformResolver::OperationComplete
(FUN_1010dc80), and the constructed-from-responseCode synthesizer
in FUN_1010bd10 (lines 698-770). FUN_1010bd10 is the wire-frame
receiver that drives the synthesis.
- analysis/ghidra/exports/Lmx.dll.synthesizer-helpers-decompile.md --
FUN_10003fc0 (the <success %d category %d ...> formatter; confirms
the 4-tuple layout), FUN_1008f150 (dispatch helper).
- analysis/ghidra/exports/Lmx.dll.synthesizer-helpers2-decompile.md --
FUN_10100ce0 (the kernel itself), FUN_10100bc0 (3xu16 reader),
FUN_1005e580 (4-byte stream reader), FUN_1010ee00 (sister NMX-frame
parser using the same kernel).
- analysis/ghidra/exports/Lmx.dll.synthesizer-callers-xrefs.md --
caller graph; confirms the kernel is called from many wire-frame
parsers but each parser shares the single 4-byte decoder.
R3/R4 verdict updated in design/70-risks-and-open-questions.md from
"settled at verbatim-preserve" to "settled per Path A". F54 filed in
design/followups.md for the per-operation correlation work.
cargo build / test / clippy -D warnings / RUSTDOCFLAGS=-D warnings doc
all clean. cargo public-api baselines regenerated for mxaccess and
mxaccess-codec.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
288 lines
9.1 KiB
Rust
288 lines
9.1 KiB
Rust
//! F38 — counting-allocator bench for `mxaccess-codec`.
|
|
//!
|
|
//! Measures allocation count + bytes-allocated for the proven
|
|
//! encode/decode matrix per `design/70-risks-and-open-questions.md`
|
|
//! R12 (< 5 allocs per write at steady state). The harness wraps the
|
|
//! global allocator with a [`CountingAllocator`] that tracks
|
|
//! per-call counts; each scenario records pre-state, runs N
|
|
//! iterations, and reports `(alloc_count, bytes_allocated) / N`.
|
|
//!
|
|
//! Output is the source of truth for `design/M6-bench-baseline.md`.
|
|
//!
|
|
//! ## Why hand-rolled (not `dhat` / `criterion`)
|
|
//!
|
|
//! - `dhat` is heap-profiling oriented (snapshots, call-stack
|
|
//! attribution); for "did this op allocate < 5 times?" the simpler
|
|
//! approach is a thin `GlobalAlloc` wrapper that increments two
|
|
//! atomics. No call-stack capture, no JSON output to post-process.
|
|
//! - `criterion` measures wall-clock latency; per `60-roadmap.md:104`,
|
|
//! latency is reported but not gating in V1. Allocation count IS
|
|
//! the gating metric for M6 DoD bullet 3.
|
|
//!
|
|
//! ## Run
|
|
//!
|
|
//! ```text
|
|
//! cargo bench -p mxaccess-codec
|
|
//! ```
|
|
//!
|
|
//! Each scenario runs in release mode by default (cargo bench
|
|
//! profile = `bench` which inherits release).
|
|
|
|
#![allow(
|
|
clippy::unwrap_used,
|
|
clippy::expect_used,
|
|
clippy::cast_possible_truncation,
|
|
clippy::cast_sign_loss
|
|
)]
|
|
|
|
use std::alloc::{GlobalAlloc, Layout, System};
|
|
use std::sync::atomic::{AtomicU64, Ordering};
|
|
|
|
use mxaccess_codec::{
|
|
MxReferenceHandle, NmxSubscriptionMessage, write_message, write_message::WriteValue,
|
|
};
|
|
|
|
// ---- counting allocator -------------------------------------------------
|
|
|
|
struct CountingAllocator;
|
|
|
|
static ALLOC_COUNT: AtomicU64 = AtomicU64::new(0);
|
|
static ALLOC_BYTES: AtomicU64 = AtomicU64::new(0);
|
|
static DEALLOC_COUNT: AtomicU64 = AtomicU64::new(0);
|
|
|
|
unsafe impl GlobalAlloc for CountingAllocator {
|
|
unsafe fn alloc(&self, layout: Layout) -> *mut u8 {
|
|
ALLOC_COUNT.fetch_add(1, Ordering::Relaxed);
|
|
ALLOC_BYTES.fetch_add(layout.size() as u64, Ordering::Relaxed);
|
|
// SAFETY: forwarding to the system allocator with the same layout.
|
|
unsafe { System.alloc(layout) }
|
|
}
|
|
|
|
unsafe fn dealloc(&self, ptr: *mut u8, layout: Layout) {
|
|
DEALLOC_COUNT.fetch_add(1, Ordering::Relaxed);
|
|
// SAFETY: forwarding to the system allocator with the same ptr+layout.
|
|
unsafe { System.dealloc(ptr, layout) }
|
|
}
|
|
}
|
|
|
|
#[global_allocator]
|
|
static GLOBAL: CountingAllocator = CountingAllocator;
|
|
|
|
// ---- scenario harness ---------------------------------------------------
|
|
|
|
#[derive(Debug, Clone, Copy)]
|
|
struct Snapshot {
|
|
allocs: u64,
|
|
bytes: u64,
|
|
deallocs: u64,
|
|
}
|
|
|
|
fn snapshot() -> Snapshot {
|
|
Snapshot {
|
|
allocs: ALLOC_COUNT.load(Ordering::Relaxed),
|
|
bytes: ALLOC_BYTES.load(Ordering::Relaxed),
|
|
deallocs: DEALLOC_COUNT.load(Ordering::Relaxed),
|
|
}
|
|
}
|
|
|
|
fn diff(start: Snapshot, end: Snapshot, iterations: u64) -> (f64, f64, f64) {
|
|
(
|
|
(end.allocs - start.allocs) as f64 / iterations as f64,
|
|
(end.bytes - start.bytes) as f64 / iterations as f64,
|
|
(end.deallocs - start.deallocs) as f64 / iterations as f64,
|
|
)
|
|
}
|
|
|
|
/// Run `op` `iterations` times and return per-op alloc/bytes/dealloc
|
|
/// counts. The hint is passed through `std::hint::black_box` to keep
|
|
/// the compiler from optimising the work away.
|
|
fn measure<F>(name: &str, iterations: u64, mut op: F) -> Row
|
|
where
|
|
F: FnMut(),
|
|
{
|
|
// Warm-up: 1k iterations to settle any one-time setup state.
|
|
for _ in 0..1024 {
|
|
op();
|
|
}
|
|
let start = snapshot();
|
|
for _ in 0..iterations {
|
|
op();
|
|
}
|
|
let end = snapshot();
|
|
let (allocs, bytes, deallocs) = diff(start, end, iterations);
|
|
Row {
|
|
name: name.to_string(),
|
|
iterations,
|
|
allocs_per_op: allocs,
|
|
bytes_per_op: bytes,
|
|
deallocs_per_op: deallocs,
|
|
}
|
|
}
|
|
|
|
struct Row {
|
|
name: String,
|
|
iterations: u64,
|
|
allocs_per_op: f64,
|
|
bytes_per_op: f64,
|
|
deallocs_per_op: f64,
|
|
}
|
|
|
|
fn print_table(rows: &[Row]) {
|
|
println!();
|
|
println!(
|
|
"| {:40} | {:>10} | {:>10} | {:>10} | {:>10} |",
|
|
"scenario", "iters", "allocs/op", "bytes/op", "deallocs/op"
|
|
);
|
|
println!(
|
|
"| {:40} | {:>10} | {:>10} | {:>10} | {:>10} |",
|
|
"-".repeat(40),
|
|
"-".repeat(10),
|
|
"-".repeat(10),
|
|
"-".repeat(10),
|
|
"-".repeat(10)
|
|
);
|
|
for row in rows {
|
|
println!(
|
|
"| {:40} | {:>10} | {:>10.2} | {:>10.0} | {:>10.2} |",
|
|
row.name, row.iterations, row.allocs_per_op, row.bytes_per_op, row.deallocs_per_op
|
|
);
|
|
}
|
|
println!();
|
|
}
|
|
|
|
// ---- scenarios ----------------------------------------------------------
|
|
|
|
fn make_handle() -> MxReferenceHandle {
|
|
MxReferenceHandle::from_names(0, 1, 2, 3, "TestObject", 0, 1, 0, "TestAttr", false)
|
|
.expect("handle")
|
|
}
|
|
|
|
fn bench_write_int32() -> Row {
|
|
let handle = make_handle();
|
|
let value = WriteValue::Int32(42);
|
|
measure("write_message::encode (Int32)", 10_000, || {
|
|
let bytes = write_message::encode(&handle, &value, 0, 0).unwrap();
|
|
std::hint::black_box(bytes);
|
|
})
|
|
}
|
|
|
|
fn bench_write_float() -> Row {
|
|
let handle = make_handle();
|
|
let value = WriteValue::Float32(1.5);
|
|
measure("write_message::encode (Float32)", 10_000, || {
|
|
let bytes = write_message::encode(&handle, &value, 0, 0).unwrap();
|
|
std::hint::black_box(bytes);
|
|
})
|
|
}
|
|
|
|
fn bench_write_double() -> Row {
|
|
let handle = make_handle();
|
|
let value = WriteValue::Float64(3.25);
|
|
measure("write_message::encode (Float64)", 10_000, || {
|
|
let bytes = write_message::encode(&handle, &value, 0, 0).unwrap();
|
|
std::hint::black_box(bytes);
|
|
})
|
|
}
|
|
|
|
fn bench_write_bool() -> Row {
|
|
let handle = make_handle();
|
|
let value = WriteValue::Boolean(true);
|
|
measure("write_message::encode (Boolean)", 10_000, || {
|
|
let bytes = write_message::encode(&handle, &value, 0, 0).unwrap();
|
|
std::hint::black_box(bytes);
|
|
})
|
|
}
|
|
|
|
fn bench_write_string() -> Row {
|
|
let handle = make_handle();
|
|
let value = WriteValue::String("hello".to_string());
|
|
measure("write_message::encode (String, 5 chars)", 10_000, || {
|
|
let bytes = write_message::encode(&handle, &value, 0, 0).unwrap();
|
|
std::hint::black_box(bytes);
|
|
})
|
|
}
|
|
|
|
fn bench_subscription_decode() -> Row {
|
|
// Build a single-record DataUpdate body once; decode N times.
|
|
let body = build_data_update_int32_body(42);
|
|
measure(
|
|
"NmxSubscriptionMessage::parse_inner (DataUpdate, Int32)",
|
|
10_000,
|
|
|| {
|
|
let msg = NmxSubscriptionMessage::parse_inner(&body).unwrap();
|
|
std::hint::black_box(msg);
|
|
},
|
|
)
|
|
}
|
|
|
|
fn bench_handle_from_names() -> Row {
|
|
measure("MxReferenceHandle::from_names", 10_000, || {
|
|
let h =
|
|
MxReferenceHandle::from_names(0, 1, 2, 3, "TestChildObject", 0, 1, 0, "TestInt", false)
|
|
.unwrap();
|
|
std::hint::black_box(h);
|
|
})
|
|
}
|
|
|
|
// ---- helpers (mirror the test fixtures in subscription_message.rs) -----
|
|
|
|
fn build_data_update_int32_body(value: i32) -> Vec<u8> {
|
|
// Operation id + correlation id are arbitrary 16-byte sequences for
|
|
// a synthetic body; the codec doesn't reject any GUID shape.
|
|
const DATA_UPDATE_COMMAND: u8 = 0x33;
|
|
let operation_id = [0x11u8; 16];
|
|
// 15-byte record prefix: status(4) + quality(2) + filetime(8) + wire_kind(1).
|
|
// wire_kind = 0x02 = Int32. Then the 4-byte i32 LE payload.
|
|
let mut record = Vec::with_capacity(15 + 4);
|
|
record.extend_from_slice(&0i32.to_le_bytes()); // status
|
|
record.extend_from_slice(&0x00C0u16.to_le_bytes()); // quality
|
|
record.extend_from_slice(&0i64.to_le_bytes()); // filetime
|
|
record.push(0x02); // wire_kind = Int32
|
|
record.extend_from_slice(&value.to_le_bytes());
|
|
|
|
let mut out = Vec::with_capacity(23 + record.len());
|
|
out.push(DATA_UPDATE_COMMAND);
|
|
out.extend_from_slice(&1u16.to_le_bytes()); // version
|
|
out.extend_from_slice(&1i32.to_le_bytes()); // record_count = 1
|
|
out.extend_from_slice(&operation_id);
|
|
out.extend_from_slice(&record);
|
|
out
|
|
}
|
|
|
|
// ---- main --------------------------------------------------------------
|
|
|
|
fn main() {
|
|
println!("F38 — mxaccess-codec allocation-count baseline");
|
|
println!("Counting allocator: thin GlobalAlloc wrapper around System.");
|
|
println!("R12 target: < 5 allocations per write at steady state.");
|
|
|
|
let rows = vec![
|
|
bench_write_int32(),
|
|
bench_write_float(),
|
|
bench_write_double(),
|
|
bench_write_bool(),
|
|
bench_write_string(),
|
|
bench_handle_from_names(),
|
|
bench_subscription_decode(),
|
|
];
|
|
|
|
print_table(&rows);
|
|
|
|
// R12 gate: emit a non-zero exit code if any encode-write scenario
|
|
// exceeds the 5-allocs threshold. Decoders are reported but not
|
|
// gated (the sweep below explicitly excludes them).
|
|
let mut violations = 0;
|
|
for row in &rows {
|
|
if row.name.starts_with("write_message::encode") && row.allocs_per_op >= 5.0 {
|
|
eprintln!(
|
|
"R12 violation: {} allocates {:.2}/op (>= 5)",
|
|
row.name, row.allocs_per_op
|
|
);
|
|
violations += 1;
|
|
}
|
|
}
|
|
if violations > 0 {
|
|
std::process::exit(1);
|
|
}
|
|
}
|