Mirrors the v1 otopcua-cli value prop (ad-hoc shell-level PLC validation) for
the Modbus-TCP driver, and lays down the shared scaffolding that AB CIP, AB
Legacy, S7, and TwinCAT CLIs will build on.
New projects:
- src/ZB.MOM.WW.OtOpcUa.Driver.Cli.Common/ — DriverCommandBase (verbose
flag + Serilog config) + SnapshotFormatter (single-tag + table +
write-result renders with invariant-culture value formatting + OPC UA
status-code shortnames + UTC-normalised timestamps).
- src/ZB.MOM.WW.OtOpcUa.Driver.Modbus.Cli/ — otopcua-modbus-cli executable.
Commands: probe, read, write, subscribe. ModbusCommandBase carries the
host/port/unit-id flags + builds ModbusDriverOptions with Probe.Enabled
=false (CLI runs are one-shot; driver-internal keep-alive would race).
Commands + coverage:
- probe single FC03 + GetHealth() + pretty-print
- read region × address × type synth into one driver tag
- write same shape + --value parsed per --type
- subscribe polled-subscription stream until Ctrl+C
Tests (38 total):
- 16 SnapshotFormatterTests covering: status-code shortnames, unknown
codes fall back to hex, null value + timestamp placeholders, bool
lowercase, float invariant culture, string quoting, write-result shape,
aligned table columns, mismatched-length rejection, UTC normalisation.
- 22 Modbus CLI tests:
· ReadCommandTests.SynthesiseTagName (5 theory cases)
· WriteCommandParseValueTests (17 cases: bool aliases, unknown rejected,
Int16 bounds, UInt16/Bcd16 type, Float32/64 invariant culture,
String passthrough, BitInRegister, Int32 MinValue, non-numeric reject)
Wiring:
- ZB.MOM.WW.OtOpcUa.slnx grew 4 entries (2 src + 2 tests).
- docs/Driver.Modbus.Cli.md — operator-facing runbook with examples per
command + output format + typical workflows.
Regression: full-solution build clean; shared-lib tests 16/0, Modbus CLI tests
22/0.
Next up: repeat the pattern for AB CIP (shares ~40% more with Modbus via
libplctag), then AB Legacy, S7, TwinCAT. The shared base stays as-is unless
one of those exposes a gap the Modbus-first pass missed.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
96 lines
3.8 KiB
C#
96 lines
3.8 KiB
C#
using CliFx.Attributes;
|
|
using CliFx.Infrastructure;
|
|
using ZB.MOM.WW.OtOpcUa.Driver.Cli.Common;
|
|
|
|
namespace ZB.MOM.WW.OtOpcUa.Driver.Modbus.Cli.Commands;
|
|
|
|
/// <summary>
|
|
/// Read one Modbus register / coil. Operator specifies the address via
|
|
/// <c>--region</c> + <c>--address</c> + <c>--type</c>; the CLI synthesises a single
|
|
/// <see cref="ModbusTagDefinition"/>, spins up the driver, reads once, prints the snapshot,
|
|
/// and shuts down. Multi-register types (Int32 / Float32 / String / BCD32) respect
|
|
/// <c>--byte-order</c> the same way real driver configs do.
|
|
/// </summary>
|
|
[Command("read", Description = "Read a single Modbus register or coil.")]
|
|
public sealed class ReadCommand : ModbusCommandBase
|
|
{
|
|
[CommandOption("region", 'r', Description =
|
|
"Coils / DiscreteInputs / InputRegisters / HoldingRegisters", IsRequired = true)]
|
|
public ModbusRegion Region { get; init; }
|
|
|
|
[CommandOption("address", 'a', Description =
|
|
"Zero-based address within the region.", IsRequired = true)]
|
|
public ushort Address { get; init; }
|
|
|
|
[CommandOption("type", 't', Description =
|
|
"Bool / Int16 / UInt16 / Int32 / UInt32 / Int64 / UInt64 / Float32 / Float64 / " +
|
|
"BitInRegister / String / Bcd16 / Bcd32", IsRequired = true)]
|
|
public ModbusDataType DataType { get; init; }
|
|
|
|
[CommandOption("byte-order", Description =
|
|
"BigEndian (default, spec ABCD) or WordSwap (CDAB). Ignored for single-register types.")]
|
|
public ModbusByteOrder ByteOrder { get; init; } = ModbusByteOrder.BigEndian;
|
|
|
|
[CommandOption("bit-index", Description =
|
|
"For type=BitInRegister: bit 0-15 LSB-first.")]
|
|
public byte BitIndex { get; init; }
|
|
|
|
[CommandOption("string-length", Description =
|
|
"For type=String: character count (2 per register, rounded up).")]
|
|
public ushort StringLength { get; init; }
|
|
|
|
[CommandOption("string-byte-order", Description =
|
|
"For type=String: HighByteFirst (standard) or LowByteFirst (DirectLOGIC et al).")]
|
|
public ModbusStringByteOrder StringByteOrder { get; init; } = ModbusStringByteOrder.HighByteFirst;
|
|
|
|
public override async ValueTask ExecuteAsync(IConsole console)
|
|
{
|
|
ConfigureLogging();
|
|
var ct = console.RegisterCancellationHandler();
|
|
|
|
var tagName = SynthesiseTagName(Region, Address, DataType);
|
|
var tag = new ModbusTagDefinition(
|
|
Name: tagName,
|
|
Region: Region,
|
|
Address: Address,
|
|
DataType: DataType,
|
|
Writable: false,
|
|
ByteOrder: ByteOrder,
|
|
BitIndex: BitIndex,
|
|
StringLength: StringLength,
|
|
StringByteOrder: StringByteOrder);
|
|
var options = BuildOptions([tag]);
|
|
|
|
await using var driver = new ModbusDriver(options, DriverInstanceId);
|
|
try
|
|
{
|
|
await driver.InitializeAsync("{}", ct);
|
|
var snapshot = await driver.ReadAsync([tagName], ct);
|
|
await console.Output.WriteLineAsync(SnapshotFormatter.Format(tagName, snapshot[0]));
|
|
}
|
|
finally
|
|
{
|
|
await driver.ShutdownAsync(CancellationToken.None);
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Builds a human-readable tag name matching the operator's conceptual model
|
|
/// (<c>HR[100]</c>, <c>Coil[5]</c>, <c>IR[42]</c>) — the driver treats the name
|
|
/// purely as a lookup key, so any stable string works.
|
|
/// </summary>
|
|
internal static string SynthesiseTagName(
|
|
ModbusRegion region, ushort address, ModbusDataType type)
|
|
{
|
|
var prefix = region switch
|
|
{
|
|
ModbusRegion.Coils => "Coil",
|
|
ModbusRegion.DiscreteInputs => "DI",
|
|
ModbusRegion.InputRegisters => "IR",
|
|
ModbusRegion.HoldingRegisters => "HR",
|
|
_ => "Reg",
|
|
};
|
|
return $"{prefix}[{address}]:{type}";
|
|
}
|
|
}
|