6923be3aa2
- Driver.FOCAS.Cli-001: WriteCommand.ParseValue now wraps numeric FormatException / OverflowException as CliFx CommandException with the offending value. - Driver.FOCAS.Cli-002: SubscribeCommand's OnDataChange handler and the banner both take a writeLock so notification-callback and main-thread writes can't interleave; handler exceptions are warn-and-swallow. - Driver.FOCAS.Cli-003: FocasCommandBase.ValidateOptions rejects --cnc-port outside 1..65535, non-positive --timeout-ms, and non-positive --interval-ms; ExecuteAsync calls it first. - Driver.FOCAS.Cli-004: 'await using var driver' is the sole driver disposal path; dropped the redundant explicit await ShutdownAsync. - Driver.FOCAS.Cli-005 (Deferred): the fix lives in Driver.Cli.Common.SnapshotFormatter — explicitly naming the status-code shortlist there benefits every driver CLI. Left as a Driver.Cli.Common follow-up. - Registered the new tests/Drivers/Cli/ZB.MOM.WW.OtOpcUa.Driver.FOCAS.Cli.Tests project in ZB.MOM.WW.OtOpcUa.slnx. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
56 lines
2.3 KiB
C#
56 lines
2.3 KiB
C#
using Shouldly;
|
|
using Xunit;
|
|
|
|
namespace ZB.MOM.WW.OtOpcUa.Driver.FOCAS.Cli.Tests;
|
|
|
|
/// <summary>
|
|
/// Driver.FOCAS.Cli-002: the FOCAS <c>subscribe</c> command — a near-verbatim copy
|
|
/// of the Modbus subscribe command — must
|
|
/// (a) serialise writes from the <c>OnDataChange</c> handler (raised from the
|
|
/// driver's <c>PollGroupEngine</c> background thread) with a lock, so the
|
|
/// "Subscribed to ..." banner write from the CliFx main thread cannot interleave
|
|
/// with the first poll-driven change line; and
|
|
/// (b) carry the explanatory comment that documents why <c>OnDataChange</c> uses
|
|
/// <c>console.Output.WriteLine</c> (synchronous, on a driver background thread)
|
|
/// instead of <c>System.Console</c> or the async <c>WriteLineAsync</c>. The
|
|
/// rationale is non-obvious to a reader and the Modbus copy carries it; the FOCAS
|
|
/// copy must too.
|
|
/// </summary>
|
|
[Trait("Category", "Unit")]
|
|
public sealed class SubscribeCommandConsoleHandlerTests
|
|
{
|
|
private static string ReadSubscribeSource()
|
|
{
|
|
var dir = new DirectoryInfo(AppContext.BaseDirectory);
|
|
while (dir is not null && !File.Exists(Path.Combine(dir.FullName, "ZB.MOM.WW.OtOpcUa.slnx")))
|
|
dir = dir.Parent;
|
|
dir.ShouldNotBeNull();
|
|
return File.ReadAllText(Path.Combine(
|
|
dir!.FullName, "src", "Drivers", "Cli", "ZB.MOM.WW.OtOpcUa.Driver.FOCAS.Cli",
|
|
"Commands", "SubscribeCommand.cs"));
|
|
}
|
|
|
|
[Fact]
|
|
public void SubscribeCommand_explains_why_OnDataChange_uses_console_Output_synchronously()
|
|
{
|
|
var source = ReadSubscribeSource();
|
|
|
|
// The comment must reference the CliFx console abstraction so future copy-pastes
|
|
// do not lose the rationale.
|
|
source.ShouldContain("CliFx console");
|
|
source.ShouldContain("IConsole");
|
|
}
|
|
|
|
[Fact]
|
|
public void SubscribeCommand_serialises_console_writes_with_a_lock()
|
|
{
|
|
var source = ReadSubscribeSource();
|
|
|
|
// Both the banner write and the OnDataChange handler must share a writeLock so the
|
|
// banner from the CliFx invocation thread cannot interleave with the first
|
|
// poll-driven change line from the driver tick thread.
|
|
source.ShouldContain("writeLock");
|
|
source.ShouldContain("lock (writeLock)");
|
|
}
|
|
}
|