10b898305f
S-1: replace the hand-maintained 5-project unit-tests matrix (which silently dropped Client's 388 tests, Analyzers' 31, and every driver + most Core suite) with ONE whole-solution leg — dotnet test ZB.MOM.WW.OtOpcUa.slnx --filter "Category!=E2E&Category!=LiveIntegration". Self-maintaining: a new *.Tests project is covered automatically, matching CLAUDE.md's own guidance. S-2: emit trx + add scripts/ci/assert-not-all-skipped.sh, a fail-on-skip gate that turns 'green CI == everything skipped' into a red build. Wired strict (MIN_EXECUTED=1) on the unit leg; report-only (MIN_EXECUTED=0) on the fixtureless integration leg so its skip tally is VISIBLE without a false red — with a documented follow-up to start the one public-image fixture (opc-plc) as a service and flip it strict. S-4 (paired): the newly-CI'd Client.CLI.Tests had fixed-sleep startup races (await Task.Delay(100/150) before cancelling a background command) that would flake under CI load. Added SubscribeInvoked / SubscribeAlarmsInvoked readiness signals (TaskCompletionSource) to FakeOpcUaClientService and replaced the 11 sleeps across AlarmsCommandTests / SubscribeCommandTests / EventHandlerLifecycleTests with a deterministic await-the-signal (10s timeout guard). Verified: workflow YAML parses; skip-gate proven locally on a real trx (executed=31 => OK), a synthetic all-skipped trx (executed=0 => exit 1 with diagnostic), report-only mode (never fails), multi-file sum, and missing-file (exit 2); Client.CLI.Tests 104/104 green after the deflake. (CI job execution itself is verifiable only on push — nothing pushed.)
112 lines
4.1 KiB
C#
112 lines
4.1 KiB
C#
using Shouldly;
|
|
using Xunit;
|
|
using ZB.MOM.WW.OtOpcUa.Client.CLI.Commands;
|
|
using ZB.MOM.WW.OtOpcUa.Client.CLI.Tests.Fakes;
|
|
|
|
namespace ZB.MOM.WW.OtOpcUa.Client.CLI.Tests;
|
|
|
|
public class SubscribeCommandTests
|
|
{
|
|
/// <summary>Verifies that ExecuteAsync subscribes with the correct parameters.</summary>
|
|
[Fact]
|
|
public async Task Execute_SubscribesWithCorrectParameters()
|
|
{
|
|
var fakeService = new FakeOpcUaClientService();
|
|
var factory = new FakeOpcUaClientServiceFactory(fakeService);
|
|
var command = new SubscribeCommand(factory)
|
|
{
|
|
Url = "opc.tcp://localhost:4840",
|
|
NodeId = "ns=2;s=TestVar",
|
|
Interval = 500
|
|
};
|
|
|
|
using var console = TestConsoleHelper.CreateConsole();
|
|
|
|
// The subscribe command waits for cancellation. We need to cancel it.
|
|
// Use the console's cancellation to trigger stop.
|
|
var task = Task.Run(async () => { await command.ExecuteAsync(console); });
|
|
|
|
// Wait until the command has actually subscribed (deterministic — no fixed-sleep race), then cancel
|
|
await fakeService.SubscribeInvoked.WaitAsync(TimeSpan.FromSeconds(10));
|
|
console.RequestCancellation();
|
|
await task;
|
|
|
|
fakeService.SubscribeCalls.Count.ShouldBe(1);
|
|
fakeService.SubscribeCalls[0].IntervalMs.ShouldBe(500);
|
|
fakeService.SubscribeCalls[0].NodeId.Identifier.ShouldBe("TestVar");
|
|
}
|
|
|
|
/// <summary>Verifies that ExecuteAsync unsubscribes when cancellation is requested.</summary>
|
|
[Fact]
|
|
public async Task Execute_UnsubscribesOnCancellation()
|
|
{
|
|
var fakeService = new FakeOpcUaClientService();
|
|
var factory = new FakeOpcUaClientServiceFactory(fakeService);
|
|
var command = new SubscribeCommand(factory)
|
|
{
|
|
Url = "opc.tcp://localhost:4840",
|
|
NodeId = "ns=2;s=TestVar"
|
|
};
|
|
|
|
using var console = TestConsoleHelper.CreateConsole();
|
|
|
|
var task = Task.Run(async () => { await command.ExecuteAsync(console); });
|
|
|
|
await fakeService.SubscribeInvoked.WaitAsync(TimeSpan.FromSeconds(10));
|
|
console.RequestCancellation();
|
|
await task;
|
|
|
|
fakeService.UnsubscribeCalls.Count.ShouldBe(1);
|
|
}
|
|
|
|
/// <summary>Verifies that ExecuteAsync disconnects and disposes in a finally block.</summary>
|
|
[Fact]
|
|
public async Task Execute_DisconnectsInFinally()
|
|
{
|
|
var fakeService = new FakeOpcUaClientService();
|
|
var factory = new FakeOpcUaClientServiceFactory(fakeService);
|
|
var command = new SubscribeCommand(factory)
|
|
{
|
|
Url = "opc.tcp://localhost:4840",
|
|
NodeId = "ns=2;s=TestVar"
|
|
};
|
|
|
|
using var console = TestConsoleHelper.CreateConsole();
|
|
|
|
var task = Task.Run(async () => { await command.ExecuteAsync(console); });
|
|
|
|
await fakeService.SubscribeInvoked.WaitAsync(TimeSpan.FromSeconds(10));
|
|
console.RequestCancellation();
|
|
await task;
|
|
|
|
fakeService.DisconnectCalled.ShouldBeTrue();
|
|
fakeService.DisposeCalled.ShouldBeTrue();
|
|
}
|
|
|
|
/// <summary>Verifies that ExecuteAsync prints the correct subscription message.</summary>
|
|
[Fact]
|
|
public async Task Execute_PrintsSubscriptionMessage()
|
|
{
|
|
var fakeService = new FakeOpcUaClientService();
|
|
var factory = new FakeOpcUaClientServiceFactory(fakeService);
|
|
var command = new SubscribeCommand(factory)
|
|
{
|
|
Url = "opc.tcp://localhost:4840",
|
|
NodeId = "ns=2;s=TestVar",
|
|
Interval = 2000
|
|
};
|
|
|
|
using var console = TestConsoleHelper.CreateConsole();
|
|
|
|
var task = Task.Run(async () => { await command.ExecuteAsync(console); });
|
|
|
|
await fakeService.SubscribeInvoked.WaitAsync(TimeSpan.FromSeconds(10));
|
|
console.RequestCancellation();
|
|
await task;
|
|
|
|
var output = TestConsoleHelper.GetOutput(console);
|
|
// CLI now prints aggregate form "Subscribed to {count}/{total} nodes (interval: ...)" rather than
|
|
// the single-node form the original test asserted — the command supports multi-node now.
|
|
output.ShouldContain("Subscribed to 1/1 nodes (interval: 2000ms)");
|
|
}
|
|
} |