Joseph Doherty
4624141a5d
tag gate, and fix three silently-broken OpcUaClient integration tests
Continues working through deferment.md's remaining items.
SKIPPED TESTS (13 -> 0 for this reason). The skip said "dark until Batch 4";
Batch 4 shipped as v3.0 and RETIRED the equipment-tag path rather than lighting
it, so every one of them was waiting on something that had already happened and
gone the other way. Resolved individually rather than in bulk:
- REVIVED onto the raw/UNS shape (6): four DriverHostActor primary-gate cases,
the cluster-scoping rebuild, and the real-SDK dual-namespace materialisation
E2E. The behaviour never went dark, only the v2 seeding did.
- FOLDED into a live parity test (3): DeploymentArtifactRawUnsParityTests
already compared RawTagPlan record-equal and RawTagPlan carries array /
historize / alarm intent, so widening its corpus by two tags covers what
three empty placeholder suites had been promising. Those suites are deleted.
- DELETED (4): subjects genuinely retired -- equipment-namespace EquipmentTags,
and both dot-joint {{equip}}.X token suites (that resolver was deleted in
Batch 3; the slash-joint form is covered by DeploymentArtifactEquipRefParityTests).
Falsified, not assumed: removing the seeded UnsTagReference turns two revived
primary-gate tests red; re-homing the SITE-A node to MAIN turns the scoping test
red. Widening a parity corpus also needed direct value assertions -- parity alone
cannot distinguish "both seams right" from "both seams blind".
Runtime.Tests skips 13->3, OpcUaServer.Tests 4->1; all remaining are deliberate
EquipmentDeviceBindingRetired tombstones.
G-7 (deploy-time TagConfig gate). MQTT shipped an Inspect() nobody ever called;
now wired. Replaced the hand-maintained list with a reflection guard, because the
existing test enumerates driver types by hand and so guards renames but can never
notice a gap. NOTE: the first version of that guard was hollow -- it discovered
candidates via GetReferencedAssemblies(), which is circular, since the compiler
elides a reference nothing in the IL uses. Removing MQTT from the map also removed
its Contracts assembly from the manifest, and the guard passed green with the bug
reintroduced. Rewritten to scan the output directory; re-falsified and it now
fails naming MqttTagDefinitionFactory. Residual recorded at the code: Sql,
MTConnect, Calculation and OpcUaClient have no Contracts-side Inspect at all, so
the deploy gate stays weaker than the AdminUI's authoring gate for them.
OPCUACLIENT INTEGRATION TESTS (3 of 4 failing, on master too). Not fixture rot:
the simulator was healthy and Client.CLI read the very same node Good. v3 made the
driver resolve every reference through its authored RawTags table, so a bare
"ns=3;s=StepUp" fails LOCALLY at the resolver with BadNodeIdInvalid and never
reaches the wire -- the tests were exercising the unresolved-reference guard.
Fixed by seeding OpcPlcProfile.RawTags in the deploy artifact's TagConfig shape
and addressing by RawPath. 4/4 pass.
DOCS. Applied the Phase7* -> AddressSpace* rename across the four live docs
(historical bannered files deliberately untouched), resolving the three that are
not renames to their real members. Found en route that the earlier banner pass
missed three files: VirtualTags.md, OpcUaServer.md and ScriptedAlarms.md all
still presented the test-scaffolding GenericDriverNodeManager as the production
dispatch path. All three now carry the correction.
Claude-Session: https://claude.ai/code/session_015p7wGqy3YpZNCpDzTpGMKo
40 lines
2.8 KiB
C#
40 lines
2.8 KiB
C#
namespace ZB.MOM.WW.OtOpcUa.Runtime.Tests.Drivers;
|
|
|
|
/// <summary>
|
|
/// Shared xUnit <c>Skip</c> reason constants for tests whose subject was RETIRED by v3 rather than
|
|
/// merely deferred — architectural tombstones that keep the removed coverage discoverable and name
|
|
/// what replaced it, so nobody re-writes a test for a concept that no longer exists.
|
|
/// <para><b>A skip reason is a claim with an expiry date.</b> The one this file used to carry
|
|
/// (<c>EquipmentTagsDarkBatch4</c>, "dark until Batch 4") outlived its own condition by a release —
|
|
/// see the note below. If you add one here, state the condition precisely enough that a reader can
|
|
/// check whether it has already happened.</para>
|
|
/// </summary>
|
|
internal static class DarkAddressSpaceReasons
|
|
{
|
|
// EquipmentTagsDarkBatch4 was RETIRED (2026-07-28) once its own unblock condition was examined. It read
|
|
// "dark until Batch 4"; Batch 4 shipped as v3.0 and RETIRED the equipment-tag plan set rather than
|
|
// lighting it, so every test wearing this reason was waiting on something that had already happened and
|
|
// gone the other way. Each was resolved on its merits rather than left to read as pending work:
|
|
// - revived onto the raw/UNS shape that replaced the subject (the real-SDK dual-namespace
|
|
// materialisation E2E in AddressSpaceApplierHierarchyTests; the cluster-scoping rebuild and the
|
|
// four primary-gate write/alarm cases in Runtime.Tests),
|
|
// - folded into a live parity test whose corpus was widened to cover them (array + native-alarm
|
|
// intent, now in DeploymentArtifactRawUnsParityTests),
|
|
// - or deleted, where the subject itself is retired (equipment-namespace EquipmentTags, the
|
|
// dot-joint {{equip}}.X token — superseded by the slash-joint form in
|
|
// DeploymentArtifactEquipRefParityTests).
|
|
|
|
// DiscoveryInjectionDormantV3 was removed with the injection path itself (§8.2, Gitea #507). The 18
|
|
// tests it skipped were v2 characterization tests — they asserted an equipment-rooted graft
|
|
// (EquipmentRootNodeId == "EQ-1") that v3 cannot produce, so they were deleted rather than unskipped.
|
|
// Discovered raw tags are authored through the /raw browse-commit flow; IRediscoverable now surfaces a
|
|
// re-browse prompt instead (DriverInstanceActorRediscoverySignalTests).
|
|
|
|
/// <summary>Equipment↔device host binding is architecturally retired in v3.</summary>
|
|
public const string EquipmentDeviceBindingRetired =
|
|
"v3: equipment no longer binds a driver/device (EquipmentNode has no DriverInstanceId/DeviceId/" +
|
|
"DeviceHost) — equipment references raw tags via UnsTagReference. The device-endpoint merge this " +
|
|
"test characterized is now covered by DeploymentArtifactRawPathTests " +
|
|
"(ParseDriverInstances_computes_nested_RawPath_and_merges_device_endpoint).";
|
|
}
|