Joseph Doherty
30d0697c28
`IHostConnectivityProbe` was a dead surface: eleven drivers implement it, `GetHostStatuses()` had ZERO production call sites, and `OnHostStatusChanged` had no subscriber outside the Galaxy driver's own aggregator. Per-host connectivity was computed by every driver and read by nobody. The issue offered "build the publisher or delete it". The publisher as its entity doc described it — driver nodes upserting `DriverHostStatus` rows — is not buildable: per-cluster mesh Phase 4 gates `AddOtOpcUaConfigDb` on the `admin` role, so a driver-only node has no ConfigDb connection to write rows with. So the capability is kept and the transport changed. `DriverHealthChanged.HostStatuses` now carries the probe result to `/hosts` as a Hosts column. That channel already reached the page, already survives the mesh split via the Phase 5 gRPC telemetry stream, and already replays a last-value snapshot on re-subscribe — so per-host state re-primes after a reconnect without a durable store. Both halves of the interface finally do what they are for: the event triggers a prompt publish, the pull is the source of truth. The point of the column is the case the driver-level state chip structurally cannot express: a multi-device driver stays aggregate-Healthy while ONE of its devices is unreachable. Two traps, both pinned by tests that were falsified against the prod code: - The host digest MUST be in the publish fingerprint. On a single-host-down transition every other fingerprint component is unchanged, so the dedup would swallow exactly the publish carrying the news — the trap that already bit the rediscovery signal. Removing it turns the guard test red, verified. - null (no probe) must stay distinct from empty (probe with no hosts). proto3 cannot tell an absent repeated field from an empty one, hence the explicit `has_host_statuses` flag; collapsing them would render every probe-less driver as one whose devices are all fine. Dropped: the DriverHostStatus entity, enum, DbSet, model config and table (migration DropDriverHostStatusTable — empty on every deployment, so the scaffolder's data-loss warning is moot, and Down() recreates it exactly). Found en route, NOT fixed here: `DriverInstanceResilienceStatus` is the identical defect — no writer, no reader, only a DbSet declaration, while the live data rides the `driver-resilience-status` telemetry channel. Its doc-comment now states that rather than describing the sampler and AdminUI join that were never built. Filed as #524 rather than widening this schema change beyond what was asked. Claude-Session: https://claude.ai/code/session_015p7wGqy3YpZNCpDzTpGMKo
59 lines
2.3 KiB
C#
59 lines
2.3 KiB
C#
using Akka.Actor;
|
|
using Akka.Cluster.Tools.PublishSubscribe;
|
|
using ZB.MOM.WW.OtOpcUa.Commons.Messages.Drivers;
|
|
using ZB.MOM.WW.OtOpcUa.Core.Abstractions;
|
|
using ZB.MOM.WW.OtOpcUa.Runtime.Telemetry;
|
|
|
|
namespace ZB.MOM.WW.OtOpcUa.Runtime.Drivers;
|
|
|
|
/// <summary>
|
|
/// Forwards <see cref="DriverHealth"/> transitions to the cluster-wide
|
|
/// <c>driver-health</c> DistributedPubSub topic. Consumed by the AdminUI
|
|
/// <c>DriverStatusSignalRBridge</c>.
|
|
/// </summary>
|
|
public sealed class AkkaDriverHealthPublisher : IDriverHealthPublisher
|
|
{
|
|
/// <summary>The DistributedPubSub topic name for driver-health snapshots — single source
|
|
/// of truth on the message contract itself.</summary>
|
|
public const string TopicName = DriverHealthChanged.TopicName;
|
|
|
|
private readonly ActorSystem _system;
|
|
private readonly ITelemetryLocalHub _hub;
|
|
|
|
/// <summary>Initializes a new instance of <see cref="AkkaDriverHealthPublisher"/>.</summary>
|
|
/// <param name="system">The Akka actor system used to resolve the DPS mediator.</param>
|
|
/// <param name="hub">The node-local live-telemetry hub each snapshot is also emitted into (Phase 5).</param>
|
|
public AkkaDriverHealthPublisher(ActorSystem system, ITelemetryLocalHub hub)
|
|
{
|
|
_system = system;
|
|
_hub = hub;
|
|
}
|
|
|
|
/// <inheritdoc />
|
|
public void Publish(
|
|
string clusterId,
|
|
string driverInstanceId,
|
|
DriverHealth health,
|
|
int errorCount5Min,
|
|
DateTime? rediscoveryNeededUtc = null,
|
|
string? rediscoveryReason = null,
|
|
IReadOnlyList<HostConnectivityStatus>? hostStatuses = null)
|
|
{
|
|
var msg = new DriverHealthChanged(
|
|
clusterId,
|
|
driverInstanceId,
|
|
health.State.ToString(),
|
|
health.LastSuccessfulRead,
|
|
health.LastError,
|
|
errorCount5Min,
|
|
DateTime.UtcNow,
|
|
rediscoveryNeededUtc,
|
|
rediscoveryReason,
|
|
hostStatuses);
|
|
DistributedPubSub.Get(_system).Mediator.Tell(new Publish(TopicName, msg));
|
|
// Phase 5: fan the same snapshot into the node-local live-telemetry hub (no-op until a gRPC
|
|
// client subscribes). The DPS publish above is unchanged — the hub is a strictly additive tap.
|
|
_hub.Emit(new TelemetryItem.Health(msg));
|
|
}
|
|
}
|