Reverses the conservative call from the previous commit at the user's direction, and they were right: "surface it on a counter first" left the wire lying. An MXAccess event can carry Good quality while its payload is a kind MxValueDecoder has no mapping for, so the old behaviour published null-under-Good — which a client cannot tell apart from a genuine null reading. A value the gateway DID send would be consumed as a value it did not, with the only evidence in a log nobody is tailing. Bad data is the honest wire representation of lost data. BadTypeMismatch is an existing StatusCodeMap constant, deliberately reused rather than written inline: StatusCodeParityTests finds status constants by reflecting over Good/Uncertain/Bad-prefixed uint fields and checking them against the pinned SDK, so an inline literal would be invisible to that guard (Gitea #497, where 16 wrong constants had accumulated across 6 drivers exactly this way). Logging is now once per DISTINCT value kind rather than once per pump. The set is bounded by the MxValue oneof enum so a broken producer still cannot flood, but a second unrepresentable kind appearing later gets its own line — warn-once-per-pump would have silently swallowed it, which is the same class of bug as the null this commit fixes. The test's fixture matters more than its assertion: the undecodable event carries Quality = 192 (OPC DA Good), so a decoder that gave up silently would publish Good and fail. Paired with a positive control — a decodable value at the same quality must still publish Good — so it cannot be satisfied by a pump that marks everything Bad. Falsified by reverting the status to Good: the test reds, and only that test. Verified: 331 Galaxy tests green, Core.Abstractions 298 (the parity guard), solution builds 0 errors. Docs corrected in the two places that recorded the old decision as deliberate.
10 KiB
Galaxy backend performance
This document covers the performance surface of the in-process
GalaxyDriver (the v2 mxgw backend) — the ActivitySource it emits, the
metrics on its EventPump, the soak scenario that validates it, and the
tuning knobs you can reach for when the dev parity rig surfaces a hot
spot.
Tracing surface (PR 6.1)
The driver emits spans on the ZB.MOM.WW.OtOpcUa.Driver.Galaxy
ActivitySource. No package dependency on OpenTelemetry — the host
process picks the listener (OTLP exporter, dotnet-trace, Application
Insights). Wire it via OpenTelemetry.Trace.AddSource(...) in the
host's tracing pipeline.
| Span | Source | Tags |
|---|---|---|
galaxy.subscribe_bulk |
TracedGalaxySubscriber |
galaxy.client, galaxy.tag_count, galaxy.buffered_interval_ms, galaxy.success_count |
galaxy.unsubscribe_bulk |
TracedGalaxySubscriber |
galaxy.client, galaxy.tag_count |
galaxy.stream_events |
TracedGalaxySubscriber |
galaxy.client, galaxy.event_count (set on stream end) |
galaxy.write |
TracedGalaxyDataWriter |
galaxy.client, galaxy.tag_count, galaxy.secured_write_count, galaxy.success_count |
galaxy.get_hierarchy |
TracedGalaxyHierarchySource |
galaxy.client, galaxy.object_count |
The stream-events span deliberately covers the entire stream lifetime rather than per-event spans — at 50k tags / 1Hz the per-event volume would dominate the trace pipeline. Per-event visibility flows through the metrics surface instead.
Metrics surface (PR 6.2)
EventPump publishes three counters on the
ZB.MOM.WW.OtOpcUa.Driver.Galaxy meter, each tagged with
galaxy.client so multi-driver hosts can split by source:
| Counter | Unit | Meaning |
|---|---|---|
galaxy.events.received |
{event} |
MxEvents read from the gateway StreamEvents stream |
galaxy.events.dispatched |
{event} |
MxEvents that made it through the bounded channel into OnDataChange |
galaxy.events.dropped |
{event} |
MxEvents discarded because the bounded channel was full (newest-dropped) |
galaxy.events.replay_gaps |
{gap} |
Replay-gap sentinels received — the gateway evicted events we can never see |
galaxy.events.undecodable |
{event} |
Data-change events carrying a value kind this driver cannot represent |
The invariant is received = dispatched + dropped + replay_gaps + (in-flight in the channel). A replay-gap sentinel is counted as
received but never enters the channel — it is a control signal with no
item payload, handled on the read loop precisely so channel pressure
can never drop it.
Watch the dropped counter — it is the leading indicator of
listener back-pressure. A non-zero dropped rate means a downstream
consumer (DriverNodeManager → UA notification queue → client) is
slower than the gw event stream; investigate that consumer before
raising EventPump channel capacity.
galaxy.events.replay_gaps should be flat at zero, for a structural
reason rather than a healthy one: the gateway only emits the sentinel on
a stream opened with after_worker_sequence > 0, and the driver opens
with 0 ("fresh stream, not a resume"). A non-zero value therefore means
the resume path was enabled — each gap costs a full re-subscribe of every
tag on the driver, so a climbing counter is a sizing problem, not just an
observation.
galaxy.events.undecodable should likewise be flat at zero: every
MxValue kind the contract declares decodes today. Non-zero means the
gateway shipped a new wire type, and those readings are being published
as BadTypeMismatch with a null value — visible to clients as bad
data rather than as a plausible null, and logged once per distinct kind.
The remedy is a mapping in MxValueDecoder, not a quality change.
Bounded channel design
The pump runs two background tasks:
- Producer — reads from
IGalaxySubscriber.StreamEventsAsync, incrementsevents.received, andTryWrites into a boundedChannel<MxEvent>. When the channel is full, the producer counts the drop and continues reading the gw stream so back-pressure does not propagate upstream (which would stall the gw worker and cascade to all driver instances sharing that worker). - Consumer — reads from the channel, fans out via
SubscriptionRegistry, incrementsevents.dispatched.
Default channel capacity is 50_000 (one second of headroom at 50k
tags / 1Hz). Override via the EventPump constructor's
channelCapacity parameter; the public-facing wiring path in
GalaxyDriver.EnsureEventPumpStarted does not yet expose this through
GalaxyDriverOptions because no parity scenario has needed it. Add it
when soak data does.
Buffered update interval (PR 6.3)
MxAccess.PublishingIntervalMs (default 1000) flows through both
subscribe paths:
GalaxyDriver.SubscribeAsync— the caller'spublishingIntervalwins when non-zero (the server's UA subscription publishingInterval drives this in production). When the caller passesTimeSpan.Zero, the configured option is the fallback.PerPlatformProbeWatcher— the watcher passes the configured value throughSubscribeBulkAsyncso probeScanStatechanges publish at the deployment's chosen cadence.
A session-level SetBufferedUpdateInterval RPC exists in the gw
protocol but the .NET client doesn't expose a typed helper yet —
adjusting an existing subscription's interval mid-flight is a
follow-up. Today's path subscribes once at the right interval, which
covers the common case.
Soak scenario (PR 6.4)
SoakScenarioTests.Soak_HoldsSubscription_AndKeepsEventStreamFlowing
in Driver.Galaxy.ParityTests is the long-running validation. It
subscribes a configurable tag count (default 50_000), holds the
subscription for a configurable duration (default 24h), polls the
three counters every minute, and asserts:
events.receivedcontinues to grow (gw stream isn't stuck)events.dropped / events.receivedstays under the configured ceiling (default 0.5%)- process working-set doesn't grow more than 1 GB above baseline (leak guard)
Always skipped unless the operator opts in:
# Full 24h × 50k soak (production validation)
OTOPCUA_SOAK_RUN=1 dotnet test tests/ZB.MOM.WW.OtOpcUa.Driver.Galaxy.ParityTests/
# Compressed CI-friendly run (10min × 1k tags, 1% drop ceiling)
OTOPCUA_SOAK_RUN=1 OTOPCUA_SOAK_MINUTES=10 OTOPCUA_SOAK_TAGS=1000 \
OTOPCUA_SOAK_DROP_PCT=1.0 \
dotnet test tests/ZB.MOM.WW.OtOpcUa.Driver.Galaxy.ParityTests/
The scenario writes a per-minute CSV-style row to stdout
(soak,<minutes>,received=…,dispatched=…,dropped=…,ws_mb=…) so an
operator can grep the test runner output mid-run.
Tuned defaults (PR 6.5)
| Option | Default | Source | Notes |
|---|---|---|---|
Gateway.ConnectTimeoutSeconds |
10 | unchanged | Cold-start network paths fit comfortably; soak never observed >2s |
Gateway.DefaultCallTimeoutSeconds |
30 | bumped from 5 in PR 6.5 | A 50k-tag SubscribeBulk can exceed 5s under MxAccess COM apartment lock contention; 30s leaves headroom while still failing fast on a wedged worker |
Gateway.StreamTimeoutSeconds |
0 (unlimited) | unchanged | The stream must run for the lifetime of the driver |
MxAccess.PublishingIntervalMs |
1000 | unchanged | Matches the legacy LMXProxyServer cadence; deployments needing tighter health visibility can dial down |
Reconnect.InitialBackoffMs |
500 | unchanged | First retry shouldn't dogpile a recovering gw |
Reconnect.MaxBackoffMs |
30_000 | unchanged | 30s ceiling so a long-down gw doesn't sit in 5+ min backoff |
Repository.DiscoverPageSize |
5000 | unchanged | One Galaxy page round-trip per ~5k objects; soak hadn't surfaced pressure |
EventPump channel capacity |
50_000 | unchanged | One second of headroom at 50k tags / 1Hz |
The unchanged rows are not "definitely correct" — they are "no live data argues for changing them." Re-run the soak scenario after every substantive driver change, and revise this table when the data does.
Where to look first when something's slow
- Slow
Discover? Inspectgalaxy.get_hierarchyspan duration andgalaxy.object_count. The gw walks the Galaxy DB serially; slow Discovers usually mean a slow ZB SQL. - Subscribe pile-up?
galaxy.subscribe_bulkspan duration correlates withgalaxy.tag_count. If duration ÷ tag_count starts climbing, the gw worker is probably under apartment-lock pressure. - Events stalled? Watch
galaxy.events.received. Flat-lined means the gw stream is wedged — kick the reconnect supervisor by forcing aReinitializeAsync. - Dropped events? Non-zero
galaxy.events.droppedmeans a slow downstream consumer. ProfileOnDataChangehandlers inDriverNodeManagerbefore bumping the channel capacity. - Memory growing? Confirm with the soak scenario's working-set
leak guard. Likely culprits: lingering subscription handles in
SubscriptionRegistry, or a downstream consumer retainingDataValueSnapshotreferences past their useful life.
Scripted-alarm engine — hot-path allocation reuse
ScriptedAlarmEngine keeps a per-alarm reusable evaluation scratch in _scratchByAlarmId — the read-cache Dictionary<string, DataValueSnapshot> and the AlarmPredicateContext are allocated once per alarm (on first evaluation) and refilled in place across every subsequent predicate evaluation. The hot path no longer allocates a fresh dictionary + context per upstream tag change. (Core.ScriptedAlarms-009)
Safety: reuse is serialised under _evalGate, so two threads can never observe the same scratch in a half-refilled state. The context wraps the read-cache by reference, so refilling the dictionary is what the predicate's ctx.GetTag(path) calls observe. LoadAsync clears _scratchByAlarmId alongside _alarms so a config-publish drops the prior generation's scratch (a new generation may carry different Inputs / Logger). Regression tests in ScriptedAlarmEngineTests lock the reuse contract:
Reevaluation_reuses_the_same_read_cache_dictionary— asserts dictionary instance identity across two evaluations.Reevaluation_reuses_the_same_predicate_context— same, for the context.LoadAsync_drops_the_prior_generations_scratch— asserts a publish resets the scratch.