Joseph Doherty
b4f8cb8de7
G-7 wired OpcUaClientTagDefinitionFactory.Inspect into the deploy-time TagConfig gate, which gave ControlPlane a ProjectReference to Driver.OpcUaClient.Contracts — and with it, transitively, the whole OPC UA client stack (5 OPCFoundation packages) into every host that loads the control plane. NamespaceMap was the only reason Contracts carried OPCFoundation.NetStandard.Opc.Ua.Client: its entire public surface is ISession/NamespaceTable/NodeId-typed. It moves to a new leaf project, ZB.MOM.WW.OtOpcUa.Driver.OpcUaClient.Session, referenced by the runtime .Driver and by .Browser. Contracts is left with Core.Abstractions and NOTHING else — the same shape as Calculation.Contracts. The namespace stays ZB.MOM.WW.OtOpcUa.Driver.OpcUaClient, so no consumer's `using` changed. The .Session -> .Contracts direction is deliberate: the blob read NamespaceMap needs is OpcUaClientTagDefinitionFactory.TryReadNodeId, the one authority it shares with the deploy gate, and that must stay in the dependency-light half. Why a new project rather than folding NamespaceMap into the runtime .Driver and having .Browser reference it (the Driver.Mqtt.Browser #512-style deliberate exception): the AdminUI project-references .Browser and NOT .Driver, so that shape would pull the OpcUaClient driver runtime — plus Core, Opc.Ua.Configuration and Secrets.Abstractions — into the AdminUI's build/deploy graph. That is exactly the violation #512 spent two extractions removing from Mqtt.Browser; re-introducing it to save one csproj is a bad trade. Guard: ContractsIsDependencyLightTests (Driver.OpcUaClient.Tests) asserts the Contracts manifest names no Opc.Ua* assembly, plus a counterpart asserting .Session does. An ABSENCE assertion is sound on the manifest where a presence one is not — the compiler elides an unused reference, but it MUST emit one the moment Opc.Ua-typed code is added. Falsified by temporarily re-adding the package plus an Opc.Ua.NodeId-typed member: red on Opc.Ua.Types, green again on removal. Evidence — `dotnet list ControlPlane package --include-transitive | grep -i opc`: before: OPCFoundation.NetStandard.Opc.Ua.{Client,Configuration,Core, Security.Certificates,Types} 1.5.378.106 after: none (and 0 Opc.Ua*.dll in ControlPlane's output directory)
47 lines
3.0 KiB
XML
47 lines
3.0 KiB
XML
<Project Sdk="Microsoft.NET.Sdk">
|
|
<PropertyGroup>
|
|
<TargetFramework>net10.0</TargetFramework>
|
|
<Nullable>enable</Nullable>
|
|
<ImplicitUsings>enable</ImplicitUsings>
|
|
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
|
|
<!-- Namespace stays ZB.MOM.WW.OtOpcUa.Driver.OpcUaClient (no .Session suffix) so moving
|
|
NamespaceMap here changed no consumer's `using`. -->
|
|
<RootNamespace>ZB.MOM.WW.OtOpcUa.Driver.OpcUaClient</RootNamespace>
|
|
<AssemblyName>ZB.MOM.WW.OtOpcUa.Driver.OpcUaClient.Session</AssemblyName>
|
|
</PropertyGroup>
|
|
<!--
|
|
The live-OPC-UA-session layer of the OpcUaClient driver: everything the driver AND the AdminUI's
|
|
browser both need that is typed in ISession / NodeId / NamespaceTable. Today that is exactly
|
|
NamespaceMap.
|
|
|
|
WHY IT IS NOT IN .Contracts. It used to be, and .Contracts therefore carried
|
|
OPCFoundation.NetStandard.Opc.Ua.Client. When G-7 wired OpcUaClientTagDefinitionFactory.Inspect into
|
|
the deploy-time TagConfig gate, ControlPlane gained a ProjectReference to .Contracts — and with it
|
|
the whole OPC UA client stack, transitively, into every host that loads the control plane. A
|
|
Contracts project is meant to be the dependency-light parse/shape layer (see Calculation.Contracts:
|
|
Core.Abstractions and nothing else), so the SDK-typed half moved out rather than the gate doing
|
|
without.
|
|
|
|
WHY NOT JUST PUT IT IN THE .Driver PROJECT (the Mqtt.Browser-style deliberate exception). The
|
|
AdminUI project-references .Browser and NOT the runtime .Driver. Having .Browser reference .Driver
|
|
to reach NamespaceMap would pull the whole driver runtime — plus Core, Opc.Ua.Configuration and
|
|
Secrets.Abstractions — into the AdminUI's build/deploy graph. That is precisely the violation Gitea
|
|
#512 spent two extractions removing from Driver.Mqtt.Browser; re-introducing the same shape here to
|
|
save one csproj would be trading a measured regression for a little less churn.
|
|
|
|
KEEP THIS LEAF THIN. Anything addable here that is NOT session-typed belongs in .Contracts, or the
|
|
dependency-light property this split exists to buy erodes one file at a time. The pin is
|
|
ContractsIsDependencyLightTests in Driver.OpcUaClient.Tests.
|
|
-->
|
|
<ItemGroup>
|
|
<PackageReference Include="OPCFoundation.NetStandard.Opc.Ua.Client" />
|
|
</ItemGroup>
|
|
<ItemGroup>
|
|
<!-- RawTagEntry (the v3 authored-tag identity NamespaceMap indexes) lives in the Core.Abstractions
|
|
leaf; OpcUaClientTagDefinitionFactory is the ONE authority for reading a TagConfig blob's
|
|
nodeId, shared with the deploy gate — NamespaceMap calls it rather than re-parsing. -->
|
|
<ProjectReference Include="..\..\Core\ZB.MOM.WW.OtOpcUa.Core.Abstractions\ZB.MOM.WW.OtOpcUa.Core.Abstractions.csproj"/>
|
|
<ProjectReference Include="..\ZB.MOM.WW.OtOpcUa.Driver.OpcUaClient.Contracts\ZB.MOM.WW.OtOpcUa.Driver.OpcUaClient.Contracts.csproj"/>
|
|
</ItemGroup>
|
|
</Project>
|