7d30009dc8
TryParse now rejects three classes of malformed PCCC address: - Sub-element + bit-index together (e.g. T4:0.ACC/2) — never valid in PCCC - File number on I/O/S system files (e.g. I3:0, S2:1) — single-letter only - Sub-element on non-T/C/R files (e.g. B3:0.DN, N7:0.FOO) — only Timer, Counter, and Control files carry structured elements New helper predicates IsNoFileNumberLetter / IsSubElementFileLetter keep the parser's intent clear. Regression tests added in AbLegacyAddressTests. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
153 lines
7.1 KiB
C#
153 lines
7.1 KiB
C#
namespace ZB.MOM.WW.OtOpcUa.Driver.AbLegacy;
|
|
|
|
/// <summary>
|
|
/// Parsed PCCC file-based address: file letter + file number + word number, optionally a
|
|
/// sub-element (<c>.ACC</c> on a timer) or bit index (<c>/0</c> on a bit file).
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// <para>Logix symbolic tags are parsed elsewhere (<see cref="AbLegacy"/> is for SLC / PLC-5 /
|
|
/// MicroLogix — no symbol table; everything is file-letter + file-number + word-number).</para>
|
|
/// <list type="bullet">
|
|
/// <item><c>N7:0</c> — integer file 7, word 0 (signed 16-bit).</item>
|
|
/// <item><c>N7:5</c> — integer file 7, word 5.</item>
|
|
/// <item><c>F8:0</c> — float file 8, word 0 (32-bit IEEE754).</item>
|
|
/// <item><c>B3:0/0</c> — bit file 3, word 0, bit 0.</item>
|
|
/// <item><c>ST9:0</c> — string file 9, string 0 (82-byte fixed-length + length word).</item>
|
|
/// <item><c>T4:0.ACC</c> — timer file 4, timer 0, accumulator sub-element.</item>
|
|
/// <item><c>C5:0.PRE</c> — counter file 5, counter 0, preset sub-element.</item>
|
|
/// <item><c>I:0/0</c> — input file, slot 0, bit 0 (no file-number for I/O).</item>
|
|
/// <item><c>O:1/2</c> — output file, slot 1, bit 2.</item>
|
|
/// <item><c>S:1</c> — status file, word 1.</item>
|
|
/// <item><c>L9:0</c> — long-integer file (SLC 5/05+, 32-bit).</item>
|
|
/// </list>
|
|
/// <para>Pass the original string straight through to libplctag's <c>name=...</c> attribute —
|
|
/// the PLC-side decoder handles the format. This parser only validates the shape + surfaces
|
|
/// the structural pieces for driver-side routing (e.g. deciding whether a tag needs
|
|
/// bit-level read-modify-write).</para>
|
|
/// </remarks>
|
|
public sealed record AbLegacyAddress(
|
|
string FileLetter,
|
|
int? FileNumber,
|
|
int WordNumber,
|
|
int? BitIndex,
|
|
string? SubElement)
|
|
{
|
|
public string ToLibplctagName()
|
|
{
|
|
var file = FileNumber is null ? FileLetter : $"{FileLetter}{FileNumber}";
|
|
var wordPart = $"{file}:{WordNumber}";
|
|
if (SubElement is not null) wordPart += $".{SubElement}";
|
|
if (BitIndex is not null) wordPart += $"/{BitIndex}";
|
|
return wordPart;
|
|
}
|
|
|
|
public static AbLegacyAddress? TryParse(string? value)
|
|
{
|
|
if (string.IsNullOrWhiteSpace(value)) return null;
|
|
var src = value.Trim();
|
|
|
|
// BitIndex: trailing /N. The valid range depends on the parent word width, which is
|
|
// determined by the file letter (16-bit N/B/I/O/S/A → 0..15, 32-bit L → 0..31). Capture
|
|
// the raw value here and range-check it once the file letter is known (see below).
|
|
int? bitIndex = null;
|
|
var slashIdx = src.IndexOf('/');
|
|
if (slashIdx >= 0)
|
|
{
|
|
if (!int.TryParse(src[(slashIdx + 1)..], out var bit) || bit < 0) return null;
|
|
bitIndex = bit;
|
|
src = src[..slashIdx];
|
|
}
|
|
|
|
// SubElement: trailing .NAME (ACC / PRE / EN / DN / TT / CU / CD / FD / etc.)
|
|
string? subElement = null;
|
|
var dotIdx = src.LastIndexOf('.');
|
|
if (dotIdx >= 0)
|
|
{
|
|
var candidate = src[(dotIdx + 1)..];
|
|
if (candidate.Length > 0 && candidate.All(char.IsLetter))
|
|
{
|
|
subElement = candidate.ToUpperInvariant();
|
|
src = src[..dotIdx];
|
|
}
|
|
}
|
|
|
|
var colonIdx = src.IndexOf(':');
|
|
if (colonIdx <= 0) return null;
|
|
var filePart = src[..colonIdx];
|
|
var wordPart = src[(colonIdx + 1)..];
|
|
if (!int.TryParse(wordPart, out var word) || word < 0) return null;
|
|
|
|
// File letter + optional file number (single letter for I/O/S, letter+number otherwise).
|
|
if (filePart.Length == 0 || !char.IsLetter(filePart[0])) return null;
|
|
var letterEnd = 1;
|
|
while (letterEnd < filePart.Length && char.IsLetter(filePart[letterEnd])) letterEnd++;
|
|
|
|
var letter = filePart[..letterEnd].ToUpperInvariant();
|
|
int? fileNumber = null;
|
|
if (letterEnd < filePart.Length)
|
|
{
|
|
if (!int.TryParse(filePart[letterEnd..], out var fn) || fn < 0) return null;
|
|
fileNumber = fn;
|
|
}
|
|
|
|
// Reject unknown file letters — these cover SLC/ML/PLC-5 canonical families.
|
|
if (!IsKnownFileLetter(letter)) return null;
|
|
|
|
// Range-check the bit index against the file's word width. A PCCC N/B/I/O/S/A word is a
|
|
// 16-bit element, so valid bit indices are 0..15; an L-file element is 32-bit (0..31).
|
|
// F-files are 32-bit IEEE-754 floats and are not bit-addressable at all.
|
|
if (bitIndex is int b)
|
|
{
|
|
var maxBit = MaxBitIndexFor(letter);
|
|
if (maxBit < 0 || b > maxBit) return null;
|
|
}
|
|
|
|
// I/O/S are single-letter system files — they carry no file number in the PCCC spec.
|
|
// Accepting I3:0 or S2:1 would pass a malformed address straight to libplctag; reject early.
|
|
if (fileNumber is not null && IsNoFileNumberLetter(letter)) return null;
|
|
|
|
// A PCCC address cannot have both a sub-element and a bit index: the word is either
|
|
// structured (T4:0.ACC) or bit-addressed (N7:0/3), never both.
|
|
if (subElement is not null && bitIndex is not null) return null;
|
|
|
|
// Sub-elements are only meaningful on Timer (T), Counter (C), and Control (R) files —
|
|
// those are the only structured-element file types in the PCCC spec. Accepting B3:0.DN
|
|
// or N7:0.FOO would produce an address libplctag silently misinterprets.
|
|
if (subElement is not null && !IsSubElementFileLetter(letter)) return null;
|
|
|
|
return new AbLegacyAddress(letter, fileNumber, word, bitIndex, subElement);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Highest valid bit index for a file letter, or <c>-1</c> if the file type is not
|
|
/// bit-addressable. 16-bit element files (N/B/I/O/S/A) permit bits 0..15; the 32-bit
|
|
/// L-file permits 0..31.
|
|
/// </summary>
|
|
private static int MaxBitIndexFor(string letter) => letter switch
|
|
{
|
|
"L" => 31,
|
|
"N" or "B" or "I" or "O" or "S" or "A" => 15,
|
|
_ => -1,
|
|
};
|
|
|
|
private static bool IsKnownFileLetter(string letter) => letter switch
|
|
{
|
|
"N" or "F" or "B" or "L" or "ST" or "T" or "C" or "R" or "I" or "O" or "S" or "A" => true,
|
|
_ => false,
|
|
};
|
|
|
|
/// <summary>
|
|
/// Returns <see langword="true"/> for file letters that carry no explicit file number in the
|
|
/// PCCC spec. <c>I</c> (input), <c>O</c> (output), and <c>S</c> (status) are single-letter
|
|
/// system files; a digit after the letter (e.g. <c>I3</c>) is a malformed address.
|
|
/// </summary>
|
|
private static bool IsNoFileNumberLetter(string letter) => letter is "I" or "O" or "S";
|
|
|
|
/// <summary>
|
|
/// Returns <see langword="true"/> for file letters that may carry a sub-element suffix
|
|
/// (<c>.ACC</c>, <c>.PRE</c>, etc.). Only Timer (<c>T</c>), Counter (<c>C</c>), and
|
|
/// Control (<c>R</c>) files have structured elements in the PCCC spec.
|
|
/// </summary>
|
|
private static bool IsSubElementFileLetter(string letter) => letter is "T" or "C" or "R";
|
|
}
|