64e3fbe035
v2-ci / build (push) Failing after 1m43s
v2-ci / unit-tests (tests/Core/ZB.MOM.WW.OtOpcUa.Cluster.Tests) (push) Has been skipped
v2-ci / unit-tests (tests/Server/ZB.MOM.WW.OtOpcUa.ControlPlane.Tests) (push) Has been skipped
v2-ci / unit-tests (tests/Server/ZB.MOM.WW.OtOpcUa.OpcUaServer.Tests) (push) Has been skipped
v2-ci / unit-tests (tests/Server/ZB.MOM.WW.OtOpcUa.Runtime.Tests) (push) Has been skipped
v2-ci / unit-tests (tests/Server/ZB.MOM.WW.OtOpcUa.Security.Tests) (push) Has been skipped
v2-ci / integration (tests/Server/ZB.MOM.WW.OtOpcUa.Host.IntegrationTests) (push) Has been skipped
v2-ci / integration (tests/Server/ZB.MOM.WW.OtOpcUa.OpcUaServer.IntegrationTests) (push) Has been skipped
Adds <summary>, <param>, <typeparam>, and <inheritdoc/> tags to public members surfaced by commentchecker — resolves 5,847 of 5,869 issues (99.6%) across three /fixdocs passes.
357 lines
13 KiB
C#
357 lines
13 KiB
C#
using Opc.Ua;
|
|
using Shouldly;
|
|
using Xunit;
|
|
using ZB.MOM.WW.OtOpcUa.Client.Shared.Models;
|
|
using ZB.MOM.WW.OtOpcUa.Client.UI.Services;
|
|
using ZB.MOM.WW.OtOpcUa.Client.UI.Tests.Fakes;
|
|
using ZB.MOM.WW.OtOpcUa.Client.UI.ViewModels;
|
|
using BrowseResult = ZB.MOM.WW.OtOpcUa.Client.Shared.Models.BrowseResult;
|
|
|
|
namespace ZB.MOM.WW.OtOpcUa.Client.UI.Tests;
|
|
|
|
public class SubscriptionsViewModelTests
|
|
{
|
|
private readonly FakeOpcUaClientService _service;
|
|
private readonly SubscriptionsViewModel _vm;
|
|
|
|
/// <summary>Initializes test instance with fake services.</summary>
|
|
public SubscriptionsViewModelTests()
|
|
{
|
|
_service = new FakeOpcUaClientService();
|
|
var dispatcher = new SynchronousUiDispatcher();
|
|
_vm = new SubscriptionsViewModel(_service, dispatcher);
|
|
}
|
|
|
|
/// <summary>Verifies that AddSubscriptionCommand cannot execute when disconnected.</summary>
|
|
[Fact]
|
|
public void AddSubscriptionCommand_CannotExecute_WhenDisconnected()
|
|
{
|
|
_vm.IsConnected = false;
|
|
_vm.NewNodeIdText = "ns=2;s=SomeNode";
|
|
_vm.AddSubscriptionCommand.CanExecute(null).ShouldBeFalse();
|
|
}
|
|
|
|
/// <summary>Verifies that AddSubscriptionCommand cannot execute without a node ID.</summary>
|
|
[Fact]
|
|
public void AddSubscriptionCommand_CannotExecute_WhenNoNodeId()
|
|
{
|
|
_vm.IsConnected = true;
|
|
_vm.NewNodeIdText = null;
|
|
_vm.AddSubscriptionCommand.CanExecute(null).ShouldBeFalse();
|
|
}
|
|
|
|
/// <summary>Verifies that AddSubscriptionCommand adds a new subscription to the active list.</summary>
|
|
[Fact]
|
|
public async Task AddSubscriptionCommand_AddsItem()
|
|
{
|
|
_vm.IsConnected = true;
|
|
_vm.NewNodeIdText = "ns=2;s=SomeNode";
|
|
_vm.NewInterval = 500;
|
|
|
|
await _vm.AddSubscriptionCommand.ExecuteAsync(null);
|
|
|
|
_vm.ActiveSubscriptions.Count.ShouldBe(1);
|
|
_vm.ActiveSubscriptions[0].NodeId.ShouldBe("ns=2;s=SomeNode");
|
|
_vm.ActiveSubscriptions[0].IntervalMs.ShouldBe(500);
|
|
_vm.SubscriptionCount.ShouldBe(1);
|
|
_service.SubscribeCallCount.ShouldBe(1);
|
|
}
|
|
|
|
/// <summary>Verifies that RemoveSubscriptionCommand removes selected subscription.</summary>
|
|
[Fact]
|
|
public async Task RemoveSubscriptionCommand_RemovesItem()
|
|
{
|
|
_vm.IsConnected = true;
|
|
_vm.NewNodeIdText = "ns=2;s=SomeNode";
|
|
await _vm.AddSubscriptionCommand.ExecuteAsync(null);
|
|
|
|
_vm.SelectedSubscription = _vm.ActiveSubscriptions[0];
|
|
await _vm.RemoveSubscriptionCommand.ExecuteAsync(null);
|
|
|
|
_vm.ActiveSubscriptions.ShouldBeEmpty();
|
|
_vm.SubscriptionCount.ShouldBe(0);
|
|
_service.UnsubscribeCallCount.ShouldBe(1);
|
|
}
|
|
|
|
/// <summary>Verifies that RemoveSubscriptionCommand cannot execute without selection.</summary>
|
|
[Fact]
|
|
public void RemoveSubscriptionCommand_CannotExecute_WhenNoSelection()
|
|
{
|
|
_vm.IsConnected = true;
|
|
_vm.SelectedSubscription = null;
|
|
_vm.RemoveSubscriptionCommand.CanExecute(null).ShouldBeFalse();
|
|
}
|
|
|
|
/// <summary>Verifies that DataChanged event updates the matching subscription row.</summary>
|
|
[Fact]
|
|
public async Task DataChanged_UpdatesMatchingRow()
|
|
{
|
|
_vm.IsConnected = true;
|
|
_vm.NewNodeIdText = "ns=2;s=SomeNode";
|
|
await _vm.AddSubscriptionCommand.ExecuteAsync(null);
|
|
|
|
var dataValue = new DataValue(new Variant(42), StatusCodes.Good, DateTime.UtcNow);
|
|
_service.RaiseDataChanged(new DataChangedEventArgs("ns=2;s=SomeNode", dataValue));
|
|
|
|
_vm.ActiveSubscriptions[0].Value.ShouldBe("42");
|
|
_vm.ActiveSubscriptions[0].Status.ShouldNotBeNull();
|
|
}
|
|
|
|
/// <summary>Verifies that DataChanged event does not update non-matching subscription rows.</summary>
|
|
[Fact]
|
|
public async Task DataChanged_DoesNotUpdateNonMatchingRow()
|
|
{
|
|
_vm.IsConnected = true;
|
|
_vm.NewNodeIdText = "ns=2;s=SomeNode";
|
|
await _vm.AddSubscriptionCommand.ExecuteAsync(null);
|
|
|
|
var dataValue = new DataValue(new Variant(42), StatusCodes.Good, DateTime.UtcNow);
|
|
_service.RaiseDataChanged(new DataChangedEventArgs("ns=2;s=OtherNode", dataValue));
|
|
|
|
_vm.ActiveSubscriptions[0].Value.ShouldBeNull();
|
|
}
|
|
|
|
/// <summary>Verifies that Clear removes all subscriptions.</summary>
|
|
[Fact]
|
|
public void Clear_RemovesAllSubscriptions()
|
|
{
|
|
_vm.ActiveSubscriptions.Add(new SubscriptionItemViewModel("ns=2;s=X", 1000));
|
|
_vm.SubscriptionCount = 1;
|
|
|
|
_vm.Clear();
|
|
|
|
_vm.ActiveSubscriptions.ShouldBeEmpty();
|
|
_vm.SubscriptionCount.ShouldBe(0);
|
|
}
|
|
|
|
/// <summary>Verifies that Teardown unregisters the event handler.</summary>
|
|
[Fact]
|
|
public void Teardown_UnhooksEventHandler()
|
|
{
|
|
_vm.Teardown();
|
|
|
|
// After teardown, raising event should not update anything
|
|
_vm.ActiveSubscriptions.Add(new SubscriptionItemViewModel("ns=2;s=X", 1000));
|
|
var dataValue = new DataValue(new Variant(42), StatusCodes.Good, DateTime.UtcNow);
|
|
_service.RaiseDataChanged(new DataChangedEventArgs("ns=2;s=X", dataValue));
|
|
|
|
_vm.ActiveSubscriptions[0].Value.ShouldBeNull();
|
|
}
|
|
|
|
/// <summary>Verifies that default interval is 1000 milliseconds.</summary>
|
|
[Fact]
|
|
public void DefaultInterval_Is1000()
|
|
{
|
|
_vm.NewInterval.ShouldBe(1000);
|
|
}
|
|
|
|
/// <summary>Verifies that AddSubscriptionForNodeAsync adds a subscription.</summary>
|
|
[Fact]
|
|
public async Task AddSubscriptionForNodeAsync_AddsSubscription()
|
|
{
|
|
_vm.IsConnected = true;
|
|
|
|
await _vm.AddSubscriptionForNodeAsync("ns=2;s=TestNode");
|
|
|
|
_vm.ActiveSubscriptions.Count.ShouldBe(1);
|
|
_vm.ActiveSubscriptions[0].NodeId.ShouldBe("ns=2;s=TestNode");
|
|
_vm.SubscriptionCount.ShouldBe(1);
|
|
_service.SubscribeCallCount.ShouldBe(1);
|
|
}
|
|
|
|
/// <summary>Verifies that AddSubscriptionForNodeAsync skips duplicate subscriptions.</summary>
|
|
[Fact]
|
|
public async Task AddSubscriptionForNodeAsync_SkipsDuplicate()
|
|
{
|
|
_vm.IsConnected = true;
|
|
|
|
await _vm.AddSubscriptionForNodeAsync("ns=2;s=TestNode");
|
|
await _vm.AddSubscriptionForNodeAsync("ns=2;s=TestNode");
|
|
|
|
_vm.ActiveSubscriptions.Count.ShouldBe(1);
|
|
_service.SubscribeCallCount.ShouldBe(1);
|
|
}
|
|
|
|
/// <summary>Verifies that AddSubscriptionForNodeAsync does nothing when disconnected.</summary>
|
|
[Fact]
|
|
public async Task AddSubscriptionForNodeAsync_DoesNothing_WhenDisconnected()
|
|
{
|
|
_vm.IsConnected = false;
|
|
|
|
await _vm.AddSubscriptionForNodeAsync("ns=2;s=TestNode");
|
|
|
|
_vm.ActiveSubscriptions.ShouldBeEmpty();
|
|
_service.SubscribeCallCount.ShouldBe(0);
|
|
}
|
|
|
|
/// <summary>Verifies that GetSubscribedNodeIds returns all active subscription node IDs.</summary>
|
|
[Fact]
|
|
public async Task GetSubscribedNodeIds_ReturnsActiveNodeIds()
|
|
{
|
|
_vm.IsConnected = true;
|
|
await _vm.AddSubscriptionForNodeAsync("ns=2;s=Node1");
|
|
await _vm.AddSubscriptionForNodeAsync("ns=2;s=Node2");
|
|
|
|
var ids = _vm.GetSubscribedNodeIds();
|
|
|
|
ids.Count.ShouldBe(2);
|
|
ids.ShouldContain("ns=2;s=Node1");
|
|
ids.ShouldContain("ns=2;s=Node2");
|
|
}
|
|
|
|
/// <summary>Verifies that RestoreSubscriptionsAsync subscribes to all provided node IDs.</summary>
|
|
[Fact]
|
|
public async Task RestoreSubscriptionsAsync_SubscribesAllNodes()
|
|
{
|
|
_vm.IsConnected = true;
|
|
|
|
await _vm.RestoreSubscriptionsAsync(["ns=2;s=A", "ns=2;s=B"]);
|
|
|
|
_vm.ActiveSubscriptions.Count.ShouldBe(2);
|
|
_service.SubscribeCallCount.ShouldBe(2);
|
|
}
|
|
|
|
/// <summary>Verifies that ValidateAndWriteAsync returns true on successful write.</summary>
|
|
[Fact]
|
|
public async Task ValidateAndWriteAsync_SuccessReturnsTrue()
|
|
{
|
|
_vm.IsConnected = true;
|
|
_service.ReadResult = new DataValue(new Variant(42), Opc.Ua.StatusCodes.Good, DateTime.UtcNow);
|
|
_service.WriteResult = Opc.Ua.StatusCodes.Good;
|
|
|
|
var (success, message) = await _vm.ValidateAndWriteAsync("ns=2;s=Node1", "99");
|
|
|
|
success.ShouldBeTrue();
|
|
message.ShouldContain("Good");
|
|
_service.WriteCallCount.ShouldBe(1);
|
|
}
|
|
|
|
/// <summary>Verifies that ValidateAndWriteAsync returns false when value parsing fails.</summary>
|
|
[Fact]
|
|
public async Task ValidateAndWriteAsync_ParseFailureReturnsFalse()
|
|
{
|
|
_vm.IsConnected = true;
|
|
_service.ReadResult = new DataValue(new Variant(42), Opc.Ua.StatusCodes.Good, DateTime.UtcNow);
|
|
|
|
var (success, message) = await _vm.ValidateAndWriteAsync("ns=2;s=Node1", "not-a-number");
|
|
|
|
success.ShouldBeFalse();
|
|
message.ShouldContain("Cannot parse");
|
|
message.ShouldContain("Int32");
|
|
_service.WriteCallCount.ShouldBe(0);
|
|
}
|
|
|
|
/// <summary>Verifies that ValidateAndWriteAsync returns false when write fails.</summary>
|
|
[Fact]
|
|
public async Task ValidateAndWriteAsync_WriteFailureReturnsFalse()
|
|
{
|
|
_vm.IsConnected = true;
|
|
_service.ReadResult = new DataValue(new Variant("hello"), Opc.Ua.StatusCodes.Good, DateTime.UtcNow);
|
|
_service.WriteException = new Exception("Access denied");
|
|
|
|
var (success, message) = await _vm.ValidateAndWriteAsync("ns=2;s=Node1", "world");
|
|
|
|
success.ShouldBeFalse();
|
|
message.ShouldContain("Access denied");
|
|
}
|
|
|
|
/// <summary>Verifies that ValidateAndWriteAsync returns false when status is bad.</summary>
|
|
[Fact]
|
|
public async Task ValidateAndWriteAsync_BadStatusReturnsFalse()
|
|
{
|
|
_vm.IsConnected = true;
|
|
_service.ReadResult = new DataValue(new Variant("hello"), Opc.Ua.StatusCodes.Good, DateTime.UtcNow);
|
|
_service.WriteResult = Opc.Ua.StatusCodes.BadNotWritable;
|
|
|
|
var (success, message) = await _vm.ValidateAndWriteAsync("ns=2;s=Node1", "world");
|
|
|
|
success.ShouldBeFalse();
|
|
message.ShouldContain("Write failed");
|
|
}
|
|
|
|
/// <summary>Verifies that AddSubscriptionRecursiveAsync subscribes a variable directly.</summary>
|
|
[Fact]
|
|
public async Task AddSubscriptionRecursiveAsync_SubscribesVariableDirectly()
|
|
{
|
|
_vm.IsConnected = true;
|
|
|
|
await _vm.AddSubscriptionRecursiveAsync("ns=2;s=Var1", "Variable");
|
|
|
|
_vm.ActiveSubscriptions.Count.ShouldBe(1);
|
|
_vm.ActiveSubscriptions[0].NodeId.ShouldBe("ns=2;s=Var1");
|
|
}
|
|
|
|
/// <summary>Verifies that AddSubscriptionRecursiveAsync browses objects and subscribes variable children.</summary>
|
|
[Fact]
|
|
public async Task AddSubscriptionRecursiveAsync_BrowsesObjectAndSubscribesVariableChildren()
|
|
{
|
|
_vm.IsConnected = true;
|
|
_service.BrowseResultsByParent["ns=2;s=Folder"] =
|
|
[
|
|
new BrowseResult("ns=2;s=Child1", "Child1", "Variable", false),
|
|
new BrowseResult("ns=2;s=Child2", "Child2", "Variable", false)
|
|
];
|
|
|
|
await _vm.AddSubscriptionRecursiveAsync("ns=2;s=Folder", "Object");
|
|
|
|
_vm.ActiveSubscriptions.Count.ShouldBe(2);
|
|
_service.SubscribeCallCount.ShouldBe(2);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Regression test for Client.UI-006 — when SubscribeAsync throws, the failure must be surfaced
|
|
/// to the operator via the view model's StatusMessage rather than silently swallowed.
|
|
/// </summary>
|
|
[Fact]
|
|
public async Task AddSubscription_OnFailure_SurfacesStatusMessage()
|
|
{
|
|
_vm.IsConnected = true;
|
|
_vm.NewNodeIdText = "ns=2;s=SomeNode";
|
|
_service.SubscribeException = new Exception("Permission denied");
|
|
|
|
await _vm.AddSubscriptionCommand.ExecuteAsync(null);
|
|
|
|
_vm.ActiveSubscriptions.ShouldBeEmpty();
|
|
_vm.StatusMessage.ShouldNotBeNullOrWhiteSpace();
|
|
_vm.StatusMessage.ShouldContain("Permission denied");
|
|
}
|
|
|
|
/// <summary>
|
|
/// Regression test for Client.UI-006 — silent swallow when adding a subscription for a node
|
|
/// (the context-menu helper) must also surface a status to the operator.
|
|
/// </summary>
|
|
[Fact]
|
|
public async Task AddSubscriptionForNodeAsync_OnFailure_SurfacesStatusMessage()
|
|
{
|
|
_vm.IsConnected = true;
|
|
_service.SubscribeException = new Exception("Bad node id");
|
|
|
|
await _vm.AddSubscriptionForNodeAsync("ns=2;s=ContextMenuNode");
|
|
|
|
_vm.ActiveSubscriptions.ShouldBeEmpty();
|
|
_vm.StatusMessage.ShouldNotBeNullOrWhiteSpace();
|
|
_vm.StatusMessage.ShouldContain("Bad node id");
|
|
}
|
|
|
|
/// <summary>Verifies that AddSubscriptionRecursiveAsync recurses through nested objects.</summary>
|
|
[Fact]
|
|
public async Task AddSubscriptionRecursiveAsync_RecursesNestedObjects()
|
|
{
|
|
_vm.IsConnected = true;
|
|
_service.BrowseResultsByParent["ns=2;s=Root"] =
|
|
[
|
|
new BrowseResult("ns=2;s=SubFolder", "SubFolder", "Object", true),
|
|
new BrowseResult("ns=2;s=RootVar", "RootVar", "Variable", false)
|
|
];
|
|
_service.BrowseResultsByParent["ns=2;s=SubFolder"] =
|
|
[
|
|
new BrowseResult("ns=2;s=DeepVar", "DeepVar", "Variable", false)
|
|
];
|
|
|
|
await _vm.AddSubscriptionRecursiveAsync("ns=2;s=Root", "Object");
|
|
|
|
_vm.ActiveSubscriptions.Count.ShouldBe(2);
|
|
_vm.ActiveSubscriptions.ShouldContain(s => s.NodeId == "ns=2;s=RootVar");
|
|
_vm.ActiveSubscriptions.ShouldContain(s => s.NodeId == "ns=2;s=DeepVar");
|
|
}
|
|
} |