lmxopcua

Files

Joseph Doherty 99354bfaf2 fix(core-scripted-alarms): resolve Low code-review findings (Core.ScriptedAlarms-003,006,008,010,011; -009 documented)

- Core.ScriptedAlarms-003: emit OnEvent OUTSIDE _evalGate by collecting
  pending emissions during the gate-held section and flushing them after
  release; eliminates re-entrancy deadlock the docs already promised.
- Core.ScriptedAlarms-006: track every fire-and-forget Reevaluate /
  ShelvingCheck task in _inFlight; Dispose drains the set so the engine
  no longer races store writes against teardown.
- Core.ScriptedAlarms-008: store comments as ImmutableList<AlarmComment>
  so AppendComment is O(log n) instead of O(n).
- Core.ScriptedAlarms-010: document the deliberate input-quality
  asymmetry (Uncertain drives the predicate, renders {?} in the message)
  in docs/ScriptedAlarms.md and on MessageTemplate.Resolve remarks.
- Core.ScriptedAlarms-011: propagate the no-op reason through
  TransitionResult.NoOp(state, reason) and log it from
  ScriptedAlarmEngine.ApplyAsync.
- Core.ScriptedAlarms-009 (Won't Fix per recommendation): documented the
  per-evaluation dictionary allocation in docs/v2/Galaxy.Performance.md
  with a mitigation path if a future soak surfaces pressure.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-05-23 07:23:31 -04:00

ZB.MOM.WW.OtOpcUa.Configuration.Tests

fix(configuration): resolve Low code-review findings (Configuration-004,005,007,010,011)

2026-05-23 05:38:18 -04:00

ZB.MOM.WW.OtOpcUa.Core.Abstractions.Tests

fix(core-abstractions): resolve Low code-review findings (Core.Abstractions-004,005,006,007,008)

2026-05-23 05:37:54 -04:00

ZB.MOM.WW.OtOpcUa.Core.AlarmHistorian.Tests

fix(core-alarm-historian): resolve Low code-review findings (Core.AlarmHistorian-008,011)

2026-05-23 05:38:26 -04:00

ZB.MOM.WW.OtOpcUa.Core.ScriptedAlarms.Tests

fix(core-scripted-alarms): resolve Low code-review findings (Core.ScriptedAlarms-003,006,008,010,011; -009 documented)