Files
lmxopcua/docs/ui-consistency/evidence/ot13-collection-inline

OT-13 inline collection editor acceptance

CollectionEditor now renders a named inline edit group within the existing driver dialog. It creates no second backdrop, modal, focus trap or native Escape owner. Local Save commits the cloned working row into the parent draft; Cancel discards it. The existing outer driver Save remains the persistent configuration action. Parent Escape closes that outer dialog and discards the uncommitted local row, with the existing invoker restoration.

Preserved contracts and corrections

Public parameter declarations are unchanged. NewRow/Clone/Validate, mutable List ownership, default rows and OPC UA serializer/URL validation remain. The sole current production consumer is unchanged OpcUaClientDriverForm. The editor captures its list, row identity, cloned working copy, validation/template and ItemsChanged callback. Target/callback replacement and disposal retire old handlers; queued A Save/Cancel cannot commit/close B. Delete resolves its original row rather than a captured index after reorder. A removed original cannot overwrite a different row.

Local notifications are single-flight. Already committed originating A draft notifications continue, but old success/exception cleanup cannot unlock B; current notification errors retain propagation. This does not claim to guard arbitrary caller code inside its own awaited callback. Current anchors return to the originating Edit/Add control (including a newly rendered row after replacement); heading/error focus remains inside the parent dialog. Removed-row recovery falls back to Add. No shared JS/package/API/schema/auth change.

The actual expanded OPC UA form also reproduced lost parent chrome: at1440 the header y=-224/footer bottom2539 exceeded the900px viewport;390 was likewise outside. DriverConfigModal receives only the existing modal-dialog-scrollable class. Its entire @code body remains byte-identical. Final header/footer geometry fits1440/390 and actual200%720/195 viewports.

Verification

  • baseline.log/baseline.trx:3valid behavior failures and1positive before production edits: legacy nested shell, captured A Save committing B, reordered Delete targeting the wrong row. Actual rendered callbacks are captured before retirement; this is not a stale bUnit event-ID test.
  • acceptance.log/acceptance.trx:24passed/0skipped, comprising9new lifecycle cases plus15existing OPC UA serialization cases. Covers clone/cancel/validation, captured Save/Cancel, reordered/removed rows, pending A/B callback success+exception and actual disposal. The earlier expanded23pass/1failure was a dispatcher misuse in the disposal test; retained and corrected by invoking its captured callback on the renderer, without a production change.
  • Native browser-confirmation.log/browser-results.json:4actual DriverConfigModal > OpcUaClientDriverForm > CollectionEditor scenes,14checks each at1440/390 and real Chromium200%720/195 CSS pixels/DPR2. Names/relationships, one dialog/backdrop, heading/error focus, clone discard, Add/Edit/Delete draft-only behavior, exact trigger return, one captured parent write, preserved endpoint URL list/scalar ownership, outer Escape/discard/reopen, fixed parent chrome, no document overflow or page errors all pass. The fake service accepts only fixture driver read/update; no device, probe, broker, database or real fleet operation.
  • Native first run retained a harness timeout seeking parent Save rather than the real Save changes label; earlier local assertions had passed. Correcting that selector did not change production save behavior. chrome-before.json and two actual CDP captures retain the separate measured geometry defect; the one-class parent correction is explicit.
  • Actual viewport PNGs use direct CDP fromSurface=true/captureBeyondViewport=false, including native zoom. Root visually inspected the195px invalid view; full identity and parent footer remain available while the body scrolls.
  • Initial fixture build had one nullable fixture cast error (initial-fixture-nullability.log), fixed with explicit type matching; corrected/final Release builds have0warnings/errors.
  • source-boundaries.json records exact production/test hashes, unchanged public parameters, parent code parity and exact served/source frozen dialog-focus module bytes. Primary independently reviewed source and final test/native evidence without a blocker.

All dotnet tests used the private SQL environment runner; this focused filter does not claim to execute the SQL collections. The owned loopback18143 runtime is stopped (cleanup.json); shared private SQL, other canaries and existing rigs were untouched. VoiceOver testing is excluded by the user. Final whole-consumer acceptance remains the primary OT-14 gate.