Joseph Doherty
8b2c3fa04c
- Rename FocasEquipmentTagParser -> FocasTagDefinitionFactory; TryParse ->
FromTagConfig(tagConfig, rawPath, out def). Drop leading-{ heuristic + the
deviceHostAddress blob key; def.Name = rawPath. Add inverse ToTagConfig.
writable: absent -> read-only, explicit true honoured (note preserved).
- FocasDriverOptions.Tags -> RawTags (IReadOnlyList<RawTagEntry>).
- FocasDriver: _tagsByRawPath (Ordinal); byName-only resolver; build table from
RawTags via FromTagConfig; multi-device routing threads RawTagEntry.DeviceName
-> ResolveDeviceHost match against options.Devices -> def.DeviceHostAddress
(TODO v3 WaveC: live host from Device row DeviceConfig). Tolerant per-tag
skip+log (mapper/address/matrix miss -> BadNodeIdUnknown); unknown device
fails init fast.
- Factory: bind List<RawTagEntry> RawTags; retire FocasTagDto/ParseDataType.
- CLI FocasCommandBase.BuildOptions -> RawTags via ToTagConfig + DeviceName.
- Tests: FocasRawTags helper; migrate Tags= -> RawTags=; rename parser tests to
FromTagConfig; rewrite retired blob-ref tests (equipment-tag/capability-gate/
resolve-host) onto authored RawPath. 272 driver + 52 CLI green.
61 lines
2.5 KiB
C#
61 lines
2.5 KiB
C#
using Shouldly;
|
|
using Xunit;
|
|
using ZB.MOM.WW.OtOpcUa.Core.Abstractions;
|
|
using ZB.MOM.WW.OtOpcUa.Driver.FOCAS;
|
|
|
|
namespace ZB.MOM.WW.OtOpcUa.Driver.FOCAS.Tests;
|
|
|
|
/// <summary>
|
|
/// 05/STAB-9 — the poll engine's <c>onError</c> sink must be wired to the driver health
|
|
/// surface: a poll-loop reader failure degrades health while preserving
|
|
/// <see cref="DriverHealth.LastSuccessfulRead"/>, and must never downgrade a pre-existing
|
|
/// <see cref="DriverState.Faulted"/>.
|
|
/// </summary>
|
|
[Trait("Category", "Unit")]
|
|
public sealed class FocasPollErrorHealthTests
|
|
{
|
|
/// <summary>A poll reader failure degrades health, preserving the last successful read timestamp.</summary>
|
|
[Fact]
|
|
public async Task PollReaderFailure_DegradesHealth_PreservesLastSuccessfulRead()
|
|
{
|
|
var drv = new FocasDriver(new FocasDriverOptions
|
|
{
|
|
Devices = [new FocasDeviceOptions("focas://10.0.0.5:8193")],
|
|
Probe = new FocasProbeOptions { Enabled = false },
|
|
}, "focas-1", new FakeFocasClientFactory());
|
|
await drv.InitializeAsync("{}", CancellationToken.None);
|
|
|
|
var before = drv.GetHealth();
|
|
before.State.ShouldBe(DriverState.Healthy);
|
|
before.LastSuccessfulRead.ShouldNotBeNull();
|
|
|
|
drv.HandlePollError(new InvalidOperationException("poll boom"));
|
|
|
|
var after = drv.GetHealth();
|
|
after.State.ShouldBe(DriverState.Degraded);
|
|
after.LastSuccessfulRead.ShouldBe(before.LastSuccessfulRead);
|
|
after.LastError.ShouldNotBeNull();
|
|
after.LastError.ShouldContain("poll boom");
|
|
}
|
|
|
|
/// <summary>A poll reader failure never downgrades a pre-existing Faulted state.</summary>
|
|
[Fact]
|
|
public async Task PollReaderFailure_NeverDowngradesFaulted()
|
|
{
|
|
var drv = new FocasDriver(new FocasDriverOptions
|
|
{
|
|
Devices = [new FocasDeviceOptions("focas://10.0.0.5:8193")],
|
|
// DeviceName "…:9999" is not in Devices → InitializeAsync fails fast → Faulted.
|
|
RawTags = [FocasRawTags.Entry(new FocasTagDefinition("X", "focas://10.0.0.5:9999", "R100", FocasDataType.Byte))],
|
|
Probe = new FocasProbeOptions { Enabled = false },
|
|
}, "focas-1", new FakeFocasClientFactory());
|
|
|
|
await Should.ThrowAsync<Exception>(() => drv.InitializeAsync("{}", CancellationToken.None));
|
|
drv.GetHealth().State.ShouldBe(DriverState.Faulted);
|
|
|
|
drv.HandlePollError(new InvalidOperationException("poll boom"));
|
|
|
|
drv.GetHealth().State.ShouldBe(DriverState.Faulted);
|
|
}
|
|
}
|