Joseph Doherty
1ea1da8236
Since #516 a DriverConfig change is stop + respawn, so DriverSpawnPlan.ToApplyDelta was always empty and the in-place path had no producer. #663 and #664 were both latent bugs in it. This deletes it: - host: ApplyChildDelta, _pendingDelta, HandleApplyResult and HandleDeltaApplied - plan: DriverSpawnPlan.ToApplyDelta - actor: the ApplyDelta, ApplyResult and DeltaApplied messages, the Connected reinit handler and the mid-connect AdoptConfigDuringInit - tests: the actor tests that drove the seam IDriver.ReinitializeAsync and each driver's implementation and unit tests stay. Comments and docs that cited AdoptConfigDuringInit as the reason a driver must release prior state at init now cite the IDriver contract and overlapping retries, which still apply. Claude-Session: https://claude.ai/code/session_01Ef2ozxS7QPanGT8uoATbTe
59 lines
2.4 KiB
C#
59 lines
2.4 KiB
C#
using Shouldly;
|
|
using Xunit;
|
|
using ZB.MOM.WW.OtOpcUa.Driver.FOCAS;
|
|
|
|
namespace ZB.MOM.WW.OtOpcUa.Driver.FOCAS.Tests;
|
|
|
|
/// <summary>
|
|
/// #630 — <c>InitializeAsync</c> on a live driver with no teardown first (the <c>IDriver</c> contract
|
|
/// allows it) overwrote <c>_devices[host]</c> and orphaned the previous state's
|
|
/// probe loop + client. It now releases them first.
|
|
/// </summary>
|
|
[Trait("Category", "Unit")]
|
|
public sealed class FocasReinitializeReleasesStateTests
|
|
{
|
|
/// <summary>Initialize twice: the first state's probe loop has finished and its client is disposed.</summary>
|
|
[Fact]
|
|
public async Task SecondInitialize_StopsFirstStatesLoop_AndDisposesItsClient()
|
|
{
|
|
const string host = "focas://10.0.0.5:8193";
|
|
var factory = new FakeFocasClientFactory();
|
|
var options = new FocasDriverOptions
|
|
{
|
|
Devices = [new FocasDeviceOptions(host)],
|
|
RawTags = [FocasRawTags.Entry(new FocasTagDefinition("R", host, "R100", FocasDataType.Byte))],
|
|
Probe = new FocasProbeOptions { Enabled = true, Interval = TimeSpan.FromMilliseconds(20), Timeout = TimeSpan.FromSeconds(2) },
|
|
};
|
|
var drv = new FocasDriver(options, "focas-reinit", factory);
|
|
await drv.InitializeAsync("{}", CancellationToken.None);
|
|
|
|
var first = drv.GetDeviceState(host)!;
|
|
// Positive control: the first state's probe loop is demonstrably running and holds a live client.
|
|
await WaitUntilAsync(() => factory.Clients.Count > 0 && factory.Clients[0].IsConnected);
|
|
var firstLoop = first.ProbeTask;
|
|
firstLoop.ShouldNotBeNull();
|
|
firstLoop!.IsCompleted.ShouldBeFalse();
|
|
var firstClient = factory.Clients[0];
|
|
|
|
await drv.InitializeAsync("{}", CancellationToken.None);
|
|
|
|
firstLoop.IsCompleted.ShouldBeTrue(); // joined
|
|
firstClient.DisposeCount.ShouldBeGreaterThanOrEqualTo(1);
|
|
firstClient.IsConnected.ShouldBeFalse();
|
|
drv.GetDeviceState(host).ShouldNotBeSameAs(first);
|
|
drv.GetDeviceState(host)!.ProbeTask.ShouldNotBeNull(); // the new state is running
|
|
|
|
await drv.ShutdownAsync(CancellationToken.None);
|
|
}
|
|
|
|
private static async Task WaitUntilAsync(Func<bool> cond)
|
|
{
|
|
var deadline = DateTime.UtcNow.AddSeconds(5);
|
|
while (!cond())
|
|
{
|
|
if (DateTime.UtcNow > deadline) throw new TimeoutException("condition not met");
|
|
await Task.Delay(10);
|
|
}
|
|
}
|
|
}
|