Files
lmxopcua/tests/ZB.MOM.WW.OtOpcUa.Client.UI.Tests/ReadWriteViewModelTests.cs
Joseph Doherty 3b2defd94f Phase 0 — mechanical rename ZB.MOM.WW.LmxOpcUa.* → ZB.MOM.WW.OtOpcUa.*
Renames all 11 projects (5 src + 6 tests), the .slnx solution file, all source-file namespaces, all axaml namespace references, and all v1 documentation references in CLAUDE.md and docs/*.md (excluding docs/v2/ which is already in OtOpcUa form). Also updates the TopShelf service registration name from "LmxOpcUa" to "OtOpcUa" per Phase 0 Task 0.6.

Preserves runtime identifiers per Phase 0 Out-of-Scope rules to avoid breaking v1/v2 client trust during coexistence: OPC UA `ApplicationUri` defaults (`urn:{GalaxyName}:LmxOpcUa`), server `EndpointPath` (`/LmxOpcUa`), `ServerName` default (feeds cert subject CN), `MxAccessConfiguration.ClientName` default (defensive — stays "LmxOpcUa" for MxAccess audit-trail consistency), client OPC UA identifiers (`ApplicationName = "LmxOpcUaClient"`, `ApplicationUri = "urn:localhost:LmxOpcUaClient"`, cert directory `%LocalAppData%\LmxOpcUaClient\pki\`), and the `LmxOpcUaServer` class name (class rename out of Phase 0 scope per Task 0.5 sed pattern; happens in Phase 1 alongside `LmxNodeManager → GenericDriverNodeManager` Core extraction). 23 LmxOpcUa references retained, all enumerated and justified in `docs/v2/implementation/exit-gate-phase-0.md`.

Build clean: 0 errors, 30 warnings (lower than baseline 167). Tests at strict improvement over baseline: 821 passing / 1 failing vs baseline 820 / 2 (one flaky pre-existing failure passed this run; the other still fails — both pre-existing and unrelated to the rename). `Client.UI.Tests`, `Historian.Aveva.Tests`, `Client.Shared.Tests`, `IntegrationTests` all match baseline exactly. Exit gate compliance results recorded in `docs/v2/implementation/exit-gate-phase-0.md` with all 7 checks PASS or DEFERRED-to-PR-review (#7 service install verification needs Windows service permissions on the reviewer's box).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-17 13:57:47 -04:00

152 lines
4.3 KiB
C#

using Opc.Ua;
using Shouldly;
using Xunit;
using ZB.MOM.WW.OtOpcUa.Client.UI.Services;
using ZB.MOM.WW.OtOpcUa.Client.UI.Tests.Fakes;
using ZB.MOM.WW.OtOpcUa.Client.UI.ViewModels;
namespace ZB.MOM.WW.OtOpcUa.Client.UI.Tests;
public class ReadWriteViewModelTests
{
private readonly FakeOpcUaClientService _service;
private readonly ReadWriteViewModel _vm;
public ReadWriteViewModelTests()
{
_service = new FakeOpcUaClientService
{
ReadResult = new DataValue(new Variant("TestValue"), StatusCodes.Good, DateTime.UtcNow, DateTime.UtcNow)
};
var dispatcher = new SynchronousUiDispatcher();
_vm = new ReadWriteViewModel(_service, dispatcher);
}
[Fact]
public void ReadCommand_CannotExecute_WhenDisconnected()
{
_vm.IsConnected = false;
_vm.SelectedNodeId = "ns=2;s=SomeNode";
_vm.ReadCommand.CanExecute(null).ShouldBeFalse();
}
[Fact]
public void ReadCommand_CannotExecute_WhenNoNodeSelected()
{
_vm.IsConnected = true;
_vm.SelectedNodeId = null;
_vm.ReadCommand.CanExecute(null).ShouldBeFalse();
}
[Fact]
public void ReadCommand_CanExecute_WhenConnectedAndNodeSelected()
{
_vm.IsConnected = true;
_vm.SelectedNodeId = "ns=2;s=SomeNode";
_vm.ReadCommand.CanExecute(null).ShouldBeTrue();
}
[Fact]
public async Task ReadCommand_UpdatesValueAndStatus()
{
_vm.IsConnected = true;
_vm.SelectedNodeId = "ns=2;s=SomeNode";
// auto-read fires on selection change, so reset count
var countBefore = _service.ReadCallCount;
await _vm.ReadCommand.ExecuteAsync(null);
_vm.CurrentValue.ShouldBe("TestValue");
_vm.CurrentStatus.ShouldNotBeNull();
_vm.SourceTimestamp.ShouldNotBeNull();
_vm.ServerTimestamp.ShouldNotBeNull();
(_service.ReadCallCount - countBefore).ShouldBe(1);
}
[Fact]
public void AutoRead_OnSelectionChange_WhenConnected()
{
_vm.IsConnected = true;
_vm.SelectedNodeId = "ns=2;s=SomeNode";
// The auto-read fires asynchronously; give it a moment
// In synchronous dispatcher it should fire immediately
_service.ReadCallCount.ShouldBeGreaterThanOrEqualTo(1);
}
[Fact]
public void NullSelection_DoesNotCallService()
{
_vm.IsConnected = true;
_vm.SelectedNodeId = null;
_service.ReadCallCount.ShouldBe(0);
}
[Fact]
public async Task WriteCommand_UpdatesWriteStatus()
{
_vm.IsConnected = true;
_vm.SelectedNodeId = "ns=2;s=SomeNode";
_vm.WriteValue = "NewValue";
// Reset read count from auto-read
var readCountBefore = _service.ReadCallCount;
await _vm.WriteCommand.ExecuteAsync(null);
_vm.WriteStatus.ShouldNotBeNull();
_service.WriteCallCount.ShouldBe(1);
_service.LastWriteValue.ShouldBe("NewValue");
}
[Fact]
public void WriteCommand_CannotExecute_WhenDisconnected()
{
_vm.IsConnected = false;
_vm.SelectedNodeId = "ns=2;s=SomeNode";
_vm.WriteCommand.CanExecute(null).ShouldBeFalse();
}
[Fact]
public async Task ReadCommand_Error_SetsErrorStatus()
{
_service.ReadException = new Exception("Read failed");
_vm.IsConnected = true;
// We need to set SelectedNodeId and manually trigger read
// because auto-read catches the exception too
_vm.SelectedNodeId = "ns=2;s=SomeNode";
_vm.CurrentStatus.ShouldContain("Error");
}
[Fact]
public void Clear_ResetsAllProperties()
{
_vm.IsConnected = true;
_vm.SelectedNodeId = "ns=2;s=SomeNode";
_vm.WriteValue = "test";
_vm.WriteStatus = "Good";
_vm.Clear();
_vm.SelectedNodeId.ShouldBeNull();
_vm.CurrentValue.ShouldBeNull();
_vm.CurrentStatus.ShouldBeNull();
_vm.SourceTimestamp.ShouldBeNull();
_vm.ServerTimestamp.ShouldBeNull();
_vm.WriteValue.ShouldBeNull();
_vm.WriteStatus.ShouldBeNull();
}
[Fact]
public void IsNodeSelected_TracksSelectedNodeId()
{
_vm.IsNodeSelected.ShouldBeFalse();
_vm.SelectedNodeId = "ns=2;s=SomeNode";
_vm.IsNodeSelected.ShouldBeTrue();
_vm.SelectedNodeId = null;
_vm.IsNodeSelected.ShouldBeFalse();
}
}