Joseph Doherty
ae91e6b7f7
#816 finding: the SDK checks that the server certificate names the host only when a session is created with checkDomain:true. The driver, the AdminUI browser and Client.Shared all called the 8-argument DefaultSessionFactory.CreateAsync, which forwards checkDomain:false — so no host-name check ever ran (why a trusted NAT cert for *.invalid browsed fine over an IP in #813). When enabled the SDK (Session.OpenAsync -> ValidateDomains -> FindDomain) compares ConfiguredEndpoint.EndpointUrl.IdnHost — the CONFIGURED host, because OpcUaEndpointSelection/EndpointSelector rewrote the advertised one — against the cert's DNS/IP SANs; secured sessions only, and the auto-accept handler accepts a mismatch. Policy: certificateValidation.validateServerHostName, tri-state. Unset = OpcUaCertificateValidationOptions.DefaultValidateServerHostName = false, the pre-#816 behaviour, so nothing changes on upgrade; true = validate the configured host; false = explicit NAT/port-publish opt-out. Threaded into the driver, the AdminUI browser (same JSON) and the AdminUI form (a select that keeps "unset" unset), Client.Shared ConnectionSettings.ValidateServerHostName and the CLI --validate-host-name. A driver refusal names the opt-out. #818: the NAT fixture's /app/pki is on the opc-plc-nat-pki volume (verified: same thumbprint across --force-recreate), its PUBLIC cert is committed as Docker/nat/opc-plc-nat-server.der, and NatPublishedEndpointBrowseTests run every secure browse on a throwaway PKI (internal browser seam): refusal with nothing trusted, positive with the cert trusted (unset/false host check), and a BadCertificateHostNameInvalid refusal with the check on. The trusted cert is OPCUA_NAT_SERVER_CERT or the committed one (skip on thumbprint mismatch); OPCUA_NAT_SERVER_CERT_TRUSTED is retired. CI exports its throwaway NAT container's public cert. ServerHostNameValidationTests pin the driver against the plain opc-plc. MIN_EXECUTED not raised (needs a hosted run): +6 in v2-integration (440 -> 446), documented in scripts/ci/README.md.
31 lines
1.2 KiB
C#
31 lines
1.2 KiB
C#
using Opc.Ua;
|
|
|
|
namespace ZB.MOM.WW.OtOpcUa.Client.Shared.Adapters;
|
|
|
|
/// <summary>
|
|
/// Creates OPC UA sessions from a configured endpoint.
|
|
/// </summary>
|
|
internal interface ISessionFactory
|
|
{
|
|
/// <summary>
|
|
/// Creates a session to the given endpoint.
|
|
/// </summary>
|
|
/// <param name="config">The application configuration.</param>
|
|
/// <param name="endpoint">The configured endpoint.</param>
|
|
/// <param name="sessionName">The session name.</param>
|
|
/// <param name="sessionTimeoutMs">Session timeout in milliseconds.</param>
|
|
/// <param name="identity">The user identity.</param>
|
|
/// <param name="validateServerHostName">
|
|
/// The SDK's <c>checkDomain</c>: require the server certificate to name the endpoint URL's host (#816).
|
|
/// </param>
|
|
/// <param name="ct">Cancellation token.</param>
|
|
/// <returns>A session adapter wrapping the created session.</returns>
|
|
Task<ISessionAdapter> CreateSessionAsync(
|
|
ApplicationConfiguration config,
|
|
EndpointDescription endpoint,
|
|
string sessionName,
|
|
uint sessionTimeoutMs,
|
|
UserIdentity identity,
|
|
bool validateServerHostName,
|
|
CancellationToken ct = default);
|
|
} |