Joseph Doherty
1f172e55f7
Adds ConfirmAlarmAsync and ShelveAlarmAsync to IOpcUaClientService and OpcUaClientService (mirroring the AcknowledgeAlarmAsync pattern: same CallMethodAsync/ServiceResultException/StatusCode contract). Adds ShelveKind enum (OneShot/Timed/Unshelve). Adds three new CLI commands — ack, confirm, shelve — with hex EventId input and per-command argument validation. Updates both fakes (CLI + UI) to implement the new interface members and record calls. Adds 16 unit tests covering argument mapping, invalid-input CommandException paths, bad-status output, and disconnect-in-finally.
107 lines
3.8 KiB
C#
107 lines
3.8 KiB
C#
using CliFx.Exceptions;
|
|
using Opc.Ua;
|
|
using Shouldly;
|
|
using Xunit;
|
|
using ZB.MOM.WW.OtOpcUa.Client.CLI.Commands;
|
|
using ZB.MOM.WW.OtOpcUa.Client.CLI.Tests.Fakes;
|
|
|
|
namespace ZB.MOM.WW.OtOpcUa.Client.CLI.Tests;
|
|
|
|
public class ConfirmCommandTests
|
|
{
|
|
private static string HexOf(byte[] bytes) => Convert.ToHexString(bytes);
|
|
|
|
/// <summary>Verifies that a successful confirm prints a success message and passes correct arguments to the service.</summary>
|
|
[Fact]
|
|
public async Task Execute_Success_PrintsSuccessMessage()
|
|
{
|
|
var fakeService = new FakeOpcUaClientService
|
|
{
|
|
ConfirmAlarmResult = StatusCodes.Good
|
|
};
|
|
var factory = new FakeOpcUaClientServiceFactory(fakeService);
|
|
var eventId = new byte[] { 0x0A, 0x1B, 0x2C };
|
|
var command = new ConfirmCommand(factory)
|
|
{
|
|
Url = "opc.tcp://localhost:4840",
|
|
NodeId = "ns=2;s=MyAlarm",
|
|
EventId = HexOf(eventId),
|
|
Comment = "confirmed by operator"
|
|
};
|
|
|
|
using var console = TestConsoleHelper.CreateConsole();
|
|
await command.ExecuteAsync(console);
|
|
|
|
var output = TestConsoleHelper.GetOutput(console);
|
|
output.ShouldContain("Confirm successful");
|
|
fakeService.ConfirmAlarmCalls.Count.ShouldBe(1);
|
|
fakeService.ConfirmAlarmCalls[0].ConditionNodeId.ShouldBe("ns=2;s=MyAlarm");
|
|
fakeService.ConfirmAlarmCalls[0].EventId.ShouldBe(eventId);
|
|
fakeService.ConfirmAlarmCalls[0].Comment.ShouldBe("confirmed by operator");
|
|
}
|
|
|
|
/// <summary>Verifies that a bad StatusCode from the service prints a failure message.</summary>
|
|
[Fact]
|
|
public async Task Execute_BadStatus_PrintsFailureMessage()
|
|
{
|
|
var fakeService = new FakeOpcUaClientService
|
|
{
|
|
ConfirmAlarmResult = StatusCodes.BadConditionBranchAlreadyConfirmed
|
|
};
|
|
var factory = new FakeOpcUaClientServiceFactory(fakeService);
|
|
var command = new ConfirmCommand(factory)
|
|
{
|
|
Url = "opc.tcp://localhost:4840",
|
|
NodeId = "ns=2;s=MyAlarm",
|
|
EventId = HexOf(new byte[] { 0xFF }),
|
|
Comment = ""
|
|
};
|
|
|
|
using var console = TestConsoleHelper.CreateConsole();
|
|
await command.ExecuteAsync(console);
|
|
|
|
var output = TestConsoleHelper.GetOutput(console);
|
|
output.ShouldContain("Confirm failed");
|
|
}
|
|
|
|
/// <summary>Verifies that an invalid hex event-id throws CommandException.</summary>
|
|
[Fact]
|
|
public async Task Execute_InvalidEventId_ThrowsCommandException()
|
|
{
|
|
var fakeService = new FakeOpcUaClientService();
|
|
var factory = new FakeOpcUaClientServiceFactory(fakeService);
|
|
var command = new ConfirmCommand(factory)
|
|
{
|
|
Url = "opc.tcp://localhost:4840",
|
|
NodeId = "ns=2;s=MyAlarm",
|
|
EventId = "ZZZ-not-hex",
|
|
Comment = ""
|
|
};
|
|
|
|
using var console = TestConsoleHelper.CreateConsole();
|
|
var ex = await Should.ThrowAsync<CommandException>(async () => await command.ExecuteAsync(console));
|
|
ex.Message.ShouldContain("event-id", Case.Insensitive);
|
|
}
|
|
|
|
/// <summary>Verifies that the command disconnects in the finally block.</summary>
|
|
[Fact]
|
|
public async Task Execute_DisconnectsInFinally()
|
|
{
|
|
var fakeService = new FakeOpcUaClientService();
|
|
var factory = new FakeOpcUaClientServiceFactory(fakeService);
|
|
var command = new ConfirmCommand(factory)
|
|
{
|
|
Url = "opc.tcp://localhost:4840",
|
|
NodeId = "ns=2;s=MyAlarm",
|
|
EventId = HexOf(new byte[] { 0x01 }),
|
|
Comment = ""
|
|
};
|
|
|
|
using var console = TestConsoleHelper.CreateConsole();
|
|
await command.ExecuteAsync(console);
|
|
|
|
fakeService.DisconnectCalled.ShouldBeTrue();
|
|
fakeService.DisposeCalled.ShouldBeTrue();
|
|
}
|
|
}
|