CLAUDE.md "Docker Workflow" claims (per the 2026-04-28 migration note)
that all fixture-class default endpoints were rewritten to target the
shared Docker host at 10.100.0.35. Audit during today's e2e run showed
the claim was incomplete — five fixture classes still defaulted to
localhost / 127.0.0.1, causing every fixture-touching integration test
to skip with "endpoint unreachable" on a fresh box that hadn't set
the override env vars.
Files corrected:
- tests/.../Modbus.IntegrationTests/ModbusSimulatorFixture.cs
DefaultEndpoint: localhost:5020 → 10.100.0.35:5020
- tests/.../S7.IntegrationTests/Snap7ServerFixture.cs
DefaultEndpoint: localhost:1102 → 10.100.0.35:1102
- tests/.../OpcUaClient.IntegrationTests/OpcPlcFixture.cs
DefaultEndpoint: opc.tcp://localhost:50000 → opc.tcp://10.100.0.35:50000
- tests/.../AbCip.IntegrationTests/AbServerFixture.cs
Host default + ResolveHost fallback: 127.0.0.1 → 10.100.0.35
- tests/.../AbLegacy.IntegrationTests/AbLegacyServerFixture.cs
Host default + ResolveEndpoint fallback: 127.0.0.1 → 10.100.0.35
XML doc comments referencing the old localhost defaults were updated in
the same pass so the class-summary documentation matches the actual
default. The override-via-env-var mechanism (MODBUS_SIM_ENDPOINT,
AB_SERVER_ENDPOINT, AB_LEGACY_ENDPOINT, S7_SIM_ENDPOINT,
OPCUA_SIM_ENDPOINT) is unchanged — pointing at a real PLC or a
locally-running container still works exactly as before.
Verification:
- Solution-wide dotnet build: 0 errors.
- S7.IntegrationTests: 3/3 pass without env-var override.
- OpcUaClient.IntegrationTests: 3/3 pass without env-var override.
- Modbus.IntegrationTests: 4/38 (same as the env-var-override run —
the 2 failures + 32 skips are pre-existing fixture-profile
mismatches unrelated to this fix).
- AbCip.IntegrationTests / AbLegacy.IntegrationTests: same results
as the env-var-override run.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
120 lines
5.1 KiB
C#
120 lines
5.1 KiB
C#
using System.Net.Sockets;
|
|
using Xunit;
|
|
using Xunit.Sdk;
|
|
|
|
namespace ZB.MOM.WW.OtOpcUa.Driver.AbCip.IntegrationTests;
|
|
|
|
/// <summary>
|
|
/// Reachability probe for the <c>ab_server</c> Docker container (libplctag's CIP
|
|
/// simulator built via <c>Docker/Dockerfile</c>) or any real AB PLC the
|
|
/// <c>AB_SERVER_ENDPOINT</c> env var points at. Parses
|
|
/// <c>AB_SERVER_ENDPOINT</c> (default <c>10.100.0.35:44818</c> — the shared Docker host) + TCP-connects
|
|
/// once at fixture construction. Tests skip via <see cref="AbServerFactAttribute"/>
|
|
/// / <see cref="AbServerTheoryAttribute"/> when the port isn't live, so
|
|
/// <c>dotnet test</c> stays green on a fresh clone without Docker running.
|
|
/// Matches the <see cref="ModbusSimulatorFixture"/> / <c>Snap7ServerFixture</c> /
|
|
/// <c>OpcPlcFixture</c> shape.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// Docker is the only supported launch path — no native-binary spawn + no
|
|
/// PATH lookup. Bring the container up before <c>dotnet test</c>:
|
|
/// <c>docker compose -f Docker/docker-compose.yml --profile controllogix up</c>.
|
|
/// </remarks>
|
|
public sealed class AbServerFixture : IAsyncLifetime
|
|
{
|
|
private const string EndpointEnvVar = "AB_SERVER_ENDPOINT";
|
|
|
|
/// <summary>The profile this fixture instance represents. Parallel family smoke tests
|
|
/// instantiate the fixture with the profile matching their compose-file service.</summary>
|
|
public AbServerProfile Profile { get; }
|
|
|
|
// 10.100.0.35 = the shared Docker host (see CLAUDE.md "Docker Workflow"). Migrated
|
|
// off this VM's 127.0.0.1 on 2026-04-28 alongside the rest of the Docker-host move.
|
|
// Override via AB_SERVER_ENDPOINT to point at a real PLC or a locally-running container.
|
|
public string Host { get; } = "10.100.0.35";
|
|
public int Port { get; } = AbServerProfile.DefaultPort;
|
|
|
|
public AbServerFixture() : this(KnownProfiles.ControlLogix) { }
|
|
|
|
public AbServerFixture(AbServerProfile profile)
|
|
{
|
|
Profile = profile ?? throw new ArgumentNullException(nameof(profile));
|
|
|
|
// Endpoint override applies to both host + port — targeting a real PLC at
|
|
// non-default host or port shouldn't need fixture changes.
|
|
if (Environment.GetEnvironmentVariable(EndpointEnvVar) is { Length: > 0 } raw)
|
|
{
|
|
var parts = raw.Split(':', 2);
|
|
Host = parts[0];
|
|
if (parts.Length == 2 && int.TryParse(parts[1], out var p)) Port = p;
|
|
}
|
|
}
|
|
|
|
public ValueTask InitializeAsync() => ValueTask.CompletedTask;
|
|
public ValueTask DisposeAsync() => ValueTask.CompletedTask;
|
|
|
|
/// <summary>
|
|
/// <c>true</c> when ab_server is reachable at this fixture's Host/Port. Used by
|
|
/// <see cref="AbServerFactAttribute"/> / <see cref="AbServerTheoryAttribute"/>
|
|
/// to decide whether to skip tests on a fresh clone without a running container.
|
|
/// </summary>
|
|
public static bool IsServerAvailable() =>
|
|
TcpProbe(ResolveHost(), ResolvePort());
|
|
|
|
private static string ResolveHost() =>
|
|
Environment.GetEnvironmentVariable(EndpointEnvVar)?.Split(':', 2)[0] ?? "10.100.0.35";
|
|
|
|
private static int ResolvePort()
|
|
{
|
|
var raw = Environment.GetEnvironmentVariable(EndpointEnvVar);
|
|
if (raw is null) return AbServerProfile.DefaultPort;
|
|
var parts = raw.Split(':', 2);
|
|
return parts.Length == 2 && int.TryParse(parts[1], out var p) ? p : AbServerProfile.DefaultPort;
|
|
}
|
|
|
|
/// <summary>One-shot TCP probe; 500 ms budget so a missing container fails the probe fast.</summary>
|
|
private static bool TcpProbe(string host, int port)
|
|
{
|
|
try
|
|
{
|
|
using var client = new TcpClient();
|
|
var task = client.ConnectAsync(host, port);
|
|
return task.Wait(TimeSpan.FromMilliseconds(500)) && client.Connected;
|
|
}
|
|
catch { return false; }
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// <c>[Fact]</c>-equivalent that skips when ab_server isn't reachable — accepts a
|
|
/// live Docker listener on <c>10.100.0.35:44818</c> or an <c>AB_SERVER_ENDPOINT</c>
|
|
/// override pointing at a real PLC.
|
|
/// </summary>
|
|
public sealed class AbServerFactAttribute : FactAttribute
|
|
{
|
|
public AbServerFactAttribute()
|
|
{
|
|
if (!AbServerFixture.IsServerAvailable())
|
|
Skip = "ab_server not reachable. Start the Docker container " +
|
|
"(docker compose -f Docker/docker-compose.yml --profile controllogix up) " +
|
|
"or set AB_SERVER_ENDPOINT to a real PLC.";
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// <c>[Theory]</c>-equivalent with the same availability rules as
|
|
/// <see cref="AbServerFactAttribute"/>. Pair with
|
|
/// <c>[MemberData(nameof(KnownProfiles.All))]</c>-style providers to run one theory
|
|
/// row per family.
|
|
/// </summary>
|
|
public sealed class AbServerTheoryAttribute : TheoryAttribute
|
|
{
|
|
public AbServerTheoryAttribute()
|
|
{
|
|
if (!AbServerFixture.IsServerAvailable())
|
|
Skip = "ab_server not reachable. Start the Docker container " +
|
|
"(docker compose -f Docker/docker-compose.yml --profile controllogix up) " +
|
|
"or set AB_SERVER_ENDPOINT to a real PLC.";
|
|
}
|
|
}
|