29e656912e
Driver.AbCip.Cli-001: WriteCommand.ParseValue wraps FormatException/ OverflowException as CommandException so bad --value input yields a clean CLI error instead of a raw stack trace. Driver.AbCip.Cli-002: probe/read/subscribe commands reject Structure types up front (RejectStructure helper), matching the write guard. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
121 lines
3.9 KiB
C#
121 lines
3.9 KiB
C#
using Shouldly;
|
|
using Xunit;
|
|
using ZB.MOM.WW.OtOpcUa.Driver.AbCip.Cli.Commands;
|
|
|
|
namespace ZB.MOM.WW.OtOpcUa.Driver.AbCip.Cli.Tests;
|
|
|
|
/// <summary>
|
|
/// Covers <see cref="WriteCommand.ParseValue"/>. Every Logix atomic type has at least
|
|
/// one happy-path case plus a failure case for unparseable input.
|
|
/// </summary>
|
|
[Trait("Category", "Unit")]
|
|
public sealed class WriteCommandParseValueTests
|
|
{
|
|
[Theory]
|
|
[InlineData("true", true)]
|
|
[InlineData("0", false)]
|
|
[InlineData("on", true)]
|
|
[InlineData("NO", false)]
|
|
public void ParseValue_Bool_accepts_common_aliases(string raw, bool expected)
|
|
{
|
|
WriteCommand.ParseValue(raw, AbCipDataType.Bool).ShouldBe(expected);
|
|
}
|
|
|
|
[Fact]
|
|
public void ParseValue_Bool_rejects_garbage()
|
|
{
|
|
Should.Throw<CliFx.Exceptions.CommandException>(
|
|
() => WriteCommand.ParseValue("maybe", AbCipDataType.Bool));
|
|
}
|
|
|
|
[Fact]
|
|
public void ParseValue_SInt_widens_to_sbyte()
|
|
{
|
|
WriteCommand.ParseValue("-128", AbCipDataType.SInt).ShouldBe((sbyte)-128);
|
|
WriteCommand.ParseValue("127", AbCipDataType.SInt).ShouldBe((sbyte)127);
|
|
}
|
|
|
|
[Fact]
|
|
public void ParseValue_Int_signed_16bit()
|
|
{
|
|
WriteCommand.ParseValue("-32768", AbCipDataType.Int).ShouldBe((short)-32768);
|
|
}
|
|
|
|
[Fact]
|
|
public void ParseValue_DInt_and_Dt_both_land_on_int()
|
|
{
|
|
WriteCommand.ParseValue("42", AbCipDataType.DInt).ShouldBeOfType<int>();
|
|
WriteCommand.ParseValue("1234567", AbCipDataType.Dt).ShouldBeOfType<int>();
|
|
}
|
|
|
|
[Fact]
|
|
public void ParseValue_LInt_64bit()
|
|
{
|
|
WriteCommand.ParseValue("9223372036854775807", AbCipDataType.LInt).ShouldBe(long.MaxValue);
|
|
}
|
|
|
|
[Fact]
|
|
public void ParseValue_unsigned_range_respects_bounds()
|
|
{
|
|
WriteCommand.ParseValue("255", AbCipDataType.USInt).ShouldBeOfType<byte>();
|
|
WriteCommand.ParseValue("65535", AbCipDataType.UInt).ShouldBeOfType<ushort>();
|
|
WriteCommand.ParseValue("4294967295", AbCipDataType.UDInt).ShouldBeOfType<uint>();
|
|
}
|
|
|
|
[Fact]
|
|
public void ParseValue_Real_invariant_culture_decimal()
|
|
{
|
|
WriteCommand.ParseValue("3.14", AbCipDataType.Real).ShouldBe(3.14f);
|
|
}
|
|
|
|
[Fact]
|
|
public void ParseValue_LReal_handles_double_precision()
|
|
{
|
|
WriteCommand.ParseValue("2.718281828", AbCipDataType.LReal).ShouldBeOfType<double>();
|
|
}
|
|
|
|
[Fact]
|
|
public void ParseValue_String_passthrough()
|
|
{
|
|
WriteCommand.ParseValue("hello logix", AbCipDataType.String).ShouldBe("hello logix");
|
|
}
|
|
|
|
[Fact]
|
|
public void ParseValue_non_numeric_for_numeric_types_throws_CommandException()
|
|
{
|
|
Should.Throw<CliFx.Exceptions.CommandException>(
|
|
() => WriteCommand.ParseValue("xyz", AbCipDataType.DInt));
|
|
}
|
|
|
|
[Fact]
|
|
public void ParseValue_out_of_range_throws_CommandException()
|
|
{
|
|
// sbyte max is 127; 999 overflows it.
|
|
Should.Throw<CliFx.Exceptions.CommandException>(
|
|
() => WriteCommand.ParseValue("999", AbCipDataType.SInt));
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData("12x", AbCipDataType.Int)]
|
|
[InlineData("3.14", AbCipDataType.DInt)]
|
|
[InlineData("99999999999", AbCipDataType.Int)]
|
|
public void ParseValue_bad_input_CommandException_message_is_actionable(
|
|
string raw, AbCipDataType type)
|
|
{
|
|
var ex = Should.Throw<CliFx.Exceptions.CommandException>(
|
|
() => WriteCommand.ParseValue(raw, type));
|
|
ex.Message.ShouldContain(raw);
|
|
ex.Message.ShouldContain(type.ToString());
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData("Motor01_Speed", AbCipDataType.Real, "Motor01_Speed:Real")]
|
|
[InlineData("Program:Main.Counter", AbCipDataType.DInt, "Program:Main.Counter:DInt")]
|
|
[InlineData("Recipe[3]", AbCipDataType.Int, "Recipe[3]:Int")]
|
|
public void SynthesiseTagName_preserves_path_verbatim(
|
|
string path, AbCipDataType type, string expected)
|
|
{
|
|
ReadCommand.SynthesiseTagName(path, type).ShouldBe(expected);
|
|
}
|
|
}
|