Files
lmxopcua/tests/Server/ZB.MOM.WW.OtOpcUa.Security.Tests/OtOpcUaLdapAuthServiceLoggingTests.cs
T
Joseph Doherty c996b462c4 fix(security): pass FallbackServers/BindMode/UserBindTemplate/AcceptDomainQualifiedNames to the LDAP library, inject its logger (#913)
- LdapOptions gains the four properties (library defaults) and ToLibraryOptions()
  projects them; before this the AdminUI had no DC failover and the keys were
  silently ignored.
- OtOpcUaLdapAuthService builds the library service with ILogger<LdapAuthService>
  from DI, so failover Warnings, the sticky-preference line and stage diagnostics
  reach the log.
- LdapOptionsValidator ports only the library's FallbackServers parse rule and the
  BindMode=User -> UserBindTemplate {0}-exactly-once rule. ServiceAccountDn is NOT
  required: DEV boots on the empty default (plan review B2).
- Fix stale comments: no direct-bind path exists; code default server is localhost.
- Tests: two-way reflection completeness guard over the library LdapOptions
  (allow-list: ServerCertificateValidationCallback), JSON + env binding of the new
  keys, validator rules, DEV-shaped boot, and a DI-built service against two closed
  loopback ports proving library Warnings for primary AND fallback reach the log.

Claude-Session: https://claude.ai/code/session_01GT67AFKC45MBz1wPZnVbX8
2026-11-17 11:18:18 -05:00

73 lines
3.2 KiB
C#

using System.Net;
using System.Net.Sockets;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Options;
using Shouldly;
using Xunit;
using ZB.MOM.WW.OtOpcUa.Security.Ldap;
using LdapTransport = ZB.MOM.WW.Auth.Abstractions.Ldap.LdapTransport;
using LibLdapAuthService = ZB.MOM.WW.Auth.Ldap.LdapAuthService;
namespace ZB.MOM.WW.OtOpcUa.Security.Tests;
/// <summary>
/// lmxopcua#913 — the production <see cref="OtOpcUaLdapAuthService"/> used to build the shared
/// library service with no logger, and the library logs only through <c>_logger?.</c>, so failover
/// hops, the <c>sticky preference moved</c> line and the stage diagnostics never reached the log.
/// This resolves the service through DI (the real constructor) against two CLOSED loopback ports —
/// no directory is contacted — and asserts the library's per-endpoint Warning appears for BOTH the
/// primary and the configured fallback: that proves the library logger is injected AND that
/// <c>FallbackServers</c> reaches the library.
/// </summary>
public sealed class OtOpcUaLdapAuthServiceLoggingTests
{
private static int ClosedLoopbackPort()
{
var listener = new TcpListener(IPAddress.Loopback, 0);
listener.Start();
var port = ((IPEndPoint)listener.LocalEndpoint).Port;
listener.Stop();
return port;
}
[Fact]
public async Task Library_failover_warnings_reach_the_host_log_for_primary_and_fallback()
{
var primaryPort = ClosedLoopbackPort();
var fallbackPort = ClosedLoopbackPort();
var logs = new CapturingLoggerProvider();
var services = new ServiceCollection();
services.AddLogging(l => l.AddProvider(logs).SetMinimumLevel(LogLevel.Trace));
services.AddSingleton(Options.Create(new LdapOptions
{
Enabled = true,
Server = "127.0.0.1",
Port = primaryPort,
Transport = LdapTransport.None,
AllowInsecure = true,
SearchBase = "dc=zb,dc=local",
ConnectionTimeoutMs = 2000,
FallbackServers = [$"127.0.0.1:{fallbackPort}"],
}));
services.AddSingleton<OtOpcUaLdapAuthService>();
await using var sp = services.BuildServiceProvider();
var sut = sp.GetRequiredService<OtOpcUaLdapAuthService>();
var result = await sut.AuthenticateAsync("alice", "pw", TestContext.Current.CancellationToken);
result.Success.ShouldBeFalse();
result.IsSystemFailure.ShouldBeTrue("both endpoints are unreachable — a system-side failure");
var libraryWarnings = logs.Entries
.Where(e => e.Category == typeof(LibLdapAuthService).FullName && e.Level == LogLevel.Warning)
.Select(e => e.Message)
.ToList();
libraryWarnings.ShouldContain(m => m.Contains($"127.0.0.1:{primaryPort}") && m.Contains("failed system-side"),
"the library's own Warning for the primary endpoint must reach the host log");
libraryWarnings.ShouldContain(m => m.Contains($"127.0.0.1:{fallbackPort}") && m.Contains("failed system-side"),
"the fallback endpoint must be tried (FallbackServers projected) and its failure logged");
}
}