3b2defd94f
Renames all 11 projects (5 src + 6 tests), the .slnx solution file, all source-file namespaces, all axaml namespace references, and all v1 documentation references in CLAUDE.md and docs/*.md (excluding docs/v2/ which is already in OtOpcUa form). Also updates the TopShelf service registration name from "LmxOpcUa" to "OtOpcUa" per Phase 0 Task 0.6.
Preserves runtime identifiers per Phase 0 Out-of-Scope rules to avoid breaking v1/v2 client trust during coexistence: OPC UA `ApplicationUri` defaults (`urn:{GalaxyName}:LmxOpcUa`), server `EndpointPath` (`/LmxOpcUa`), `ServerName` default (feeds cert subject CN), `MxAccessConfiguration.ClientName` default (defensive — stays "LmxOpcUa" for MxAccess audit-trail consistency), client OPC UA identifiers (`ApplicationName = "LmxOpcUaClient"`, `ApplicationUri = "urn:localhost:LmxOpcUaClient"`, cert directory `%LocalAppData%\LmxOpcUaClient\pki\`), and the `LmxOpcUaServer` class name (class rename out of Phase 0 scope per Task 0.5 sed pattern; happens in Phase 1 alongside `LmxNodeManager → GenericDriverNodeManager` Core extraction). 23 LmxOpcUa references retained, all enumerated and justified in `docs/v2/implementation/exit-gate-phase-0.md`.
Build clean: 0 errors, 30 warnings (lower than baseline 167). Tests at strict improvement over baseline: 821 passing / 1 failing vs baseline 820 / 2 (one flaky pre-existing failure passed this run; the other still fails — both pre-existing and unrelated to the rename). `Client.UI.Tests`, `Historian.Aveva.Tests`, `Client.Shared.Tests`, `IntegrationTests` all match baseline exactly. Exit gate compliance results recorded in `docs/v2/implementation/exit-gate-phase-0.md` with all 7 checks PASS or DEFERRED-to-PR-review (#7 service install verification needs Windows service permissions on the reviewer's box).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
54 lines
2.3 KiB
C#
54 lines
2.3 KiB
C#
using System;
|
|
using System.Threading.Tasks;
|
|
|
|
namespace ZB.MOM.WW.OtOpcUa.Host.Utilities
|
|
{
|
|
/// <summary>
|
|
/// Bounded safety wrappers for blocking on async tasks from synchronous OPC UA stack
|
|
/// callbacks (Read, Write, HistoryRead*, BuildAddressSpace). These are backstops: the
|
|
/// underlying MxAccess / Historian clients already enforce inner timeouts on the async
|
|
/// path, but an outer bound is still required so the stack thread cannot be parked
|
|
/// indefinitely by a hung scheduler, a slow reconnect, or any other non-returning
|
|
/// async path.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// On timeout, the underlying task is NOT cancelled — it runs to completion on the
|
|
/// thread pool and is abandoned. Callers must be comfortable with the fire-forget
|
|
/// semantics of the background continuation. This is acceptable for the current call
|
|
/// sites because MxAccess and Historian clients are shared singletons whose background
|
|
/// work does not capture request-scoped state.
|
|
/// </remarks>
|
|
internal static class SyncOverAsync
|
|
{
|
|
public static void WaitSync(Task task, TimeSpan timeout, string operation)
|
|
{
|
|
if (task == null) throw new ArgumentNullException(nameof(task));
|
|
try
|
|
{
|
|
if (!task.Wait(timeout))
|
|
throw new TimeoutException($"{operation} exceeded {timeout.TotalSeconds:0.#}s");
|
|
}
|
|
catch (AggregateException ae) when (ae.InnerExceptions.Count == 1)
|
|
{
|
|
// Unwrap the single inner exception so callers can write natural catch blocks.
|
|
throw ae.InnerExceptions[0];
|
|
}
|
|
}
|
|
|
|
public static T WaitSync<T>(Task<T> task, TimeSpan timeout, string operation)
|
|
{
|
|
if (task == null) throw new ArgumentNullException(nameof(task));
|
|
try
|
|
{
|
|
if (!task.Wait(timeout))
|
|
throw new TimeoutException($"{operation} exceeded {timeout.TotalSeconds:0.#}s");
|
|
return task.Result;
|
|
}
|
|
catch (AggregateException ae) when (ae.InnerExceptions.Count == 1)
|
|
{
|
|
throw ae.InnerExceptions[0];
|
|
}
|
|
}
|
|
}
|
|
}
|