Mirrors the v1 otopcua-cli value prop (ad-hoc shell-level PLC validation) for
the Modbus-TCP driver, and lays down the shared scaffolding that AB CIP, AB
Legacy, S7, and TwinCAT CLIs will build on.
New projects:
- src/ZB.MOM.WW.OtOpcUa.Driver.Cli.Common/ — DriverCommandBase (verbose
flag + Serilog config) + SnapshotFormatter (single-tag + table +
write-result renders with invariant-culture value formatting + OPC UA
status-code shortnames + UTC-normalised timestamps).
- src/ZB.MOM.WW.OtOpcUa.Driver.Modbus.Cli/ — otopcua-modbus-cli executable.
Commands: probe, read, write, subscribe. ModbusCommandBase carries the
host/port/unit-id flags + builds ModbusDriverOptions with Probe.Enabled
=false (CLI runs are one-shot; driver-internal keep-alive would race).
Commands + coverage:
- probe single FC03 + GetHealth() + pretty-print
- read region × address × type synth into one driver tag
- write same shape + --value parsed per --type
- subscribe polled-subscription stream until Ctrl+C
Tests (38 total):
- 16 SnapshotFormatterTests covering: status-code shortnames, unknown
codes fall back to hex, null value + timestamp placeholders, bool
lowercase, float invariant culture, string quoting, write-result shape,
aligned table columns, mismatched-length rejection, UTC normalisation.
- 22 Modbus CLI tests:
· ReadCommandTests.SynthesiseTagName (5 theory cases)
· WriteCommandParseValueTests (17 cases: bool aliases, unknown rejected,
Int16 bounds, UInt16/Bcd16 type, Float32/64 invariant culture,
String passthrough, BitInRegister, Int32 MinValue, non-numeric reject)
Wiring:
- ZB.MOM.WW.OtOpcUa.slnx grew 4 entries (2 src + 2 tests).
- docs/Driver.Modbus.Cli.md — operator-facing runbook with examples per
command + output format + typical workflows.
Regression: full-solution build clean; shared-lib tests 16/0, Modbus CLI tests
22/0.
Next up: repeat the pattern for AB CIP (shares ~40% more with Modbus via
libplctag), then AB Legacy, S7, TwinCAT. The shared base stays as-is unless
one of those exposes a gap the Modbus-first pass missed.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
119 lines
5.4 KiB
C#
119 lines
5.4 KiB
C#
using System.Globalization;
|
|
using CliFx.Attributes;
|
|
using CliFx.Infrastructure;
|
|
using ZB.MOM.WW.OtOpcUa.Core.Abstractions;
|
|
using ZB.MOM.WW.OtOpcUa.Driver.Cli.Common;
|
|
|
|
namespace ZB.MOM.WW.OtOpcUa.Driver.Modbus.Cli.Commands;
|
|
|
|
/// <summary>
|
|
/// Write one value to a Modbus coil or holding register. Mirrors <see cref="ReadCommand"/>'s
|
|
/// region / address / type flags + adds <c>--value</c>. Input parsing respects the
|
|
/// declared <c>--type</c> so you can write <c>--value=3.14 --type=Float32</c> without
|
|
/// hex-encoding floats. The write is non-idempotent by default (driver's
|
|
/// <c>WriteIdempotent=false</c>) — replay is the operator's choice, not the driver's.
|
|
/// </summary>
|
|
[Command("write", Description = "Write a single Modbus coil or holding register.")]
|
|
public sealed class WriteCommand : ModbusCommandBase
|
|
{
|
|
[CommandOption("region", 'r', Description =
|
|
"Coils or HoldingRegisters (the only writable regions per the protocol spec).",
|
|
IsRequired = true)]
|
|
public ModbusRegion Region { get; init; }
|
|
|
|
[CommandOption("address", 'a', Description =
|
|
"Zero-based address within the region.", IsRequired = true)]
|
|
public ushort Address { get; init; }
|
|
|
|
[CommandOption("type", 't', Description =
|
|
"Bool / Int16 / UInt16 / Int32 / UInt32 / Int64 / UInt64 / Float32 / Float64 / " +
|
|
"BitInRegister / String / Bcd16 / Bcd32", IsRequired = true)]
|
|
public ModbusDataType DataType { get; init; }
|
|
|
|
[CommandOption("value", 'v', Description =
|
|
"Value to write. Parsed per --type (booleans accept true/false/0/1).",
|
|
IsRequired = true)]
|
|
public string Value { get; init; } = default!;
|
|
|
|
[CommandOption("byte-order", Description =
|
|
"BigEndian (default, ABCD) or WordSwap (CDAB). Ignored for single-register types.")]
|
|
public ModbusByteOrder ByteOrder { get; init; } = ModbusByteOrder.BigEndian;
|
|
|
|
[CommandOption("bit-index", Description =
|
|
"For type=BitInRegister: which bit of the holding register (0-15, LSB-first).")]
|
|
public byte BitIndex { get; init; }
|
|
|
|
[CommandOption("string-length", Description =
|
|
"For type=String: character count (2 per register, rounded up).")]
|
|
public ushort StringLength { get; init; }
|
|
|
|
[CommandOption("string-byte-order", Description =
|
|
"For type=String: HighByteFirst (standard) or LowByteFirst (DirectLOGIC).")]
|
|
public ModbusStringByteOrder StringByteOrder { get; init; } = ModbusStringByteOrder.HighByteFirst;
|
|
|
|
public override async ValueTask ExecuteAsync(IConsole console)
|
|
{
|
|
ConfigureLogging();
|
|
var ct = console.RegisterCancellationHandler();
|
|
|
|
if (Region is not (ModbusRegion.Coils or ModbusRegion.HoldingRegisters))
|
|
throw new CliFx.Exceptions.CommandException(
|
|
$"Region '{Region}' is read-only in the Modbus spec; writes require Coils or HoldingRegisters.");
|
|
|
|
var tagName = ReadCommand.SynthesiseTagName(Region, Address, DataType);
|
|
var tag = new ModbusTagDefinition(
|
|
Name: tagName,
|
|
Region: Region,
|
|
Address: Address,
|
|
DataType: DataType,
|
|
Writable: true,
|
|
ByteOrder: ByteOrder,
|
|
BitIndex: BitIndex,
|
|
StringLength: StringLength,
|
|
StringByteOrder: StringByteOrder);
|
|
var options = BuildOptions([tag]);
|
|
|
|
var parsed = ParseValue(Value, DataType);
|
|
|
|
await using var driver = new ModbusDriver(options, DriverInstanceId);
|
|
try
|
|
{
|
|
await driver.InitializeAsync("{}", ct);
|
|
var results = await driver.WriteAsync([new WriteRequest(tagName, parsed)], ct);
|
|
await console.Output.WriteLineAsync(SnapshotFormatter.FormatWrite(tagName, results[0]));
|
|
}
|
|
finally
|
|
{
|
|
await driver.ShutdownAsync(CancellationToken.None);
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Parse the operator's <c>--value</c> string into the CLR type the driver expects
|
|
/// for the declared <see cref="ModbusDataType"/>. Uses invariant culture everywhere
|
|
/// so <c>3.14</c> and <c>3,14</c> don't swap meaning between runs.
|
|
/// </summary>
|
|
internal static object ParseValue(string raw, ModbusDataType type) => type switch
|
|
{
|
|
ModbusDataType.Bool or ModbusDataType.BitInRegister => ParseBool(raw),
|
|
ModbusDataType.Int16 => short.Parse(raw, CultureInfo.InvariantCulture),
|
|
ModbusDataType.UInt16 or ModbusDataType.Bcd16 => ushort.Parse(raw, CultureInfo.InvariantCulture),
|
|
ModbusDataType.Int32 => int.Parse(raw, CultureInfo.InvariantCulture),
|
|
ModbusDataType.UInt32 or ModbusDataType.Bcd32 => uint.Parse(raw, CultureInfo.InvariantCulture),
|
|
ModbusDataType.Int64 => long.Parse(raw, CultureInfo.InvariantCulture),
|
|
ModbusDataType.UInt64 => ulong.Parse(raw, CultureInfo.InvariantCulture),
|
|
ModbusDataType.Float32 => float.Parse(raw, CultureInfo.InvariantCulture),
|
|
ModbusDataType.Float64 => double.Parse(raw, CultureInfo.InvariantCulture),
|
|
ModbusDataType.String => raw,
|
|
_ => throw new CliFx.Exceptions.CommandException($"Unsupported DataType '{type}' for write."),
|
|
};
|
|
|
|
private static bool ParseBool(string raw) => raw.Trim().ToLowerInvariant() switch
|
|
{
|
|
"1" or "true" or "on" or "yes" => true,
|
|
"0" or "false" or "off" or "no" => false,
|
|
_ => throw new CliFx.Exceptions.CommandException(
|
|
$"Boolean value '{raw}' is not recognised. Use true/false, 1/0, on/off, or yes/no."),
|
|
};
|
|
}
|