3b2defd94f
Renames all 11 projects (5 src + 6 tests), the .slnx solution file, all source-file namespaces, all axaml namespace references, and all v1 documentation references in CLAUDE.md and docs/*.md (excluding docs/v2/ which is already in OtOpcUa form). Also updates the TopShelf service registration name from "LmxOpcUa" to "OtOpcUa" per Phase 0 Task 0.6.
Preserves runtime identifiers per Phase 0 Out-of-Scope rules to avoid breaking v1/v2 client trust during coexistence: OPC UA `ApplicationUri` defaults (`urn:{GalaxyName}:LmxOpcUa`), server `EndpointPath` (`/LmxOpcUa`), `ServerName` default (feeds cert subject CN), `MxAccessConfiguration.ClientName` default (defensive — stays "LmxOpcUa" for MxAccess audit-trail consistency), client OPC UA identifiers (`ApplicationName = "LmxOpcUaClient"`, `ApplicationUri = "urn:localhost:LmxOpcUaClient"`, cert directory `%LocalAppData%\LmxOpcUaClient\pki\`), and the `LmxOpcUaServer` class name (class rename out of Phase 0 scope per Task 0.5 sed pattern; happens in Phase 1 alongside `LmxNodeManager → GenericDriverNodeManager` Core extraction). 23 LmxOpcUa references retained, all enumerated and justified in `docs/v2/implementation/exit-gate-phase-0.md`.
Build clean: 0 errors, 30 warnings (lower than baseline 167). Tests at strict improvement over baseline: 821 passing / 1 failing vs baseline 820 / 2 (one flaky pre-existing failure passed this run; the other still fails — both pre-existing and unrelated to the rename). `Client.UI.Tests`, `Historian.Aveva.Tests`, `Client.Shared.Tests`, `IntegrationTests` all match baseline exactly. Exit gate compliance results recorded in `docs/v2/implementation/exit-gate-phase-0.md` with all 7 checks PASS or DEFERRED-to-PR-review (#7 service install verification needs Windows service permissions on the reviewer's box).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
65 lines
2.5 KiB
C#
65 lines
2.5 KiB
C#
using Shouldly;
|
|
using Xunit;
|
|
using ZB.MOM.WW.OtOpcUa.Host.Domain;
|
|
|
|
namespace ZB.MOM.WW.OtOpcUa.Tests.Domain
|
|
{
|
|
/// <summary>
|
|
/// Verifies the operator-facing error messages and quality mappings derived from MXAccess error codes.
|
|
/// </summary>
|
|
public class MxErrorCodesTests
|
|
{
|
|
/// <summary>
|
|
/// Confirms that known MXAccess error codes produce readable operator-facing descriptions.
|
|
/// </summary>
|
|
/// <param name="code">The MXAccess error code.</param>
|
|
/// <param name="expectedSubstring">A substring expected in the returned description.</param>
|
|
[Theory]
|
|
[InlineData(1008, "Invalid reference")]
|
|
[InlineData(1012, "Wrong data type")]
|
|
[InlineData(1013, "Not writable")]
|
|
[InlineData(1014, "Request timed out")]
|
|
[InlineData(1015, "Communication failure")]
|
|
[InlineData(1016, "Not connected")]
|
|
public void GetMessage_KnownCodes_ContainsDescription(int code, string expectedSubstring)
|
|
{
|
|
MxErrorCodes.GetMessage(code).ShouldContain(expectedSubstring);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Confirms that unknown MXAccess error codes are reported as unknown while preserving the numeric code.
|
|
/// </summary>
|
|
[Fact]
|
|
public void GetMessage_UnknownCode_ReturnsUnknown()
|
|
{
|
|
MxErrorCodes.GetMessage(9999).ShouldContain("Unknown");
|
|
MxErrorCodes.GetMessage(9999).ShouldContain("9999");
|
|
}
|
|
|
|
/// <summary>
|
|
/// Confirms that known MXAccess error codes map to the expected bridge quality values.
|
|
/// </summary>
|
|
/// <param name="code">The MXAccess error code.</param>
|
|
/// <param name="expected">The expected bridge quality value.</param>
|
|
[Theory]
|
|
[InlineData(1008, Quality.BadConfigError)]
|
|
[InlineData(1012, Quality.BadConfigError)]
|
|
[InlineData(1013, Quality.BadOutOfService)]
|
|
[InlineData(1014, Quality.BadCommFailure)]
|
|
[InlineData(1015, Quality.BadCommFailure)]
|
|
[InlineData(1016, Quality.BadNotConnected)]
|
|
public void MapToQuality_KnownCodes(int code, Quality expected)
|
|
{
|
|
MxErrorCodes.MapToQuality(code).ShouldBe(expected);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Confirms that unknown MXAccess error codes map to the generic bad quality bucket.
|
|
/// </summary>
|
|
[Fact]
|
|
public void MapToQuality_UnknownCode_ReturnsBad()
|
|
{
|
|
MxErrorCodes.MapToQuality(9999).ShouldBe(Quality.Bad);
|
|
}
|
|
}
|
|
} |