Joseph Doherty
64e3fbe035
v2-ci / build (push) Failing after 1m43s
v2-ci / unit-tests (tests/Core/ZB.MOM.WW.OtOpcUa.Cluster.Tests) (push) Has been skipped
v2-ci / unit-tests (tests/Server/ZB.MOM.WW.OtOpcUa.ControlPlane.Tests) (push) Has been skipped
v2-ci / unit-tests (tests/Server/ZB.MOM.WW.OtOpcUa.OpcUaServer.Tests) (push) Has been skipped
v2-ci / unit-tests (tests/Server/ZB.MOM.WW.OtOpcUa.Runtime.Tests) (push) Has been skipped
v2-ci / unit-tests (tests/Server/ZB.MOM.WW.OtOpcUa.Security.Tests) (push) Has been skipped
v2-ci / integration (tests/Server/ZB.MOM.WW.OtOpcUa.Host.IntegrationTests) (push) Has been skipped
v2-ci / integration (tests/Server/ZB.MOM.WW.OtOpcUa.OpcUaServer.IntegrationTests) (push) Has been skipped
Adds <summary>, <param>, <typeparam>, and <inheritdoc/> tags to public members surfaced by commentchecker — resolves 5,847 of 5,869 issues (99.6%) across three /fixdocs passes.
70 lines
3.7 KiB
C#
70 lines
3.7 KiB
C#
using libplctag;
|
|
using Shouldly;
|
|
using Xunit;
|
|
using ZB.MOM.WW.OtOpcUa.Driver.AbCip;
|
|
|
|
namespace ZB.MOM.WW.OtOpcUa.Driver.AbCip.Tests;
|
|
|
|
[Trait("Category", "Unit")]
|
|
public sealed class AbCipStatusMapperTests
|
|
{
|
|
/// <summary>Verifies that CIP general status codes are mapped to OPC UA status codes.</summary>
|
|
/// <param name="status">The raw CIP general status byte.</param>
|
|
/// <param name="expected">The expected OPC UA status code.</param>
|
|
[Theory]
|
|
[InlineData((byte)0x00, AbCipStatusMapper.Good)]
|
|
[InlineData((byte)0x04, AbCipStatusMapper.BadNodeIdUnknown)]
|
|
[InlineData((byte)0x05, AbCipStatusMapper.BadNodeIdUnknown)]
|
|
[InlineData((byte)0x06, AbCipStatusMapper.GoodMoreData)]
|
|
[InlineData((byte)0x08, AbCipStatusMapper.BadNotSupported)]
|
|
[InlineData((byte)0x0A, AbCipStatusMapper.BadOutOfRange)]
|
|
[InlineData((byte)0x13, AbCipStatusMapper.BadOutOfRange)]
|
|
[InlineData((byte)0x0B, AbCipStatusMapper.Good)]
|
|
[InlineData((byte)0x0E, AbCipStatusMapper.BadNotWritable)]
|
|
[InlineData((byte)0x10, AbCipStatusMapper.BadDeviceFailure)]
|
|
[InlineData((byte)0x16, AbCipStatusMapper.BadNodeIdUnknown)]
|
|
[InlineData((byte)0xFF, AbCipStatusMapper.BadInternalError)]
|
|
public void MapCipGeneralStatus_maps_known_codes(byte status, uint expected)
|
|
{
|
|
AbCipStatusMapper.MapCipGeneralStatus(status).ShouldBe(expected);
|
|
}
|
|
|
|
// Driver.AbCip-002 — the integers here are the underlying values of the libplctag.NET
|
|
// Status enum (what (int)Tag.GetStatus() actually returns), NOT raw native PLCTAG_ERR_*
|
|
// constants. The libplctag.NET wrapper renumbers the native codes into a contiguous enum.
|
|
/// <summary>Verifies that libplctag Status enum values are mapped to OPC UA status codes.</summary>
|
|
/// <param name="status">The libplctag Status enum value to map.</param>
|
|
/// <param name="expected">The expected OPC UA status code.</param>
|
|
[Theory]
|
|
[InlineData(Status.Ok, AbCipStatusMapper.Good)]
|
|
[InlineData(Status.Pending, AbCipStatusMapper.GoodMoreData)]
|
|
[InlineData(Status.ErrorTimeout, AbCipStatusMapper.BadTimeout)]
|
|
[InlineData(Status.ErrorNotFound, AbCipStatusMapper.BadNodeIdUnknown)]
|
|
[InlineData(Status.ErrorNotAllowed, AbCipStatusMapper.BadNotWritable)]
|
|
[InlineData(Status.ErrorOutOfBounds, AbCipStatusMapper.BadOutOfRange)]
|
|
[InlineData(Status.ErrorBadConnection, AbCipStatusMapper.BadCommunicationError)]
|
|
[InlineData(Status.ErrorBadGateway, AbCipStatusMapper.BadCommunicationError)]
|
|
[InlineData(Status.ErrorUnsupported, AbCipStatusMapper.BadNotSupported)]
|
|
[InlineData(Status.ErrorNoMem, AbCipStatusMapper.BadCommunicationError)] // unmapped → generic comms
|
|
public void MapLibplctagStatus_maps_real_enum_members(Status status, uint expected)
|
|
{
|
|
AbCipStatusMapper.MapLibplctagStatus(status).ShouldBe(expected);
|
|
// The int overload must agree — it is the seam IAbCipTagRuntime.GetStatus() drives.
|
|
AbCipStatusMapper.MapLibplctagStatus((int)status).ShouldBe(expected);
|
|
}
|
|
|
|
/// <summary>Verifies that timeout is distinguished from generic communication error.</summary>
|
|
[Fact]
|
|
public void MapLibplctagStatus_distinguishes_timeout_from_generic_comms_error()
|
|
{
|
|
// Regression for Driver.AbCip-002: a real timeout used to fall through to
|
|
// BadCommunicationError because the code matched the wrong integer (-5).
|
|
AbCipStatusMapper.MapLibplctagStatus((int)Status.ErrorTimeout)
|
|
.ShouldBe(AbCipStatusMapper.BadTimeout);
|
|
AbCipStatusMapper.MapLibplctagStatus((int)Status.ErrorNotFound)
|
|
.ShouldBe(AbCipStatusMapper.BadNodeIdUnknown);
|
|
AbCipStatusMapper.MapLibplctagStatus((int)Status.ErrorNotFound)
|
|
.ShouldNotBe(AbCipStatusMapper.BadCommunicationError);
|
|
}
|
|
}
|