46d9a19bc5
/auth/login signed users in with an empty role set (and did so when the role mapper threw), and AuthenticatedRead / the fallback policy admit any authenticated user — with a domain-root SearchBase any AD user would get AdminUI read access and a token. - Empty mapped role set: refused like bad credentials (JSON 401; form redirect to /login with a generic message), no cookie, Warning logged with the groups. - Mapper throws: refused, fail closed (JSON 503 like an LDAP outage; form redirect with a generic "temporarily unavailable"), exception logged. - /auth/token: refuses (401) a cookie session carrying no role claim. - Replaces Login_when_role_mapper_throws_signs_in_with_no_role_claims with refusal tests (JSON + form), adds zero-role refused (JSON + form), one-mapped-role signs in, zero-role cookie gets no token. JwtConfigurationGateTests' stub user now holds a mapped group. Claude-Session: https://claude.ai/code/session_01GT67AFKC45MBz1wPZnVbX8
129 lines
5.9 KiB
C#
129 lines
5.9 KiB
C#
using System.Net;
|
|
using System.Net.Http.Json;
|
|
using Microsoft.AspNetCore.Authentication;
|
|
using Microsoft.AspNetCore.Builder;
|
|
using Microsoft.AspNetCore.Hosting;
|
|
using Microsoft.AspNetCore.Http;
|
|
using Microsoft.AspNetCore.TestHost;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using Microsoft.Extensions.Configuration;
|
|
using Microsoft.Extensions.DependencyInjection;
|
|
using Microsoft.Extensions.Hosting;
|
|
using Microsoft.Extensions.Options;
|
|
using Shouldly;
|
|
using Xunit;
|
|
using ZB.MOM.WW.OtOpcUa.Configuration;
|
|
using ZB.MOM.WW.OtOpcUa.Configuration.Services;
|
|
using ZB.MOM.WW.OtOpcUa.Security.Auth;
|
|
using ZB.MOM.WW.OtOpcUa.Security.Endpoints;
|
|
using ZB.MOM.WW.OtOpcUa.Security.Jwt;
|
|
using ZB.MOM.WW.OtOpcUa.Security.Ldap;
|
|
|
|
namespace ZB.MOM.WW.OtOpcUa.Security.Tests;
|
|
|
|
/// <summary>
|
|
/// R03:2.4 — JWT is opt-in by signing key. Unconfigured: <c>/auth/token</c> is not mapped (it used to
|
|
/// answer HTTP 500 from the service constructor) and no bearer scheme exists. Configured badly: the
|
|
/// host refuses to START rather than failing on the first token request.
|
|
/// </summary>
|
|
public sealed class JwtConfigurationGateTests
|
|
{
|
|
private static CancellationToken Ct => TestContext.Current.CancellationToken;
|
|
|
|
[Fact]
|
|
public async Task Without_a_signing_key_auth_token_is_not_mapped_and_bearer_is_ignored()
|
|
{
|
|
using var host = await StartHostAsync(signingKey: null);
|
|
var server = host.GetTestServer();
|
|
var client = server.CreateClient();
|
|
|
|
// The login still works — the cookie path is untouched.
|
|
var login = await client.PostAsJsonAsync("/auth/login", new AuthEndpoints.LoginRequest("alice", "valid-password"), Ct);
|
|
login.StatusCode.ShouldBe(HttpStatusCode.NoContent);
|
|
|
|
// /auth/token is simply absent (404), not a 500.
|
|
var tokenReq = new HttpRequestMessage(HttpMethod.Post, "/auth/token");
|
|
foreach (var c in login.Headers.GetValues("Set-Cookie")) tokenReq.Headers.Add("Cookie", c.Split(';')[0]);
|
|
(await client.SendAsync(tokenReq, Ct)).StatusCode.ShouldBe(HttpStatusCode.NotFound);
|
|
|
|
// No bearer scheme is registered, so a bearer header is ignored and the cookie session still wins.
|
|
var schemes = host.Services.GetRequiredService<IAuthenticationSchemeProvider>();
|
|
(await schemes.GetSchemeAsync(OtOpcUaAuthSchemes.Bearer)).ShouldBeNull();
|
|
var withBogusBearer = new HttpRequestMessage(HttpMethod.Get, "/");
|
|
foreach (var c in login.Headers.GetValues("Set-Cookie")) withBogusBearer.Headers.Add("Cookie", c.Split(';')[0]);
|
|
withBogusBearer.Headers.Authorization = new System.Net.Http.Headers.AuthenticationHeaderValue("Bearer", "garbage");
|
|
(await client.SendAsync(withBogusBearer, Ct)).StatusCode.ShouldBe(HttpStatusCode.OK);
|
|
|
|
await host.StopAsync(Ct);
|
|
}
|
|
|
|
/// <summary>Positive control for the gate: with a key, the bearer scheme IS registered.</summary>
|
|
[Fact]
|
|
public async Task With_a_signing_key_the_bearer_scheme_is_registered()
|
|
{
|
|
using var host = await StartHostAsync(signingKey: "test-signing-key-with-at-least-32-bytes-of-utf8-content");
|
|
var schemes = host.Services.GetRequiredService<IAuthenticationSchemeProvider>();
|
|
var bearer = await schemes.GetSchemeAsync(OtOpcUaAuthSchemes.Bearer);
|
|
bearer.ShouldNotBeNull();
|
|
bearer.HandlerType.ShouldBe(typeof(Microsoft.AspNetCore.Authentication.JwtBearer.JwtBearerHandler));
|
|
await host.StopAsync(Ct);
|
|
}
|
|
|
|
/// <summary>A configured-but-short key fails at host start (ValidateOnStart), not on the first /auth/token.</summary>
|
|
[Fact]
|
|
public async Task A_short_signing_key_fails_host_start()
|
|
{
|
|
var ex = await Should.ThrowAsync<OptionsValidationException>(async () =>
|
|
{
|
|
using var host = await StartHostAsync(signingKey: "too-short");
|
|
});
|
|
ex.Message.ShouldContain("SigningKey");
|
|
}
|
|
|
|
private static async Task<IHost> StartHostAsync(string? signingKey)
|
|
{
|
|
var dbName = $"jwt-gate-{Guid.NewGuid():N}";
|
|
// lmxopcua#913: a login whose groups map to no role is refused, so alice's group must map.
|
|
var settings = new Dictionary<string, string?> { ["Security:Ldap:GroupToRole:ReadOnly"] = "Viewer" };
|
|
if (signingKey is not null) settings["Security:Jwt:SigningKey"] = signingKey;
|
|
var configuration = new ConfigurationBuilder().AddInMemoryCollection(settings).Build();
|
|
|
|
var host = new HostBuilder()
|
|
.ConfigureWebHost(web =>
|
|
{
|
|
web.UseTestServer();
|
|
web.ConfigureServices(services =>
|
|
{
|
|
services.AddDbContextFactory<OtOpcUaConfigDbContext>(opt => opt.UseInMemoryDatabase(dbName));
|
|
services.AddDbContext<OtOpcUaConfigDbContext>(opt => opt.UseInMemoryDatabase(dbName));
|
|
services.AddRouting();
|
|
services.AddOtOpcUaAuth(configuration);
|
|
services.AddSingleton<ILdapAuthService, AlwaysAliceLdap>();
|
|
services.AddSingleton<ILdapGroupRoleMappingService, NullLdapGroupRoleMappingService>();
|
|
});
|
|
web.Configure(app =>
|
|
{
|
|
app.UseRouting();
|
|
app.UseAuthentication();
|
|
app.UseAuthorization();
|
|
app.UseEndpoints(e =>
|
|
{
|
|
e.MapOtOpcUaAuth();
|
|
e.MapGet("/", () => Results.Ok("authenticated")).RequireAuthorization();
|
|
});
|
|
});
|
|
})
|
|
.Build();
|
|
await host.StartAsync(Ct);
|
|
return host;
|
|
}
|
|
|
|
private sealed class AlwaysAliceLdap : ILdapAuthService
|
|
{
|
|
public Task<LdapAuthResult> AuthenticateAsync(string username, string password, CancellationToken ct = default) =>
|
|
Task.FromResult(new LdapAuthResult(
|
|
Success: password == "valid-password", DisplayName: "Alice", Username: username,
|
|
Groups: ["ReadOnly"], Roles: [], Error: null));
|
|
}
|
|
}
|