53ede679c3
deferment.md §8.1 asked for a decision: wire IPermissionEvaluator into the node manager, or say plainly that ACLs are not enforced. Decision: the latter. The evaluator stays in the tree; #520 tracks the wire-up. Verifying the claim turned up four things worse than the audit recorded: - docs/security.md, not ReadWriteOperations.md, was the highest-risk doc. It claimed an anonymous session is "default-denie[d] any node a session has no ACL grant for". The opposite holds: anonymous can Browse/Read/Subscribe/ HistoryRead the entire address space, and is refused writes and alarm acks only because it carries no roles. - Three of five documented data-plane role strings do nothing. OpcUaDataPlaneRoles declares exactly WriteOperate and AlarmAck; ReadOnly, WriteTune and WriteConfigure are compared against nowhere in src/. The doc called all five "exact, case-insensitive, and code-true". - ReadWriteOperations.md was fiction beyond the ACL claims. OnReadValue has zero occurrences in src/ — the documented read path did not exist. Reads never reach a driver: the node manager is push-model and the SDK serves a Read from the cached pushed value. WriteAuthzPolicy, _sourceByFullRef, _writeIdempotentByFullRef and IRoleBearer are likewise zero-hit, and CapabilityInvoker is not referenced by the OpcUaServer project at all. This file is rewritten rather than bannered. - v2-release-readiness.md claimed a whole enforcement layer shipped — FilterBrowseReferences, GateCallMethodRequests, MapCallOperation, AuthorizationBootstrap, Node:Authorization:* keys. None exist. Whatever landed on the v2 branch did not survive into the shipped tree. The UI change is the operative one: ClusterAcls.razor and AclEdit.razor now warn that a grant is saved and shipped in every deployment artifact but never evaluated, so an operator cannot author a deny rule believing it works. deferment.md gains a §9 execution log tracking §8 remediation.
112 lines
4.8 KiB
Plaintext
112 lines
4.8 KiB
Plaintext
@page "/clusters/{ClusterId}/acls"
|
|
@attribute [Authorize(Policy = AdminUiPolicies.AuthenticatedRead)]
|
|
@rendermode RenderMode.InteractiveServer
|
|
@using Microsoft.EntityFrameworkCore
|
|
@using ZB.MOM.WW.OtOpcUa.Configuration
|
|
@using ZB.MOM.WW.OtOpcUa.Configuration.Entities
|
|
@inject IDbContextFactory<OtOpcUaConfigDbContext> DbFactory
|
|
|
|
<div class="d-flex justify-content-between align-items-center mb-3">
|
|
<h4 class="mb-0">ACLs · <span class="mono">@ClusterId</span></h4>
|
|
<a href="/clusters/@ClusterId/acls/new" class="btn btn-primary btn-sm">New ACL grant</a>
|
|
</div>
|
|
|
|
<ClusterNav ClusterId="@ClusterId" ActiveTab="acls" />
|
|
|
|
@if (_rows is null)
|
|
{
|
|
<p>Loading…</p>
|
|
}
|
|
else
|
|
{
|
|
<div class="alert alert-warning" role="alert">
|
|
<strong>These rules are not enforced.</strong>
|
|
ACL rows are saved and shipped in every deployment artifact, but the OPC UA server never
|
|
evaluates them — the permission evaluator has no production call site. Authoring a grant here
|
|
changes nothing about what a client can read or write.
|
|
<br />
|
|
What <em>is</em> enforced today is coarse and fleet-wide: a client needs the
|
|
<span class="mono">WriteOperate</span> role to write any tag and
|
|
<span class="mono">AlarmAck</span> to acknowledge any alarm, both mapped from LDAP groups via
|
|
<span class="mono">Security:Ldap:GroupToRole</span>. Reads, browses, subscriptions and history
|
|
reads are <strong>not</strong> restricted at all. See <span class="mono">docs/security.md</span>.
|
|
</div>
|
|
|
|
<section class="panel notice rise" style="animation-delay:.02s">
|
|
ACL rows grant LDAP groups specific <span class="mono">NodePermissions</span> on a scope
|
|
(a folder, an equipment, a tag). Per-cluster role grants were dropped in favour of
|
|
fleet-wide LDAP-group → role mapping; ACLs here are the finer-grained per-node scope.
|
|
</section>
|
|
|
|
<section class="panel rise mt-3" style="animation-delay:.08s">
|
|
<div class="panel-head">@_rows.Count ACL row@(_rows.Count == 1 ? "" : "s")</div>
|
|
@if (_rows.Count == 0)
|
|
{
|
|
<div style="padding:1rem" class="text-muted">No ACL rows for this cluster — default permissions from the fleet-wide LDAP group mapping apply.</div>
|
|
}
|
|
else
|
|
{
|
|
<div class="table-wrap">
|
|
<table class="data-table">
|
|
<thead>
|
|
<tr>
|
|
<th>NodeAclId</th>
|
|
<th>LDAP group</th>
|
|
<th>Scope</th>
|
|
<th>Scope target</th>
|
|
<th>Permissions</th>
|
|
<th>Notes</th>
|
|
<th></th>
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
@foreach (var a in _rows)
|
|
{
|
|
<tr>
|
|
<td><span class="mono small">@a.NodeAclId</span></td>
|
|
<td><span class="mono">@a.LdapGroup</span></td>
|
|
<td>@a.ScopeKind</td>
|
|
<td><span class="mono small">@(a.ScopeId ?? "—")</span></td>
|
|
<td>
|
|
@foreach (var perm in PermissionChips(a.PermissionFlags))
|
|
{
|
|
<span class="chip chip-idle me-1">@perm</span>
|
|
}
|
|
</td>
|
|
<td class="text-muted small">@(a.Notes ?? "")</td>
|
|
<td><a href="/clusters/@ClusterId/acls/@a.NodeAclId" class="btn btn-sm btn-outline-primary">Edit</a></td>
|
|
</tr>
|
|
}
|
|
</tbody>
|
|
</table>
|
|
</div>
|
|
}
|
|
</section>
|
|
}
|
|
|
|
@code {
|
|
[Parameter] public string ClusterId { get; set; } = "";
|
|
private List<NodeAcl>? _rows;
|
|
|
|
protected override async Task OnInitializedAsync()
|
|
{
|
|
await using var db = await DbFactory.CreateDbContextAsync();
|
|
_rows = await db.NodeAcls.AsNoTracking()
|
|
.Where(a => a.ClusterId == ClusterId)
|
|
.OrderBy(a => a.NodeAclId)
|
|
.ToListAsync();
|
|
}
|
|
|
|
private static IEnumerable<string> PermissionChips(ZB.MOM.WW.OtOpcUa.Configuration.Enums.NodePermissions flags)
|
|
{
|
|
foreach (var v in Enum.GetValues<ZB.MOM.WW.OtOpcUa.Configuration.Enums.NodePermissions>())
|
|
{
|
|
// Skip None (zero) and composite values that aren't single bits.
|
|
var n = (int)v;
|
|
if (n == 0) continue;
|
|
if ((n & (n - 1)) != 0) continue;
|
|
if (flags.HasFlag(v)) yield return v.ToString();
|
|
}
|
|
}
|
|
}
|