Files

Joseph Doherty a3d16a28f1 Phase 2 Stream D Option B — archive v1 surface + new Driver.Galaxy.E2E parity suite. Non-destructive intermediate state: the v1 OtOpcUa.Host + Historian.Aveva + Tests + IntegrationTests projects all still build (494 v1 unit + 6 v1 integration tests still pass when run explicitly), but solution-level dotnet test ZB.MOM.WW.OtOpcUa.slnx now skips them via IsTestProject=false on the test projects + archive-status PropertyGroup comments on the src projects. The destructive deletion is reserved for Phase 2 PR 3 with explicit operator review per CLAUDE.md "only use destructive operations when truly the best approach". tests/ZB.MOM.WW.OtOpcUa.Tests/ renamed via git mv to tests/ZB.MOM.WW.OtOpcUa.Tests.v1Archive/; csproj <AssemblyName> kept as the original ZB.MOM.WW.OtOpcUa.Tests so v1 OtOpcUa.Host's [InternalsVisibleTo("ZB.MOM.WW.OtOpcUa.Tests")] still matches and the project rebuilds clean. tests/ZB.MOM.WW.OtOpcUa.IntegrationTests gets <IsTestProject>false</IsTestProject>. src/ZB.MOM.WW.OtOpcUa.Host + src/ZB.MOM.WW.OtOpcUa.Historian.Aveva get PropertyGroup archive-status comments documenting they're functionally superseded but kept in-build because cascading dependencies (Historian.Aveva → Host; IntegrationTests → Host) make a single-PR deletion high blast-radius. New tests/ZB.MOM.WW.OtOpcUa.Driver.Galaxy.E2E/ project (.NET 10) with ParityFixture that spawns OtOpcUa.Driver.Galaxy.Host.exe (net48 x86) as a Process.Start subprocess with OTOPCUA_GALAXY_BACKEND=db env vars, awaits 2s for the PipeServer to bind, then exposes a connected GalaxyProxyDriver; skips on non-Windows / Administrator shells (PipeAcl denies admins per decision #76 ) / ZB unreachable / Host EXE not built — each skip carries a SkipReason string the test method reads via Assert.Skip(SkipReason). RecordingAddressSpaceBuilder captures every Folder/Variable/AddProperty registration so parity tests can assert on the same shape v1 LmxNodeManager produced. HierarchyParityTests (3) — Discover returns gobjects with attributes; attribute full references match the tag.attribute Galaxy reference grammar; HistoryExtension flag flows through correctly. StabilityFindingsRegressionTests (4) — one test per 2026-04-13 stability finding from commits c76ab8f and 7310925: phantom probe subscription doesn't corrupt unrelated host status; HostStatusChangedEventArgs structurally carries a specific HostName + OldState + NewState (event signature mathematically prevents the v1 cross-host quality-clear bug); all GalaxyProxyDriver capability methods return Task or Task<T> (sync-over-async would deadlock OPC UA stack thread); AcknowledgeAsync completes before returning (no fire-and-forget background work that could race shutdown). Solution test count: 470 pass / 7 skip (E2E on admin shell) / 1 pre-existing Phase 0 baseline. Run archived suites explicitly: dotnet test tests/ZB.MOM.WW.OtOpcUa.Tests.v1Archive (494 pass) + dotnet test tests/ZB.MOM.WW.OtOpcUa.IntegrationTests (6 pass). docs/v2/V1_ARCHIVE_STATUS.md inventories every archived surface with run-it-explicitly instructions + a 10-step deletion plan for PR 3 + rollback procedure (git revert restores all four projects). docs/v2/implementation/exit-gate-phase-2-final.md supersedes the two partial-exit docs with the per-stream status table (A/B/C/D/E all addressed, D split across PR 2/3 per safety protocol), the test count breakdown, fresh adversarial review of PR 2 deltas (4 new findings: medium IsTestProject=false safety net loss, medium structural-vs-behavioral stability tests, low backend=db default, low Process.Start env inheritance), the 8 carried-forward findings from exit-gate-phase-2.md, the recommended PR order (1 → 2 → 3 → 4). docs/v2/implementation/pr-2-body.md is the Gitea web-UI paste-in for opening PR 2 once pushed.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-04-18 00:56:21 -04:00

2.8 KiB

Raw Blame History

V1 Archive Status (Phase 2 Stream D, 2026-04-18)

This document inventories every v1 surface that's been functionally superseded by v2 but physically retained in the build until the deletion PR (Phase 2 PR 3). Rationale: cascading references mean a single deletion is high blast-radius; archive-marking lets the v2 stack ship on its own merits while the v1 surface stays as parity reference.

Archived projects

Path	Status	Replaced by	Build behavior
`src/ZB.MOM.WW.OtOpcUa.Host/`	Archive (executable in build)	`OtOpcUa.Server` + `Driver.Galaxy.Host` + `Driver.Galaxy.Proxy`	Builds; not deployed by v2 install scripts
`src/ZB.MOM.WW.OtOpcUa.Historian.Aveva/`	Archive (plugin in build)	TODO: port into `Driver.Galaxy.Host/Backend/Historian/` (Task B.1.h follow-up)	Builds; loaded only by archived Host
`tests/ZB.MOM.WW.OtOpcUa.Tests.v1Archive/`	Archive	`Driver.Galaxy.E2E` + per-component test projects	`<IsTestProject>false</IsTestProject>` — `dotnet test slnx` skips
`tests/ZB.MOM.WW.OtOpcUa.IntegrationTests/`	Archive	`Driver.Galaxy.E2E`	`<IsTestProject>false</IsTestProject>` — `dotnet test slnx` skips

How to run the archived suites explicitly

# v1 unit tests (494):
dotnet test tests/ZB.MOM.WW.OtOpcUa.Tests.v1Archive

# v1 integration tests (6):
dotnet test tests/ZB.MOM.WW.OtOpcUa.IntegrationTests

Both still pass on this dev box — they're the parity reference for Phase 2 PR 3's deletion decision.

Deletion plan (Phase 2 PR 3)

Pre-conditions:

Driver.Galaxy.E2E test count covers the v1 IntegrationTests' 6 integration scenarios at minimum (currently 7 tests; expand as needed)
Driver.Galaxy.Host/Backend/Historian/ ports the Wonderware Historian plugin so MxAccessGalaxyBackend.HistoryReadAsync returns real data (Task B.1.h)
Operator review on a separate PR — destructive change

Steps:

git rm -r src/ZB.MOM.WW.OtOpcUa.Host/
git rm -r src/ZB.MOM.WW.OtOpcUa.Historian.Aveva/ (or move it under Driver.Galaxy.Host first if the lift is part of the same PR)
git rm -r tests/ZB.MOM.WW.OtOpcUa.Tests.v1Archive/
git rm -r tests/ZB.MOM.WW.OtOpcUa.IntegrationTests/
Edit ZB.MOM.WW.OtOpcUa.slnx — remove the four project lines
dotnet build ZB.MOM.WW.OtOpcUa.slnx → confirm clean
dotnet test ZB.MOM.WW.OtOpcUa.slnx → confirm 470+ pass / 1 baseline (or whatever the current count is plus any new E2E coverage)
Commit: "Phase 2 Stream D — delete v1 archive (Host + Historian.Aveva + v1Tests + IntegrationTests)"
PR 3 against v2, link this doc + exit-gate-phase-2-final.md
One reviewer signoff

Rollback

If Phase 2 PR 3 surfaces downstream consumer regressions, git revert the deletion commit restores the four projects intact. The v2 stack continues to ship from the v2 branch.

2.8 KiB Raw Blame History