Joseph Doherty
cfd403710e
Every HistoryUpdate a SQL backend applies now leaves a modification trail
(prior value, principal, Part 11 update type, modification time), and
HistoryReadRaw with IsReadModified=true serves it as HistoryModifiedData.
- Core: HistoryUpdateContext threaded into all three IHistorianDataUpdater
methods; IHistorianDataSource.ReadModifiedAsync (default NotSupported =>
BadHistoryOperationUnsupported on Gateway/Null); HistoryModified* contracts.
- SqlServer: schema v2 (002_sample_modified.sql, RequiredVersion=2, docs copy);
trail written by OUTPUT ... INTO on the same MERGE/DELETE statement, so a
failed update leaves no audit row; retention purges SampleModified per tag on
the source-time cutoff; ReadModifiedAsync keyed on (SourceTimeUtc, ModifiedId).
- QuestDB: append-only {prefix}sample_modified (TTL like samples), trail row
written BEFORE the change (orphan-on-crash, never an untracked change);
existence reads now carry the prior value; ReadModifiedAsync.
- Node manager: modified reads dispatch + page via the #669 continuation store
(HistoryContinuationState gains HistoryCursorKind + LastModifiedId), gated by
the existing HistoryRead decision; session principal / key id passed to the
updater. IsDeleteModified stays unsupported.
- Client.CLI: historyread --modified.
- Tests: node-manager dispatch/paging/cursor binding/principal threading,
over-the-wire HistoryModifiedData, shared ModifiedValueConformance on both
backends, SqlServer atomicity (forced trail failure => no change) + v1->v2
upgrade + retention trail purge.
- Docs: Historian.md (Modified-value history section, schema v2 upgrade note),
security.md, Client.CLI.md, CLAUDE.md.
59 lines
2.8 KiB
C#
59 lines
2.8 KiB
C#
using Shouldly;
|
|
using Xunit;
|
|
|
|
namespace ZB.MOM.WW.OtOpcUa.Driver.Historian.SqlServer.Tests;
|
|
|
|
public sealed class SchemaScriptTests
|
|
{
|
|
[Fact]
|
|
public void Go_splitting_ignores_go_inside_other_text_and_drops_empties()
|
|
{
|
|
var parts = SqlServerSchemaBootstrapper.SplitBatches("A\nGO\n go \nB GO C\nGO\n").ToArray();
|
|
parts.ShouldBe(["A", "B GO C"]);
|
|
}
|
|
|
|
[Fact]
|
|
public void Embedded_script_is_present_and_matches_the_docs_copy()
|
|
{
|
|
var asm = typeof(SqlServerSchemaBootstrapper).Assembly;
|
|
using var s = asm.GetManifestResourceStream("Schema.001_initial.sql");
|
|
s.ShouldNotBeNull();
|
|
var text = new StreamReader(s!).ReadToEnd();
|
|
text.ShouldContain("$(Schema)");
|
|
text.ShouldContain("PRIMARY KEY NONCLUSTERED");
|
|
text.ShouldContain("CREATE CLUSTERED INDEX CX_Event_Time");
|
|
text.ShouldNotContain("IX_Event_Time");
|
|
|
|
var dir = new DirectoryInfo(AppContext.BaseDirectory);
|
|
while (dir is not null && !File.Exists(Path.Combine(dir.FullName, "ZB.MOM.WW.OtOpcUa.slnx"))) dir = dir.Parent;
|
|
dir.ShouldNotBeNull();
|
|
File.ReadAllText(Path.Combine(dir!.FullName, "docs/historian/sqlserver/001_initial.sql")).ShouldBe(text);
|
|
}
|
|
|
|
/// <summary>
|
|
/// #668: schema v2 (the Part 11 modification trail) is embedded, matches its docs copy, records version 2 (which
|
|
/// must equal <see cref="SqlServerSchemaBootstrapper.RequiredVersion"/>), and carries none of the constructs an
|
|
/// <c>OUTPUT … INTO</c> target forbids (FOREIGN KEY / CHECK / trigger) — any of them would fail every HistoryUpdate.
|
|
/// </summary>
|
|
[Fact]
|
|
public void Schema_v2_sample_modified_is_embedded_matches_the_docs_copy_and_is_a_legal_output_into_target()
|
|
{
|
|
var asm = typeof(SqlServerSchemaBootstrapper).Assembly;
|
|
using var s = asm.GetManifestResourceStream("Schema.002_sample_modified.sql");
|
|
s.ShouldNotBeNull();
|
|
var text = new StreamReader(s!).ReadToEnd();
|
|
text.ShouldContain("[SampleModified]");
|
|
text.ShouldContain("PRIMARY KEY CLUSTERED (TagId, SourceTimeUtc, ModifiedId)");
|
|
text.ShouldContain("VALUES (2, SYSUTCDATETIME())");
|
|
SqlServerSchemaBootstrapper.RequiredVersion.ShouldBe(2);
|
|
var ddl = string.Join('\n', text.Split('\n').Where(l => !l.TrimStart().StartsWith("--", StringComparison.Ordinal)));
|
|
ddl.ShouldNotContain("FOREIGN KEY", Case.Insensitive);
|
|
ddl.ShouldNotContain("CHECK", Case.Insensitive);
|
|
ddl.ShouldNotContain("TRIGGER", Case.Insensitive);
|
|
|
|
var dir = new DirectoryInfo(AppContext.BaseDirectory);
|
|
while (dir is not null && !File.Exists(Path.Combine(dir.FullName, "ZB.MOM.WW.OtOpcUa.slnx"))) dir = dir.Parent;
|
|
File.ReadAllText(Path.Combine(dir!.FullName, "docs/historian/sqlserver/002_sample_modified.sql")).ShouldBe(text);
|
|
}
|
|
}
|