Joseph Doherty
cfd403710e
Every HistoryUpdate a SQL backend applies now leaves a modification trail
(prior value, principal, Part 11 update type, modification time), and
HistoryReadRaw with IsReadModified=true serves it as HistoryModifiedData.
- Core: HistoryUpdateContext threaded into all three IHistorianDataUpdater
methods; IHistorianDataSource.ReadModifiedAsync (default NotSupported =>
BadHistoryOperationUnsupported on Gateway/Null); HistoryModified* contracts.
- SqlServer: schema v2 (002_sample_modified.sql, RequiredVersion=2, docs copy);
trail written by OUTPUT ... INTO on the same MERGE/DELETE statement, so a
failed update leaves no audit row; retention purges SampleModified per tag on
the source-time cutoff; ReadModifiedAsync keyed on (SourceTimeUtc, ModifiedId).
- QuestDB: append-only {prefix}sample_modified (TTL like samples), trail row
written BEFORE the change (orphan-on-crash, never an untracked change);
existence reads now carry the prior value; ReadModifiedAsync.
- Node manager: modified reads dispatch + page via the #669 continuation store
(HistoryContinuationState gains HistoryCursorKind + LastModifiedId), gated by
the existing HistoryRead decision; session principal / key id passed to the
updater. IsDeleteModified stays unsupported.
- Client.CLI: historyread --modified.
- Tests: node-manager dispatch/paging/cursor binding/principal threading,
over-the-wire HistoryModifiedData, shared ModifiedValueConformance on both
backends, SqlServer atomicity (forced trail failure => no change) + v1->v2
upgrade + retention trail purge.
- Docs: Historian.md (Modified-value history section, schema v2 upgrade note),
security.md, Client.CLI.md, CLAUDE.md.
51 lines
2.4 KiB
C#
51 lines
2.4 KiB
C#
using Shouldly;
|
|
using Xunit;
|
|
using ZB.MOM.WW.OtOpcUa.Core.Abstractions;
|
|
using ZB.MOM.WW.OtOpcUa.Driver.Historian.Sql.Common;
|
|
|
|
namespace ZB.MOM.WW.OtOpcUa.Driver.Historian.QuestDb.IntegrationTests;
|
|
|
|
/// <summary>Soft-delete behaviour. The writer-redelivery case lives in T7 (<c>TombstoneTests.Redelivery.cs</c>).</summary>
|
|
[Collection(QuestDbCollection.Name)]
|
|
public sealed partial class TombstoneTests(QuestDbFixture fx)
|
|
{
|
|
private static readonly DateTime T0 = new(2026, 3, 1, 12, 0, 0, DateTimeKind.Utc);
|
|
|
|
[Fact]
|
|
public async Task Delete_then_raw_read_hides_the_row_and_leaves_a_NULL_valued_tombstone()
|
|
{
|
|
fx.SkipIfUnavailable();
|
|
var rig = UpdateTests.MakeRig(fx);
|
|
await rig.Updater.UpdateDataAsync("t", HistoryUpdateMode.Insert,
|
|
[UpdateTests.V(T0, 1), UpdateTests.V(T0.AddSeconds(1), 2)], UpdateTests.Who, default);
|
|
(await rig.Updater.DeleteAtTimeAsync("t", [T0], UpdateTests.Who, default)).ShouldBe([HistorianStatusCodes.Good]);
|
|
|
|
(await UpdateTests.RowsAsync(rig, "t", liveOnly: true)).Select(r => r.Num).ShouldBe([2d]);
|
|
var all = await UpdateTests.RowsAsync(rig, "t");
|
|
all.Count.ShouldBe(2); // the tombstone replaced the row in place (dedup upsert)
|
|
var tomb = all[0];
|
|
tomb.Deleted.ShouldBeTrue();
|
|
tomb.Num.ShouldBeNull();
|
|
tomb.Kind.ShouldBe((byte)0);
|
|
tomb.Status.ShouldBe((long)HistorianStatusCodes.BadNoData);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Insert_over_a_tombstone_reports_GoodEntryInserted_and_the_row_is_visible()
|
|
{
|
|
fx.SkipIfUnavailable();
|
|
var rig = UpdateTests.MakeRig(fx);
|
|
await rig.Updater.UpdateDataAsync("t", HistoryUpdateMode.Insert, [UpdateTests.V(T0, 1)], UpdateTests.Who, default);
|
|
await rig.Updater.DeleteAtTimeAsync("t", [T0], UpdateTests.Who, default);
|
|
|
|
(await rig.Updater.UpdateDataAsync("t", HistoryUpdateMode.Replace, [UpdateTests.V(T0, 5)], UpdateTests.Who, default))
|
|
.ShouldBe([HistorianStatusCodes.BadNoEntryExists]); // a tombstone is no entry for Replace
|
|
(await rig.Updater.UpdateDataAsync("t", HistoryUpdateMode.Insert, [UpdateTests.V(T0, 9)], UpdateTests.Who, default))
|
|
.ShouldBe([HistorianStatusCodes.GoodEntryInserted]);
|
|
var live = await UpdateTests.RowsAsync(rig, "t", liveOnly: true);
|
|
live.Count.ShouldBe(1);
|
|
live[0].Num.ShouldBe(9d);
|
|
live[0].Deleted.ShouldBeFalse();
|
|
}
|
|
}
|