Lands the data path that feeds the Phase 6.3 ServiceLevelCalculator shipped in PR #89. OPC UA node wiring (ServiceLevel variable + ServerUriArray + RedundancySupport) still deferred to task #147; peer-probe loops (Stream B.1/B.2 runtime layer beyond the calculator logic) deferred. Server.Redundancy additions: - RedundancyTopology record — immutable snapshot (ClusterId, SelfNodeId, SelfRole, Mode, Peers[], SelfApplicationUri). ServerUriArray() emits the OPC UA Part 4 §6.6.2.2 shape (self first, peers lexicographically by NodeId). RedundancyPeer record with per-peer Host/OpcUaPort/DashboardPort/ ApplicationUri so the follow-up peer-probe loops know where to probe. - ClusterTopologyLoader — pure fn from ServerCluster + ClusterNode[] to RedundancyTopology. Enforces Phase 6.3 Stream A.1 invariants: * At least one node per cluster. * At most 2 nodes (decision #83, v2.0 cap). * Every node belongs to the target cluster. * Unique ApplicationUri across the cluster (OPC UA Part 4 trust pin, decision #86). * At most 1 Primary per cluster in Warm/Hot modes (decision #84). * Self NodeId must be a member of the cluster. Violations throw InvalidTopologyException with a decision-ID-tagged message so operators know which invariant + what to fix. - RedundancyCoordinator singleton — holds the current topology + IsTopologyValid flag. InitializeAsync throws on invariant violation (startup fails fast). RefreshAsync logs + flips IsTopologyValid=false (runtime won't tear down a running server; ServiceLevelCalculator falls to InvalidTopology band = 2 which surfaces the problem to clients without crashing). CAS-style swap via Volatile.Write so readers always see a coherent snapshot. Tests (10 new ClusterTopologyLoaderTests): - Single-node standalone loads + empty peer list. - Two-node cluster loads self + peer. - ServerUriArray puts self first + peers sort lexicographically. - Empty-nodes throws. - Self-not-in-cluster throws. - Three-node cluster rejected with decision #83 message. - Duplicate ApplicationUri rejected with decision #86 shape reference. - Two Primaries in Warm mode rejected (decision #84 + runtime-band reference). - Cross-cluster node rejected. - None-mode allows any role mix (standalone clusters don't enforce Primary count). Full solution dotnet test: 1178 passing (was 1168, +10). Pre-existing Client.CLI Subscribe flake unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
164 lines
5.0 KiB
C#
164 lines
5.0 KiB
C#
using Shouldly;
|
|
using Xunit;
|
|
using ZB.MOM.WW.OtOpcUa.Configuration.Entities;
|
|
using ZB.MOM.WW.OtOpcUa.Configuration.Enums;
|
|
using ZB.MOM.WW.OtOpcUa.Server.Redundancy;
|
|
|
|
namespace ZB.MOM.WW.OtOpcUa.Server.Tests;
|
|
|
|
[Trait("Category", "Unit")]
|
|
public sealed class ClusterTopologyLoaderTests
|
|
{
|
|
private static ServerCluster Cluster(RedundancyMode mode = RedundancyMode.Warm) => new()
|
|
{
|
|
ClusterId = "c1",
|
|
Name = "Warsaw-West",
|
|
Enterprise = "zb",
|
|
Site = "warsaw-west",
|
|
RedundancyMode = mode,
|
|
CreatedBy = "test",
|
|
};
|
|
|
|
private static ClusterNode Node(string id, RedundancyRole role, string host, int port = 4840, string? appUri = null) => new()
|
|
{
|
|
NodeId = id,
|
|
ClusterId = "c1",
|
|
RedundancyRole = role,
|
|
Host = host,
|
|
OpcUaPort = port,
|
|
ApplicationUri = appUri ?? $"urn:{host}:OtOpcUa",
|
|
CreatedBy = "test",
|
|
};
|
|
|
|
[Fact]
|
|
public void SingleNode_Standalone_Loads()
|
|
{
|
|
var cluster = Cluster(RedundancyMode.None);
|
|
var nodes = new[] { Node("A", RedundancyRole.Standalone, "hostA") };
|
|
|
|
var topology = ClusterTopologyLoader.Load("A", cluster, nodes);
|
|
|
|
topology.SelfNodeId.ShouldBe("A");
|
|
topology.SelfRole.ShouldBe(RedundancyRole.Standalone);
|
|
topology.Peers.ShouldBeEmpty();
|
|
topology.SelfApplicationUri.ShouldBe("urn:hostA:OtOpcUa");
|
|
}
|
|
|
|
[Fact]
|
|
public void TwoNode_Cluster_LoadsSelfAndPeer()
|
|
{
|
|
var cluster = Cluster();
|
|
var nodes = new[]
|
|
{
|
|
Node("A", RedundancyRole.Primary, "hostA"),
|
|
Node("B", RedundancyRole.Secondary, "hostB"),
|
|
};
|
|
|
|
var topology = ClusterTopologyLoader.Load("A", cluster, nodes);
|
|
|
|
topology.SelfNodeId.ShouldBe("A");
|
|
topology.SelfRole.ShouldBe(RedundancyRole.Primary);
|
|
topology.Peers.Count.ShouldBe(1);
|
|
topology.Peers[0].NodeId.ShouldBe("B");
|
|
topology.Peers[0].Role.ShouldBe(RedundancyRole.Secondary);
|
|
}
|
|
|
|
[Fact]
|
|
public void ServerUriArray_Puts_Self_First_Peers_SortedLexicographically()
|
|
{
|
|
var cluster = Cluster();
|
|
var nodes = new[]
|
|
{
|
|
Node("A", RedundancyRole.Primary, "hostA", appUri: "urn:A"),
|
|
Node("B", RedundancyRole.Secondary, "hostB", appUri: "urn:B"),
|
|
};
|
|
|
|
var topology = ClusterTopologyLoader.Load("A", cluster, nodes);
|
|
|
|
topology.ServerUriArray().ShouldBe(["urn:A", "urn:B"]);
|
|
}
|
|
|
|
[Fact]
|
|
public void EmptyNodes_Throws()
|
|
{
|
|
Should.Throw<InvalidTopologyException>(
|
|
() => ClusterTopologyLoader.Load("A", Cluster(), []));
|
|
}
|
|
|
|
[Fact]
|
|
public void SelfNotInCluster_Throws()
|
|
{
|
|
var nodes = new[] { Node("B", RedundancyRole.Primary, "hostB") };
|
|
|
|
Should.Throw<InvalidTopologyException>(
|
|
() => ClusterTopologyLoader.Load("A-missing", Cluster(), nodes));
|
|
}
|
|
|
|
[Fact]
|
|
public void ThreeNodeCluster_Rejected_Per_Decision83()
|
|
{
|
|
var nodes = new[]
|
|
{
|
|
Node("A", RedundancyRole.Primary, "hostA"),
|
|
Node("B", RedundancyRole.Secondary, "hostB"),
|
|
Node("C", RedundancyRole.Secondary, "hostC"),
|
|
};
|
|
|
|
var ex = Should.Throw<InvalidTopologyException>(
|
|
() => ClusterTopologyLoader.Load("A", Cluster(), nodes));
|
|
ex.Message.ShouldContain("decision #83");
|
|
}
|
|
|
|
[Fact]
|
|
public void DuplicateApplicationUri_Rejected()
|
|
{
|
|
var nodes = new[]
|
|
{
|
|
Node("A", RedundancyRole.Primary, "hostA", appUri: "urn:shared"),
|
|
Node("B", RedundancyRole.Secondary, "hostB", appUri: "urn:shared"),
|
|
};
|
|
|
|
var ex = Should.Throw<InvalidTopologyException>(
|
|
() => ClusterTopologyLoader.Load("A", Cluster(), nodes));
|
|
ex.Message.ShouldContain("ApplicationUri");
|
|
}
|
|
|
|
[Fact]
|
|
public void TwoPrimaries_InWarmMode_Rejected()
|
|
{
|
|
var nodes = new[]
|
|
{
|
|
Node("A", RedundancyRole.Primary, "hostA"),
|
|
Node("B", RedundancyRole.Primary, "hostB"),
|
|
};
|
|
|
|
var ex = Should.Throw<InvalidTopologyException>(
|
|
() => ClusterTopologyLoader.Load("A", Cluster(RedundancyMode.Warm), nodes));
|
|
ex.Message.ShouldContain("2 Primary");
|
|
}
|
|
|
|
[Fact]
|
|
public void CrossCluster_Node_Rejected()
|
|
{
|
|
var foreign = Node("B", RedundancyRole.Secondary, "hostB");
|
|
foreign.ClusterId = "c-other";
|
|
|
|
var nodes = new[] { Node("A", RedundancyRole.Primary, "hostA"), foreign };
|
|
|
|
Should.Throw<InvalidTopologyException>(
|
|
() => ClusterTopologyLoader.Load("A", Cluster(), nodes));
|
|
}
|
|
|
|
[Fact]
|
|
public void None_Mode_Allows_Any_Role_Mix()
|
|
{
|
|
// Standalone clusters don't enforce Primary-count; operator can pick anything.
|
|
var cluster = Cluster(RedundancyMode.None);
|
|
var nodes = new[] { Node("A", RedundancyRole.Primary, "hostA") };
|
|
|
|
var topology = ClusterTopologyLoader.Load("A", cluster, nodes);
|
|
|
|
topology.Mode.ShouldBe(RedundancyMode.None);
|
|
}
|
|
}
|