Replaced the "ab_server PCCC upstream-broken" skip gate with the actual
root cause: libplctag's ab_server rejects empty CIP routing paths at the
unconnected-send layer before the PCCC dispatcher runs. Real SLC/
MicroLogix/PLC-5 hardware accepts empty paths (no backplane); ab_server
does not. With `/1,0` in place, N (Int16), F (Float32), and L (Int32)
file reads + writes round-trip cleanly across all three compose profiles.
## Fixture changes
- `AbLegacyServerFixture.cs`:
- Drop `AB_LEGACY_TRUST_WIRE` env var + the reachable-but-untrusted
skip branch. Fixture now only skips on TCP unreachability.
- Add `AB_LEGACY_CIP_PATH` env var (default `1,0`) + expose `CipPath`
property. Set `AB_LEGACY_CIP_PATH=` (empty) against real hardware.
- Shorter skip messages on the `[AbLegacyFact]` / `[AbLegacyTheory]`
attributes — one reason: endpoint not reachable.
- `AbLegacyReadSmokeTests.cs`:
- Device URI built from `sim.CipPath` instead of hardcoded empty path.
- New `AB_LEGACY_COMPOSE_PROFILE` env var filters the parametric
theory to the running container's family. Only one container binds
`:44818` at a time, so cross-family params would otherwise fail.
- `Slc500_write_then_read_round_trip` skips cleanly when the running
profile isn't `slc500`.
## E2E + seed + docs
- `scripts/e2e/test-ablegacy.ps1` — drop the `AB_LEGACY_TRUST_WIRE`
skip gate; synopsis calls out the `/1,0` vs empty cip-path split
between the Docker fixture and real hardware.
- `scripts/e2e/e2e-config.sample.json` — sample gateway flipped from
the hardware placeholder (`192.168.1.10`) to the Docker fixture
(`127.0.0.1/1,0`); comment rewritten.
- `scripts/e2e/README.md` — AB Legacy expected-matrix row goes from
SKIP to PASS.
- `scripts/smoke/seed-ablegacy-smoke.sql` — default HostAddress points
at the Docker fixture + header / footer text reflect the new state.
- `tests/.../Docker/README.md` — "Known limitations" section rewritten
to describe the cip-path gate (not a dispatcher gap); env-var table
picks up `AB_LEGACY_CIP_PATH` + `AB_LEGACY_COMPOSE_PROFILE`.
- `docs/drivers/AbLegacy-Test-Fixture.md` + `docs/drivers/README.md`
+ `docs/DriverClis.md` — flip status from blocked to functional;
residual bit-file-write gap (B3:0/5 → 0x803D0000) documented.
## Residual gap
Bit-file writes (`B3:0/5` style) surface `0x803D0000` against
`ab_server --plc=SLC500`; bit reads work. Non-blocking for smoke
coverage — N/F/L round-trip is enough. Real hardware / RSEmulate 500
for bit-write fidelity. Documented in `Docker/README.md` §"Known
limitations" + the `AbLegacy-Test-Fixture.md` follow-ups list.
## Verified
- Full-solution build: 0 errors, 334 pre-existing warnings.
- Integration suite passes per-profile with
`AB_LEGACY_COMPOSE_PROFILE=<slc500|micrologix|plc5>` + matching
compose container up.
- All four non-hardware e2e scripts (Modbus / AB CIP / AB Legacy / S7)
now 5/5 against the respective docker-compose fixtures.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
197 lines
8.4 KiB
C#
197 lines
8.4 KiB
C#
using System.Net.Sockets;
|
|
using Xunit;
|
|
using Xunit.Sdk;
|
|
using ZB.MOM.WW.OtOpcUa.Driver.AbLegacy.PlcFamilies;
|
|
|
|
namespace ZB.MOM.WW.OtOpcUa.Driver.AbLegacy.IntegrationTests;
|
|
|
|
/// <summary>
|
|
/// Reachability probe for the <c>ab_server</c> Docker container running in a PCCC
|
|
/// plc mode (<c>SLC500</c> / <c>Micrologix</c> / <c>PLC/5</c>). Same container image
|
|
/// the AB CIP integration suite uses — libplctag's <c>ab_server</c> supports both
|
|
/// CIP + PCCC families from one binary. Tests skip via
|
|
/// <see cref="AbLegacyFactAttribute"/> / <see cref="AbLegacyTheoryAttribute"/> when
|
|
/// the port isn't live, so <c>dotnet test</c> stays green on a fresh clone without
|
|
/// Docker running.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// Env-var overrides:
|
|
/// <list type="bullet">
|
|
/// <item><c>AB_LEGACY_ENDPOINT</c> — <c>host:port</c> of the PCCC-mode simulator.
|
|
/// Defaults to <c>localhost:44818</c> (EtherNet/IP port; ab_server's PCCC
|
|
/// emulation exposes PCCC-over-CIP on the same port as CIP itself).</item>
|
|
/// <item><c>AB_LEGACY_CIP_PATH</c> — routing path appended to the <c>ab://host:port/</c>
|
|
/// URI. Defaults to <c>1,0</c> (port-1/slot-0 backplane), required by ab_server
|
|
/// which rejects unconnected Send_RR_Data with an empty path at the CIP layer
|
|
/// before the PCCC dispatcher runs. Real SLC 5/05 / MicroLogix / PLC-5 hardware
|
|
/// use an empty path — set <c>AB_LEGACY_CIP_PATH=</c> (empty) when pointing at
|
|
/// real hardware.</item>
|
|
/// </list>
|
|
/// Distinct from <c>AB_SERVER_ENDPOINT</c> used by the AB CIP fixture so both
|
|
/// can point at different containers simultaneously during a combined test run.
|
|
/// </remarks>
|
|
public sealed class AbLegacyServerFixture : IAsyncLifetime
|
|
{
|
|
private const string EndpointEnvVar = "AB_LEGACY_ENDPOINT";
|
|
private const string CipPathEnvVar = "AB_LEGACY_CIP_PATH";
|
|
|
|
/// <summary>Standard EtherNet/IP port. PCCC-over-CIP rides on the same port as
|
|
/// native CIP; the differentiator is the <c>--plc</c> flag ab_server was started
|
|
/// with, not a different TCP listener.</summary>
|
|
public const int DefaultPort = 44818;
|
|
|
|
/// <summary>
|
|
/// ab_server rejects unconnected Send_RR_Data with an empty CIP routing path
|
|
/// at the CIP layer — the PCCC dispatcher never runs. <c>1,0</c> is the generic
|
|
/// port-1/slot-0 backplane path; any well-formed path passes the gate. Real
|
|
/// hardware (SLC 5/05 / MicroLogix / PLC-5) uses an empty path because there's
|
|
/// no backplane to cross, so point <c>AB_LEGACY_CIP_PATH=</c> (empty) at real
|
|
/// hardware to exercise the authentic wire semantics.
|
|
/// </summary>
|
|
public const string DefaultCipPath = "1,0";
|
|
|
|
public string Host { get; } = "127.0.0.1";
|
|
public int Port { get; } = DefaultPort;
|
|
|
|
/// <summary>CIP routing path portion of the device URI (after the <c>/</c> separator).
|
|
/// May be empty when targeting real hardware; non-empty against ab_server.</summary>
|
|
public string CipPath { get; } = DefaultCipPath;
|
|
|
|
public string? SkipReason { get; }
|
|
|
|
public AbLegacyServerFixture()
|
|
{
|
|
if (Environment.GetEnvironmentVariable(EndpointEnvVar) is { Length: > 0 } raw)
|
|
{
|
|
var parts = raw.Split(':', 2);
|
|
Host = parts[0];
|
|
if (parts.Length == 2 && int.TryParse(parts[1], out var p)) Port = p;
|
|
}
|
|
|
|
// Empty override is intentional (real hardware); treat `null` as "not set, use
|
|
// default" but preserve an explicit empty-string override.
|
|
var cipOverride = Environment.GetEnvironmentVariable(CipPathEnvVar);
|
|
if (cipOverride is not null) CipPath = cipOverride;
|
|
|
|
SkipReason = ResolveSkipReason(Host, Port);
|
|
}
|
|
|
|
public ValueTask InitializeAsync() => ValueTask.CompletedTask;
|
|
public ValueTask DisposeAsync() => ValueTask.CompletedTask;
|
|
|
|
/// <summary>
|
|
/// Used by <see cref="AbLegacyFactAttribute"/> + <see cref="AbLegacyTheoryAttribute"/>
|
|
/// during test-class construction — gates whether the test runs at all. Duplicates the
|
|
/// fixture logic because attribute ctors fire before the collection fixture instance
|
|
/// exists.
|
|
/// </summary>
|
|
public static bool IsServerAvailable()
|
|
{
|
|
var (host, port) = ResolveEndpoint();
|
|
return ResolveSkipReason(host, port) is null;
|
|
}
|
|
|
|
private static string? ResolveSkipReason(string host, int port)
|
|
{
|
|
if (!TcpProbe(host, port))
|
|
{
|
|
return $"AB Legacy PCCC endpoint at {host}:{port} not reachable within 2 s. " +
|
|
$"Start the Docker container (docker compose -f Docker/docker-compose.yml " +
|
|
$"--profile slc500 up -d), attach real hardware, or override {EndpointEnvVar}.";
|
|
}
|
|
return null;
|
|
}
|
|
|
|
private static (string Host, int Port) ResolveEndpoint()
|
|
{
|
|
var raw = Environment.GetEnvironmentVariable(EndpointEnvVar);
|
|
if (raw is null) return ("127.0.0.1", DefaultPort);
|
|
var parts = raw.Split(':', 2);
|
|
var port = parts.Length == 2 && int.TryParse(parts[1], out var p) ? p : DefaultPort;
|
|
return (parts[0], port);
|
|
}
|
|
|
|
private static bool TcpProbe(string host, int port)
|
|
{
|
|
try
|
|
{
|
|
using var client = new TcpClient();
|
|
var task = client.ConnectAsync(host, port);
|
|
return task.Wait(TimeSpan.FromSeconds(2)) && client.Connected;
|
|
}
|
|
catch { return false; }
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Per-family marker for the PCCC-mode compose profile a given test targets. The
|
|
/// compose file (<c>Docker/docker-compose.yml</c>) is the canonical source of truth
|
|
/// for which <c>--plc</c> mode + tags each family seeds; this record just ties a
|
|
/// family enum to its compose-profile name + operator-facing notes.
|
|
/// </summary>
|
|
public sealed record AbLegacyServerProfile(
|
|
AbLegacyPlcFamily Family,
|
|
string ComposeProfile,
|
|
string Notes);
|
|
|
|
/// <summary>Canonical profiles covering every PCCC family the driver supports.</summary>
|
|
public static class KnownProfiles
|
|
{
|
|
public static readonly AbLegacyServerProfile Slc500 = new(
|
|
Family: AbLegacyPlcFamily.Slc500,
|
|
ComposeProfile: "slc500",
|
|
Notes: "SLC 500 / 5/05 family. ab_server SLC500 mode covers N/F/B/L files.");
|
|
|
|
public static readonly AbLegacyServerProfile MicroLogix = new(
|
|
Family: AbLegacyPlcFamily.MicroLogix,
|
|
ComposeProfile: "micrologix",
|
|
Notes: "MicroLogix 1000 / 1100 / 1400. Shares N/F/B file-type coverage with SLC500; ST (ASCII strings) included.");
|
|
|
|
public static readonly AbLegacyServerProfile Plc5 = new(
|
|
Family: AbLegacyPlcFamily.Plc5,
|
|
ComposeProfile: "plc5",
|
|
Notes: "PLC-5 family. ab_server PLC/5 mode covers N/F/B; per-family quirks on ST / timer file layouts unit-tested only.");
|
|
|
|
public static IReadOnlyList<AbLegacyServerProfile> All { get; } =
|
|
[Slc500, MicroLogix, Plc5];
|
|
|
|
public static AbLegacyServerProfile ForFamily(AbLegacyPlcFamily family) =>
|
|
All.FirstOrDefault(p => p.Family == family)
|
|
?? throw new ArgumentOutOfRangeException(nameof(family), family, "No integration profile for this family.");
|
|
}
|
|
|
|
[Xunit.CollectionDefinition(Name)]
|
|
public sealed class AbLegacyServerCollection : Xunit.ICollectionFixture<AbLegacyServerFixture>
|
|
{
|
|
public const string Name = "AbLegacyServer";
|
|
}
|
|
|
|
/// <summary>
|
|
/// <c>[Fact]</c>-equivalent that skips when the PCCC endpoint isn't reachable.
|
|
/// See <see cref="AbLegacyServerFixture"/> for the exact skip semantics.
|
|
/// </summary>
|
|
public sealed class AbLegacyFactAttribute : FactAttribute
|
|
{
|
|
public AbLegacyFactAttribute()
|
|
{
|
|
if (!AbLegacyServerFixture.IsServerAvailable())
|
|
Skip = "AB Legacy PCCC endpoint not reachable. Start the Docker fixture " +
|
|
"(docker compose -f Docker/docker-compose.yml --profile slc500 up -d) " +
|
|
"or point AB_LEGACY_ENDPOINT at real hardware.";
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// <c>[Theory]</c>-equivalent with the same gate as <see cref="AbLegacyFactAttribute"/>.
|
|
/// </summary>
|
|
public sealed class AbLegacyTheoryAttribute : TheoryAttribute
|
|
{
|
|
public AbLegacyTheoryAttribute()
|
|
{
|
|
if (!AbLegacyServerFixture.IsServerAvailable())
|
|
Skip = "AB Legacy PCCC endpoint not reachable. Start the Docker fixture " +
|
|
"(docker compose -f Docker/docker-compose.yml --profile slc500 up -d) " +
|
|
"or point AB_LEGACY_ENDPOINT at real hardware.";
|
|
}
|
|
}
|