Phase 6.4 Stream B.2-B.4 server-side - EquipmentImportBatch staging + FinaliseBatch #106
@@ -0,0 +1,207 @@
|
|||||||
|
using Microsoft.EntityFrameworkCore;
|
||||||
|
using ZB.MOM.WW.OtOpcUa.Admin.Services;
|
||||||
|
using ZB.MOM.WW.OtOpcUa.Configuration;
|
||||||
|
using ZB.MOM.WW.OtOpcUa.Configuration.Entities;
|
||||||
|
|
||||||
|
namespace ZB.MOM.WW.OtOpcUa.Admin.Services;
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// Staged-import orchestrator per Phase 6.4 Stream B.2-B.4. Covers the four operator
|
||||||
|
/// actions: CreateBatch → StageRows (chunked) → FinaliseBatch (atomic apply into
|
||||||
|
/// <see cref="Equipment"/>) → DropBatch (rollback of pre-finalise state).
|
||||||
|
/// </summary>
|
||||||
|
/// <remarks>
|
||||||
|
/// <para>FinaliseBatch runs inside one EF transaction + bulk-inserts accepted rows into
|
||||||
|
/// <see cref="Equipment"/>. Rejected rows stay behind as audit evidence; the batch row
|
||||||
|
/// gains <see cref="EquipmentImportBatch.FinalisedAtUtc"/> so future writes know it's
|
||||||
|
/// archived. DropBatch removes the batch + its cascaded rows.</para>
|
||||||
|
///
|
||||||
|
/// <para>Idempotence: calling FinaliseBatch twice throws <see cref="ImportBatchAlreadyFinalisedException"/>
|
||||||
|
/// rather than double-inserting. Operator refreshes the admin page to see the first
|
||||||
|
/// finalise completed.</para>
|
||||||
|
///
|
||||||
|
/// <para>ExternalIdReservation merging (ZTag + SAPID uniqueness) is NOT done here — a
|
||||||
|
/// narrower follow-up wires it once the concurrent-insert test matrix is green.</para>
|
||||||
|
/// </remarks>
|
||||||
|
public sealed class EquipmentImportBatchService(OtOpcUaConfigDbContext db)
|
||||||
|
{
|
||||||
|
/// <summary>Create a new empty batch header. Returns the row with Id populated.</summary>
|
||||||
|
public async Task<EquipmentImportBatch> CreateBatchAsync(string clusterId, string createdBy, CancellationToken ct)
|
||||||
|
{
|
||||||
|
ArgumentException.ThrowIfNullOrWhiteSpace(clusterId);
|
||||||
|
ArgumentException.ThrowIfNullOrWhiteSpace(createdBy);
|
||||||
|
|
||||||
|
var batch = new EquipmentImportBatch
|
||||||
|
{
|
||||||
|
Id = Guid.NewGuid(),
|
||||||
|
ClusterId = clusterId,
|
||||||
|
CreatedBy = createdBy,
|
||||||
|
CreatedAtUtc = DateTime.UtcNow,
|
||||||
|
};
|
||||||
|
db.EquipmentImportBatches.Add(batch);
|
||||||
|
await db.SaveChangesAsync(ct).ConfigureAwait(false);
|
||||||
|
return batch;
|
||||||
|
}
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// Stage one chunk of rows into the batch. Caller usually feeds
|
||||||
|
/// <see cref="EquipmentCsvImporter.Parse"/> output here — each
|
||||||
|
/// <see cref="EquipmentCsvRow"/> becomes one accepted <see cref="EquipmentImportRow"/>,
|
||||||
|
/// each rejected parser error becomes one row with <see cref="EquipmentImportRow.IsAccepted"/> false.
|
||||||
|
/// </summary>
|
||||||
|
public async Task StageRowsAsync(
|
||||||
|
Guid batchId,
|
||||||
|
IReadOnlyList<EquipmentCsvRow> acceptedRows,
|
||||||
|
IReadOnlyList<EquipmentCsvRowError> rejectedRows,
|
||||||
|
CancellationToken ct)
|
||||||
|
{
|
||||||
|
var batch = await db.EquipmentImportBatches.FirstOrDefaultAsync(b => b.Id == batchId, ct).ConfigureAwait(false)
|
||||||
|
?? throw new ImportBatchNotFoundException($"Batch {batchId} not found.");
|
||||||
|
|
||||||
|
if (batch.FinalisedAtUtc is not null)
|
||||||
|
throw new ImportBatchAlreadyFinalisedException(
|
||||||
|
$"Batch {batchId} finalised at {batch.FinalisedAtUtc:o}; no more rows can be staged.");
|
||||||
|
|
||||||
|
foreach (var row in acceptedRows)
|
||||||
|
{
|
||||||
|
db.EquipmentImportRows.Add(new EquipmentImportRow
|
||||||
|
{
|
||||||
|
Id = Guid.NewGuid(),
|
||||||
|
BatchId = batchId,
|
||||||
|
IsAccepted = true,
|
||||||
|
ZTag = row.ZTag,
|
||||||
|
MachineCode = row.MachineCode,
|
||||||
|
SAPID = row.SAPID,
|
||||||
|
EquipmentId = row.EquipmentId,
|
||||||
|
EquipmentUuid = row.EquipmentUuid,
|
||||||
|
Name = row.Name,
|
||||||
|
UnsAreaName = row.UnsAreaName,
|
||||||
|
UnsLineName = row.UnsLineName,
|
||||||
|
Manufacturer = row.Manufacturer,
|
||||||
|
Model = row.Model,
|
||||||
|
SerialNumber = row.SerialNumber,
|
||||||
|
HardwareRevision = row.HardwareRevision,
|
||||||
|
SoftwareRevision = row.SoftwareRevision,
|
||||||
|
YearOfConstruction = row.YearOfConstruction,
|
||||||
|
AssetLocation = row.AssetLocation,
|
||||||
|
ManufacturerUri = row.ManufacturerUri,
|
||||||
|
DeviceManualUri = row.DeviceManualUri,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
foreach (var error in rejectedRows)
|
||||||
|
{
|
||||||
|
db.EquipmentImportRows.Add(new EquipmentImportRow
|
||||||
|
{
|
||||||
|
Id = Guid.NewGuid(),
|
||||||
|
BatchId = batchId,
|
||||||
|
IsAccepted = false,
|
||||||
|
RejectReason = error.Reason,
|
||||||
|
LineNumberInFile = error.LineNumber,
|
||||||
|
// Required columns need values for EF; reject rows use sentinel placeholders.
|
||||||
|
ZTag = "", MachineCode = "", SAPID = "", EquipmentId = "", EquipmentUuid = "",
|
||||||
|
Name = "", UnsAreaName = "", UnsLineName = "",
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
batch.RowsStaged += acceptedRows.Count + rejectedRows.Count;
|
||||||
|
batch.RowsAccepted += acceptedRows.Count;
|
||||||
|
batch.RowsRejected += rejectedRows.Count;
|
||||||
|
|
||||||
|
await db.SaveChangesAsync(ct).ConfigureAwait(false);
|
||||||
|
}
|
||||||
|
|
||||||
|
/// <summary>Drop the batch (pre-finalise rollback). Cascaded row delete removes staged rows.</summary>
|
||||||
|
public async Task DropBatchAsync(Guid batchId, CancellationToken ct)
|
||||||
|
{
|
||||||
|
var batch = await db.EquipmentImportBatches.FirstOrDefaultAsync(b => b.Id == batchId, ct).ConfigureAwait(false);
|
||||||
|
if (batch is null) return;
|
||||||
|
if (batch.FinalisedAtUtc is not null)
|
||||||
|
throw new ImportBatchAlreadyFinalisedException(
|
||||||
|
$"Batch {batchId} already finalised at {batch.FinalisedAtUtc:o}; cannot drop.");
|
||||||
|
|
||||||
|
db.EquipmentImportBatches.Remove(batch);
|
||||||
|
await db.SaveChangesAsync(ct).ConfigureAwait(false);
|
||||||
|
}
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// Atomic finalise. Inserts every accepted row into the live
|
||||||
|
/// <see cref="Equipment"/> table under the target generation + stamps
|
||||||
|
/// <see cref="EquipmentImportBatch.FinalisedAtUtc"/>. Failure rolls the whole tx
|
||||||
|
/// back — <see cref="Equipment"/> never partially mutates.
|
||||||
|
/// </summary>
|
||||||
|
public async Task FinaliseBatchAsync(
|
||||||
|
Guid batchId, long generationId, string driverInstanceIdForRows, string unsLineIdForRows, CancellationToken ct)
|
||||||
|
{
|
||||||
|
var batch = await db.EquipmentImportBatches
|
||||||
|
.Include(b => b.Rows)
|
||||||
|
.FirstOrDefaultAsync(b => b.Id == batchId, ct)
|
||||||
|
.ConfigureAwait(false)
|
||||||
|
?? throw new ImportBatchNotFoundException($"Batch {batchId} not found.");
|
||||||
|
|
||||||
|
if (batch.FinalisedAtUtc is not null)
|
||||||
|
throw new ImportBatchAlreadyFinalisedException(
|
||||||
|
$"Batch {batchId} already finalised at {batch.FinalisedAtUtc:o}.");
|
||||||
|
|
||||||
|
// EF InMemory provider doesn't honour BeginTransaction; SQL Server provider does.
|
||||||
|
// Tests run the happy path under in-memory; production SQL Server runs the atomic tx.
|
||||||
|
var supportsTx = db.Database.IsRelational();
|
||||||
|
Microsoft.EntityFrameworkCore.Storage.IDbContextTransaction? tx = null;
|
||||||
|
if (supportsTx)
|
||||||
|
tx = await db.Database.BeginTransactionAsync(ct).ConfigureAwait(false);
|
||||||
|
|
||||||
|
try
|
||||||
|
{
|
||||||
|
foreach (var row in batch.Rows.Where(r => r.IsAccepted))
|
||||||
|
{
|
||||||
|
db.Equipment.Add(new Equipment
|
||||||
|
{
|
||||||
|
EquipmentRowId = Guid.NewGuid(),
|
||||||
|
GenerationId = generationId,
|
||||||
|
EquipmentId = row.EquipmentId,
|
||||||
|
EquipmentUuid = Guid.TryParse(row.EquipmentUuid, out var u) ? u : Guid.NewGuid(),
|
||||||
|
DriverInstanceId = driverInstanceIdForRows,
|
||||||
|
UnsLineId = unsLineIdForRows,
|
||||||
|
Name = row.Name,
|
||||||
|
MachineCode = row.MachineCode,
|
||||||
|
ZTag = row.ZTag,
|
||||||
|
SAPID = row.SAPID,
|
||||||
|
Manufacturer = row.Manufacturer,
|
||||||
|
Model = row.Model,
|
||||||
|
SerialNumber = row.SerialNumber,
|
||||||
|
HardwareRevision = row.HardwareRevision,
|
||||||
|
SoftwareRevision = row.SoftwareRevision,
|
||||||
|
YearOfConstruction = short.TryParse(row.YearOfConstruction, out var y) ? y : null,
|
||||||
|
AssetLocation = row.AssetLocation,
|
||||||
|
ManufacturerUri = row.ManufacturerUri,
|
||||||
|
DeviceManualUri = row.DeviceManualUri,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
batch.FinalisedAtUtc = DateTime.UtcNow;
|
||||||
|
await db.SaveChangesAsync(ct).ConfigureAwait(false);
|
||||||
|
if (tx is not null) await tx.CommitAsync(ct).ConfigureAwait(false);
|
||||||
|
}
|
||||||
|
catch
|
||||||
|
{
|
||||||
|
if (tx is not null) await tx.RollbackAsync(ct).ConfigureAwait(false);
|
||||||
|
throw;
|
||||||
|
}
|
||||||
|
finally
|
||||||
|
{
|
||||||
|
if (tx is not null) await tx.DisposeAsync().ConfigureAwait(false);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/// <summary>List batches created by the given user. Finalised batches are archived; include them on demand.</summary>
|
||||||
|
public async Task<IReadOnlyList<EquipmentImportBatch>> ListByUserAsync(string createdBy, bool includeFinalised, CancellationToken ct)
|
||||||
|
{
|
||||||
|
var query = db.EquipmentImportBatches.AsNoTracking().Where(b => b.CreatedBy == createdBy);
|
||||||
|
if (!includeFinalised)
|
||||||
|
query = query.Where(b => b.FinalisedAtUtc == null);
|
||||||
|
return await query.OrderByDescending(b => b.CreatedAtUtc).ToListAsync(ct).ConfigureAwait(false);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
public sealed class ImportBatchNotFoundException(string message) : Exception(message);
|
||||||
|
public sealed class ImportBatchAlreadyFinalisedException(string message) : Exception(message);
|
||||||
@@ -0,0 +1,68 @@
|
|||||||
|
namespace ZB.MOM.WW.OtOpcUa.Configuration.Entities;
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// Staged equipment-import batch per Phase 6.4 Stream B.2. Rows land in the child
|
||||||
|
/// <see cref="EquipmentImportRow"/> table under a batch header; operator reviews + either
|
||||||
|
/// drops (via <c>DropImportBatch</c>) or finalises (via <c>FinaliseImportBatch</c>) in one
|
||||||
|
/// bounded transaction. The live <c>Equipment</c> table never sees partial state.
|
||||||
|
/// </summary>
|
||||||
|
/// <remarks>
|
||||||
|
/// <para>User-scoped visibility: the preview modal only shows batches where
|
||||||
|
/// <see cref="CreatedBy"/> equals the current operator. Prevents accidental
|
||||||
|
/// cross-operator finalise during concurrent imports. An admin finalise / drop surface
|
||||||
|
/// can override this — tracked alongside the UI follow-up.</para>
|
||||||
|
///
|
||||||
|
/// <para><see cref="FinalisedAtUtc"/> stamps the moment the batch promoted from staging
|
||||||
|
/// into <c>Equipment</c>. Null = still in staging; non-null = archived / finalised.</para>
|
||||||
|
/// </remarks>
|
||||||
|
public sealed class EquipmentImportBatch
|
||||||
|
{
|
||||||
|
public Guid Id { get; set; }
|
||||||
|
public required string ClusterId { get; set; }
|
||||||
|
public required string CreatedBy { get; set; }
|
||||||
|
public DateTime CreatedAtUtc { get; set; }
|
||||||
|
public int RowsStaged { get; set; }
|
||||||
|
public int RowsAccepted { get; set; }
|
||||||
|
public int RowsRejected { get; set; }
|
||||||
|
public DateTime? FinalisedAtUtc { get; set; }
|
||||||
|
|
||||||
|
public ICollection<EquipmentImportRow> Rows { get; set; } = [];
|
||||||
|
}
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// One staged row under an <see cref="EquipmentImportBatch"/>. Mirrors the decision #117
|
||||||
|
/// + decision #139 columns from the CSV importer's output + an
|
||||||
|
/// <see cref="IsAccepted"/> flag + a <see cref="RejectReason"/> string the preview modal
|
||||||
|
/// renders.
|
||||||
|
/// </summary>
|
||||||
|
public sealed class EquipmentImportRow
|
||||||
|
{
|
||||||
|
public Guid Id { get; set; }
|
||||||
|
public Guid BatchId { get; set; }
|
||||||
|
public int LineNumberInFile { get; set; }
|
||||||
|
public bool IsAccepted { get; set; }
|
||||||
|
public string? RejectReason { get; set; }
|
||||||
|
|
||||||
|
// Required (decision #117)
|
||||||
|
public required string ZTag { get; set; }
|
||||||
|
public required string MachineCode { get; set; }
|
||||||
|
public required string SAPID { get; set; }
|
||||||
|
public required string EquipmentId { get; set; }
|
||||||
|
public required string EquipmentUuid { get; set; }
|
||||||
|
public required string Name { get; set; }
|
||||||
|
public required string UnsAreaName { get; set; }
|
||||||
|
public required string UnsLineName { get; set; }
|
||||||
|
|
||||||
|
// Optional (decision #139 — OPC 40010 Identification)
|
||||||
|
public string? Manufacturer { get; set; }
|
||||||
|
public string? Model { get; set; }
|
||||||
|
public string? SerialNumber { get; set; }
|
||||||
|
public string? HardwareRevision { get; set; }
|
||||||
|
public string? SoftwareRevision { get; set; }
|
||||||
|
public string? YearOfConstruction { get; set; }
|
||||||
|
public string? AssetLocation { get; set; }
|
||||||
|
public string? ManufacturerUri { get; set; }
|
||||||
|
public string? DeviceManualUri { get; set; }
|
||||||
|
|
||||||
|
public EquipmentImportBatch? Batch { get; set; }
|
||||||
|
}
|
||||||
1505
src/ZB.MOM.WW.OtOpcUa.Configuration/Migrations/20260419185124_AddEquipmentImportBatch.Designer.cs
generated
Normal file
1505
src/ZB.MOM.WW.OtOpcUa.Configuration/Migrations/20260419185124_AddEquipmentImportBatch.Designer.cs
generated
Normal file
File diff suppressed because it is too large
Load Diff
@@ -0,0 +1,91 @@
|
|||||||
|
using System;
|
||||||
|
using Microsoft.EntityFrameworkCore.Migrations;
|
||||||
|
|
||||||
|
#nullable disable
|
||||||
|
|
||||||
|
namespace ZB.MOM.WW.OtOpcUa.Configuration.Migrations
|
||||||
|
{
|
||||||
|
/// <inheritdoc />
|
||||||
|
public partial class AddEquipmentImportBatch : Migration
|
||||||
|
{
|
||||||
|
/// <inheritdoc />
|
||||||
|
protected override void Up(MigrationBuilder migrationBuilder)
|
||||||
|
{
|
||||||
|
migrationBuilder.CreateTable(
|
||||||
|
name: "EquipmentImportBatch",
|
||||||
|
columns: table => new
|
||||||
|
{
|
||||||
|
Id = table.Column<Guid>(type: "uniqueidentifier", nullable: false),
|
||||||
|
ClusterId = table.Column<string>(type: "nvarchar(64)", maxLength: 64, nullable: false),
|
||||||
|
CreatedBy = table.Column<string>(type: "nvarchar(128)", maxLength: 128, nullable: false),
|
||||||
|
CreatedAtUtc = table.Column<DateTime>(type: "datetime2(3)", nullable: false),
|
||||||
|
RowsStaged = table.Column<int>(type: "int", nullable: false),
|
||||||
|
RowsAccepted = table.Column<int>(type: "int", nullable: false),
|
||||||
|
RowsRejected = table.Column<int>(type: "int", nullable: false),
|
||||||
|
FinalisedAtUtc = table.Column<DateTime>(type: "datetime2(3)", nullable: true)
|
||||||
|
},
|
||||||
|
constraints: table =>
|
||||||
|
{
|
||||||
|
table.PrimaryKey("PK_EquipmentImportBatch", x => x.Id);
|
||||||
|
});
|
||||||
|
|
||||||
|
migrationBuilder.CreateTable(
|
||||||
|
name: "EquipmentImportRow",
|
||||||
|
columns: table => new
|
||||||
|
{
|
||||||
|
Id = table.Column<Guid>(type: "uniqueidentifier", nullable: false),
|
||||||
|
BatchId = table.Column<Guid>(type: "uniqueidentifier", nullable: false),
|
||||||
|
LineNumberInFile = table.Column<int>(type: "int", nullable: false),
|
||||||
|
IsAccepted = table.Column<bool>(type: "bit", nullable: false),
|
||||||
|
RejectReason = table.Column<string>(type: "nvarchar(512)", maxLength: 512, nullable: true),
|
||||||
|
ZTag = table.Column<string>(type: "nvarchar(128)", maxLength: 128, nullable: false),
|
||||||
|
MachineCode = table.Column<string>(type: "nvarchar(128)", maxLength: 128, nullable: false),
|
||||||
|
SAPID = table.Column<string>(type: "nvarchar(128)", maxLength: 128, nullable: false),
|
||||||
|
EquipmentId = table.Column<string>(type: "nvarchar(64)", maxLength: 64, nullable: false),
|
||||||
|
EquipmentUuid = table.Column<string>(type: "nvarchar(64)", maxLength: 64, nullable: false),
|
||||||
|
Name = table.Column<string>(type: "nvarchar(128)", maxLength: 128, nullable: false),
|
||||||
|
UnsAreaName = table.Column<string>(type: "nvarchar(64)", maxLength: 64, nullable: false),
|
||||||
|
UnsLineName = table.Column<string>(type: "nvarchar(64)", maxLength: 64, nullable: false),
|
||||||
|
Manufacturer = table.Column<string>(type: "nvarchar(256)", maxLength: 256, nullable: true),
|
||||||
|
Model = table.Column<string>(type: "nvarchar(256)", maxLength: 256, nullable: true),
|
||||||
|
SerialNumber = table.Column<string>(type: "nvarchar(256)", maxLength: 256, nullable: true),
|
||||||
|
HardwareRevision = table.Column<string>(type: "nvarchar(64)", maxLength: 64, nullable: true),
|
||||||
|
SoftwareRevision = table.Column<string>(type: "nvarchar(64)", maxLength: 64, nullable: true),
|
||||||
|
YearOfConstruction = table.Column<string>(type: "nvarchar(8)", maxLength: 8, nullable: true),
|
||||||
|
AssetLocation = table.Column<string>(type: "nvarchar(512)", maxLength: 512, nullable: true),
|
||||||
|
ManufacturerUri = table.Column<string>(type: "nvarchar(512)", maxLength: 512, nullable: true),
|
||||||
|
DeviceManualUri = table.Column<string>(type: "nvarchar(512)", maxLength: 512, nullable: true)
|
||||||
|
},
|
||||||
|
constraints: table =>
|
||||||
|
{
|
||||||
|
table.PrimaryKey("PK_EquipmentImportRow", x => x.Id);
|
||||||
|
table.ForeignKey(
|
||||||
|
name: "FK_EquipmentImportRow_EquipmentImportBatch_BatchId",
|
||||||
|
column: x => x.BatchId,
|
||||||
|
principalTable: "EquipmentImportBatch",
|
||||||
|
principalColumn: "Id",
|
||||||
|
onDelete: ReferentialAction.Cascade);
|
||||||
|
});
|
||||||
|
|
||||||
|
migrationBuilder.CreateIndex(
|
||||||
|
name: "IX_EquipmentImportBatch_Creator_Finalised",
|
||||||
|
table: "EquipmentImportBatch",
|
||||||
|
columns: new[] { "CreatedBy", "FinalisedAtUtc" });
|
||||||
|
|
||||||
|
migrationBuilder.CreateIndex(
|
||||||
|
name: "IX_EquipmentImportRow_Batch",
|
||||||
|
table: "EquipmentImportRow",
|
||||||
|
column: "BatchId");
|
||||||
|
}
|
||||||
|
|
||||||
|
/// <inheritdoc />
|
||||||
|
protected override void Down(MigrationBuilder migrationBuilder)
|
||||||
|
{
|
||||||
|
migrationBuilder.DropTable(
|
||||||
|
name: "EquipmentImportRow");
|
||||||
|
|
||||||
|
migrationBuilder.DropTable(
|
||||||
|
name: "EquipmentImportBatch");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -604,6 +604,148 @@ namespace ZB.MOM.WW.OtOpcUa.Configuration.Migrations
|
|||||||
b.ToTable("Equipment", (string)null);
|
b.ToTable("Equipment", (string)null);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ZB.MOM.WW.OtOpcUa.Configuration.Entities.EquipmentImportBatch", b =>
|
||||||
|
{
|
||||||
|
b.Property<Guid>("Id")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("uniqueidentifier");
|
||||||
|
|
||||||
|
b.Property<string>("ClusterId")
|
||||||
|
.IsRequired()
|
||||||
|
.HasMaxLength(64)
|
||||||
|
.HasColumnType("nvarchar(64)");
|
||||||
|
|
||||||
|
b.Property<DateTime>("CreatedAtUtc")
|
||||||
|
.HasColumnType("datetime2(3)");
|
||||||
|
|
||||||
|
b.Property<string>("CreatedBy")
|
||||||
|
.IsRequired()
|
||||||
|
.HasMaxLength(128)
|
||||||
|
.HasColumnType("nvarchar(128)");
|
||||||
|
|
||||||
|
b.Property<DateTime?>("FinalisedAtUtc")
|
||||||
|
.HasColumnType("datetime2(3)");
|
||||||
|
|
||||||
|
b.Property<int>("RowsAccepted")
|
||||||
|
.HasColumnType("int");
|
||||||
|
|
||||||
|
b.Property<int>("RowsRejected")
|
||||||
|
.HasColumnType("int");
|
||||||
|
|
||||||
|
b.Property<int>("RowsStaged")
|
||||||
|
.HasColumnType("int");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.HasIndex("CreatedBy", "FinalisedAtUtc")
|
||||||
|
.HasDatabaseName("IX_EquipmentImportBatch_Creator_Finalised");
|
||||||
|
|
||||||
|
b.ToTable("EquipmentImportBatch", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ZB.MOM.WW.OtOpcUa.Configuration.Entities.EquipmentImportRow", b =>
|
||||||
|
{
|
||||||
|
b.Property<Guid>("Id")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("uniqueidentifier");
|
||||||
|
|
||||||
|
b.Property<string>("AssetLocation")
|
||||||
|
.HasMaxLength(512)
|
||||||
|
.HasColumnType("nvarchar(512)");
|
||||||
|
|
||||||
|
b.Property<Guid>("BatchId")
|
||||||
|
.HasColumnType("uniqueidentifier");
|
||||||
|
|
||||||
|
b.Property<string>("DeviceManualUri")
|
||||||
|
.HasMaxLength(512)
|
||||||
|
.HasColumnType("nvarchar(512)");
|
||||||
|
|
||||||
|
b.Property<string>("EquipmentId")
|
||||||
|
.IsRequired()
|
||||||
|
.HasMaxLength(64)
|
||||||
|
.HasColumnType("nvarchar(64)");
|
||||||
|
|
||||||
|
b.Property<string>("EquipmentUuid")
|
||||||
|
.IsRequired()
|
||||||
|
.HasMaxLength(64)
|
||||||
|
.HasColumnType("nvarchar(64)");
|
||||||
|
|
||||||
|
b.Property<string>("HardwareRevision")
|
||||||
|
.HasMaxLength(64)
|
||||||
|
.HasColumnType("nvarchar(64)");
|
||||||
|
|
||||||
|
b.Property<bool>("IsAccepted")
|
||||||
|
.HasColumnType("bit");
|
||||||
|
|
||||||
|
b.Property<int>("LineNumberInFile")
|
||||||
|
.HasColumnType("int");
|
||||||
|
|
||||||
|
b.Property<string>("MachineCode")
|
||||||
|
.IsRequired()
|
||||||
|
.HasMaxLength(128)
|
||||||
|
.HasColumnType("nvarchar(128)");
|
||||||
|
|
||||||
|
b.Property<string>("Manufacturer")
|
||||||
|
.HasMaxLength(256)
|
||||||
|
.HasColumnType("nvarchar(256)");
|
||||||
|
|
||||||
|
b.Property<string>("ManufacturerUri")
|
||||||
|
.HasMaxLength(512)
|
||||||
|
.HasColumnType("nvarchar(512)");
|
||||||
|
|
||||||
|
b.Property<string>("Model")
|
||||||
|
.HasMaxLength(256)
|
||||||
|
.HasColumnType("nvarchar(256)");
|
||||||
|
|
||||||
|
b.Property<string>("Name")
|
||||||
|
.IsRequired()
|
||||||
|
.HasMaxLength(128)
|
||||||
|
.HasColumnType("nvarchar(128)");
|
||||||
|
|
||||||
|
b.Property<string>("RejectReason")
|
||||||
|
.HasMaxLength(512)
|
||||||
|
.HasColumnType("nvarchar(512)");
|
||||||
|
|
||||||
|
b.Property<string>("SAPID")
|
||||||
|
.IsRequired()
|
||||||
|
.HasMaxLength(128)
|
||||||
|
.HasColumnType("nvarchar(128)");
|
||||||
|
|
||||||
|
b.Property<string>("SerialNumber")
|
||||||
|
.HasMaxLength(256)
|
||||||
|
.HasColumnType("nvarchar(256)");
|
||||||
|
|
||||||
|
b.Property<string>("SoftwareRevision")
|
||||||
|
.HasMaxLength(64)
|
||||||
|
.HasColumnType("nvarchar(64)");
|
||||||
|
|
||||||
|
b.Property<string>("UnsAreaName")
|
||||||
|
.IsRequired()
|
||||||
|
.HasMaxLength(64)
|
||||||
|
.HasColumnType("nvarchar(64)");
|
||||||
|
|
||||||
|
b.Property<string>("UnsLineName")
|
||||||
|
.IsRequired()
|
||||||
|
.HasMaxLength(64)
|
||||||
|
.HasColumnType("nvarchar(64)");
|
||||||
|
|
||||||
|
b.Property<string>("YearOfConstruction")
|
||||||
|
.HasMaxLength(8)
|
||||||
|
.HasColumnType("nvarchar(8)");
|
||||||
|
|
||||||
|
b.Property<string>("ZTag")
|
||||||
|
.IsRequired()
|
||||||
|
.HasMaxLength(128)
|
||||||
|
.HasColumnType("nvarchar(128)");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.HasIndex("BatchId")
|
||||||
|
.HasDatabaseName("IX_EquipmentImportRow_Batch");
|
||||||
|
|
||||||
|
b.ToTable("EquipmentImportRow", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
modelBuilder.Entity("ZB.MOM.WW.OtOpcUa.Configuration.Entities.ExternalIdReservation", b =>
|
modelBuilder.Entity("ZB.MOM.WW.OtOpcUa.Configuration.Entities.ExternalIdReservation", b =>
|
||||||
{
|
{
|
||||||
b.Property<Guid>("ReservationId")
|
b.Property<Guid>("ReservationId")
|
||||||
@@ -1231,6 +1373,17 @@ namespace ZB.MOM.WW.OtOpcUa.Configuration.Migrations
|
|||||||
b.Navigation("Generation");
|
b.Navigation("Generation");
|
||||||
});
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ZB.MOM.WW.OtOpcUa.Configuration.Entities.EquipmentImportRow", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ZB.MOM.WW.OtOpcUa.Configuration.Entities.EquipmentImportBatch", "Batch")
|
||||||
|
.WithMany("Rows")
|
||||||
|
.HasForeignKey("BatchId")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.Navigation("Batch");
|
||||||
|
});
|
||||||
|
|
||||||
modelBuilder.Entity("ZB.MOM.WW.OtOpcUa.Configuration.Entities.LdapGroupRoleMapping", b =>
|
modelBuilder.Entity("ZB.MOM.WW.OtOpcUa.Configuration.Entities.LdapGroupRoleMapping", b =>
|
||||||
{
|
{
|
||||||
b.HasOne("ZB.MOM.WW.OtOpcUa.Configuration.Entities.ServerCluster", "Cluster")
|
b.HasOne("ZB.MOM.WW.OtOpcUa.Configuration.Entities.ServerCluster", "Cluster")
|
||||||
@@ -1330,6 +1483,11 @@ namespace ZB.MOM.WW.OtOpcUa.Configuration.Migrations
|
|||||||
b.Navigation("GenerationState");
|
b.Navigation("GenerationState");
|
||||||
});
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ZB.MOM.WW.OtOpcUa.Configuration.Entities.EquipmentImportBatch", b =>
|
||||||
|
{
|
||||||
|
b.Navigation("Rows");
|
||||||
|
});
|
||||||
|
|
||||||
modelBuilder.Entity("ZB.MOM.WW.OtOpcUa.Configuration.Entities.ServerCluster", b =>
|
modelBuilder.Entity("ZB.MOM.WW.OtOpcUa.Configuration.Entities.ServerCluster", b =>
|
||||||
{
|
{
|
||||||
b.Navigation("Generations");
|
b.Navigation("Generations");
|
||||||
|
|||||||
@@ -30,6 +30,8 @@ public sealed class OtOpcUaConfigDbContext(DbContextOptions<OtOpcUaConfigDbConte
|
|||||||
public DbSet<DriverHostStatus> DriverHostStatuses => Set<DriverHostStatus>();
|
public DbSet<DriverHostStatus> DriverHostStatuses => Set<DriverHostStatus>();
|
||||||
public DbSet<DriverInstanceResilienceStatus> DriverInstanceResilienceStatuses => Set<DriverInstanceResilienceStatus>();
|
public DbSet<DriverInstanceResilienceStatus> DriverInstanceResilienceStatuses => Set<DriverInstanceResilienceStatus>();
|
||||||
public DbSet<LdapGroupRoleMapping> LdapGroupRoleMappings => Set<LdapGroupRoleMapping>();
|
public DbSet<LdapGroupRoleMapping> LdapGroupRoleMappings => Set<LdapGroupRoleMapping>();
|
||||||
|
public DbSet<EquipmentImportBatch> EquipmentImportBatches => Set<EquipmentImportBatch>();
|
||||||
|
public DbSet<EquipmentImportRow> EquipmentImportRows => Set<EquipmentImportRow>();
|
||||||
|
|
||||||
protected override void OnModelCreating(ModelBuilder modelBuilder)
|
protected override void OnModelCreating(ModelBuilder modelBuilder)
|
||||||
{
|
{
|
||||||
@@ -53,6 +55,7 @@ public sealed class OtOpcUaConfigDbContext(DbContextOptions<OtOpcUaConfigDbConte
|
|||||||
ConfigureDriverHostStatus(modelBuilder);
|
ConfigureDriverHostStatus(modelBuilder);
|
||||||
ConfigureDriverInstanceResilienceStatus(modelBuilder);
|
ConfigureDriverInstanceResilienceStatus(modelBuilder);
|
||||||
ConfigureLdapGroupRoleMapping(modelBuilder);
|
ConfigureLdapGroupRoleMapping(modelBuilder);
|
||||||
|
ConfigureEquipmentImportBatch(modelBuilder);
|
||||||
}
|
}
|
||||||
|
|
||||||
private static void ConfigureServerCluster(ModelBuilder modelBuilder)
|
private static void ConfigureServerCluster(ModelBuilder modelBuilder)
|
||||||
@@ -568,4 +571,52 @@ public sealed class OtOpcUaConfigDbContext(DbContextOptions<OtOpcUaConfigDbConte
|
|||||||
e.HasIndex(x => x.LdapGroup).HasDatabaseName("IX_LdapGroupRoleMapping_Group");
|
e.HasIndex(x => x.LdapGroup).HasDatabaseName("IX_LdapGroupRoleMapping_Group");
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
|
private static void ConfigureEquipmentImportBatch(ModelBuilder modelBuilder)
|
||||||
|
{
|
||||||
|
modelBuilder.Entity<EquipmentImportBatch>(e =>
|
||||||
|
{
|
||||||
|
e.ToTable("EquipmentImportBatch");
|
||||||
|
e.HasKey(x => x.Id);
|
||||||
|
e.Property(x => x.ClusterId).HasMaxLength(64);
|
||||||
|
e.Property(x => x.CreatedBy).HasMaxLength(128);
|
||||||
|
e.Property(x => x.CreatedAtUtc).HasColumnType("datetime2(3)");
|
||||||
|
e.Property(x => x.FinalisedAtUtc).HasColumnType("datetime2(3)");
|
||||||
|
|
||||||
|
// Admin preview modal filters by user; finalise / drop both hit this index.
|
||||||
|
e.HasIndex(x => new { x.CreatedBy, x.FinalisedAtUtc })
|
||||||
|
.HasDatabaseName("IX_EquipmentImportBatch_Creator_Finalised");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity<EquipmentImportRow>(e =>
|
||||||
|
{
|
||||||
|
e.ToTable("EquipmentImportRow");
|
||||||
|
e.HasKey(x => x.Id);
|
||||||
|
e.Property(x => x.ZTag).HasMaxLength(128);
|
||||||
|
e.Property(x => x.MachineCode).HasMaxLength(128);
|
||||||
|
e.Property(x => x.SAPID).HasMaxLength(128);
|
||||||
|
e.Property(x => x.EquipmentId).HasMaxLength(64);
|
||||||
|
e.Property(x => x.EquipmentUuid).HasMaxLength(64);
|
||||||
|
e.Property(x => x.Name).HasMaxLength(128);
|
||||||
|
e.Property(x => x.UnsAreaName).HasMaxLength(64);
|
||||||
|
e.Property(x => x.UnsLineName).HasMaxLength(64);
|
||||||
|
e.Property(x => x.Manufacturer).HasMaxLength(256);
|
||||||
|
e.Property(x => x.Model).HasMaxLength(256);
|
||||||
|
e.Property(x => x.SerialNumber).HasMaxLength(256);
|
||||||
|
e.Property(x => x.HardwareRevision).HasMaxLength(64);
|
||||||
|
e.Property(x => x.SoftwareRevision).HasMaxLength(64);
|
||||||
|
e.Property(x => x.YearOfConstruction).HasMaxLength(8);
|
||||||
|
e.Property(x => x.AssetLocation).HasMaxLength(512);
|
||||||
|
e.Property(x => x.ManufacturerUri).HasMaxLength(512);
|
||||||
|
e.Property(x => x.DeviceManualUri).HasMaxLength(512);
|
||||||
|
e.Property(x => x.RejectReason).HasMaxLength(512);
|
||||||
|
|
||||||
|
e.HasOne(x => x.Batch)
|
||||||
|
.WithMany(b => b.Rows)
|
||||||
|
.HasForeignKey(x => x.BatchId)
|
||||||
|
.OnDelete(DeleteBehavior.Cascade);
|
||||||
|
|
||||||
|
e.HasIndex(x => x.BatchId).HasDatabaseName("IX_EquipmentImportRow_Batch");
|
||||||
|
});
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1,165 @@
|
|||||||
|
using Microsoft.EntityFrameworkCore;
|
||||||
|
using Shouldly;
|
||||||
|
using Xunit;
|
||||||
|
using ZB.MOM.WW.OtOpcUa.Admin.Services;
|
||||||
|
using ZB.MOM.WW.OtOpcUa.Configuration;
|
||||||
|
|
||||||
|
namespace ZB.MOM.WW.OtOpcUa.Admin.Tests;
|
||||||
|
|
||||||
|
[Trait("Category", "Unit")]
|
||||||
|
public sealed class EquipmentImportBatchServiceTests : IDisposable
|
||||||
|
{
|
||||||
|
private readonly OtOpcUaConfigDbContext _db;
|
||||||
|
private readonly EquipmentImportBatchService _svc;
|
||||||
|
|
||||||
|
public EquipmentImportBatchServiceTests()
|
||||||
|
{
|
||||||
|
var options = new DbContextOptionsBuilder<OtOpcUaConfigDbContext>()
|
||||||
|
.UseInMemoryDatabase($"import-batch-{Guid.NewGuid():N}")
|
||||||
|
.Options;
|
||||||
|
_db = new OtOpcUaConfigDbContext(options);
|
||||||
|
_svc = new EquipmentImportBatchService(_db);
|
||||||
|
}
|
||||||
|
|
||||||
|
public void Dispose() => _db.Dispose();
|
||||||
|
|
||||||
|
private static EquipmentCsvRow Row(string zTag, string name = "eq-1") => new()
|
||||||
|
{
|
||||||
|
ZTag = zTag,
|
||||||
|
MachineCode = "mc",
|
||||||
|
SAPID = "sap",
|
||||||
|
EquipmentId = "eq-id",
|
||||||
|
EquipmentUuid = Guid.NewGuid().ToString(),
|
||||||
|
Name = name,
|
||||||
|
UnsAreaName = "area",
|
||||||
|
UnsLineName = "line",
|
||||||
|
};
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task CreateBatch_PopulatesId_AndTimestamp()
|
||||||
|
{
|
||||||
|
var batch = await _svc.CreateBatchAsync("c1", "alice", CancellationToken.None);
|
||||||
|
|
||||||
|
batch.Id.ShouldNotBe(Guid.Empty);
|
||||||
|
batch.CreatedAtUtc.ShouldBeGreaterThan(DateTime.UtcNow.AddMinutes(-1));
|
||||||
|
batch.RowsStaged.ShouldBe(0);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task StageRows_AcceptedAndRejected_AllPersist()
|
||||||
|
{
|
||||||
|
var batch = await _svc.CreateBatchAsync("c1", "alice", CancellationToken.None);
|
||||||
|
|
||||||
|
await _svc.StageRowsAsync(batch.Id,
|
||||||
|
acceptedRows: [Row("z-1"), Row("z-2")],
|
||||||
|
rejectedRows: [new EquipmentCsvRowError(LineNumber: 5, Reason: "duplicate ZTag")],
|
||||||
|
CancellationToken.None);
|
||||||
|
|
||||||
|
var reloaded = await _db.EquipmentImportBatches.Include(b => b.Rows).FirstAsync(b => b.Id == batch.Id);
|
||||||
|
reloaded.RowsStaged.ShouldBe(3);
|
||||||
|
reloaded.RowsAccepted.ShouldBe(2);
|
||||||
|
reloaded.RowsRejected.ShouldBe(1);
|
||||||
|
reloaded.Rows.Count.ShouldBe(3);
|
||||||
|
reloaded.Rows.Count(r => r.IsAccepted).ShouldBe(2);
|
||||||
|
reloaded.Rows.Single(r => !r.IsAccepted).RejectReason.ShouldBe("duplicate ZTag");
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task DropBatch_RemovesBatch_AndCascades_Rows()
|
||||||
|
{
|
||||||
|
var batch = await _svc.CreateBatchAsync("c1", "alice", CancellationToken.None);
|
||||||
|
await _svc.StageRowsAsync(batch.Id, [Row("z-1")], [], CancellationToken.None);
|
||||||
|
|
||||||
|
await _svc.DropBatchAsync(batch.Id, CancellationToken.None);
|
||||||
|
|
||||||
|
(await _db.EquipmentImportBatches.AnyAsync(b => b.Id == batch.Id)).ShouldBeFalse();
|
||||||
|
(await _db.EquipmentImportRows.AnyAsync(r => r.BatchId == batch.Id)).ShouldBeFalse("cascaded delete clears rows");
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task DropBatch_AfterFinalise_Throws()
|
||||||
|
{
|
||||||
|
var batch = await _svc.CreateBatchAsync("c1", "alice", CancellationToken.None);
|
||||||
|
await _svc.StageRowsAsync(batch.Id, [Row("z-1")], [], CancellationToken.None);
|
||||||
|
await _svc.FinaliseBatchAsync(batch.Id, generationId: 1, driverInstanceIdForRows: "drv-1", unsLineIdForRows: "line-1", CancellationToken.None);
|
||||||
|
|
||||||
|
await Should.ThrowAsync<ImportBatchAlreadyFinalisedException>(
|
||||||
|
() => _svc.DropBatchAsync(batch.Id, CancellationToken.None));
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task Finalise_AcceptedRows_BecomeEquipment()
|
||||||
|
{
|
||||||
|
var batch = await _svc.CreateBatchAsync("c1", "alice", CancellationToken.None);
|
||||||
|
await _svc.StageRowsAsync(batch.Id,
|
||||||
|
[Row("z-1", name: "alpha"), Row("z-2", name: "beta")],
|
||||||
|
rejectedRows: [new EquipmentCsvRowError(1, "rejected")],
|
||||||
|
CancellationToken.None);
|
||||||
|
|
||||||
|
await _svc.FinaliseBatchAsync(batch.Id, 5, "drv-modbus", "line-warsaw", CancellationToken.None);
|
||||||
|
|
||||||
|
var equipment = await _db.Equipment.Where(e => e.GenerationId == 5).ToListAsync();
|
||||||
|
equipment.Count.ShouldBe(2);
|
||||||
|
equipment.Select(e => e.Name).ShouldBe(["alpha", "beta"], ignoreOrder: true);
|
||||||
|
equipment.All(e => e.DriverInstanceId == "drv-modbus").ShouldBeTrue();
|
||||||
|
equipment.All(e => e.UnsLineId == "line-warsaw").ShouldBeTrue();
|
||||||
|
|
||||||
|
var reloaded = await _db.EquipmentImportBatches.FirstAsync(b => b.Id == batch.Id);
|
||||||
|
reloaded.FinalisedAtUtc.ShouldNotBeNull();
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task Finalise_Twice_Throws()
|
||||||
|
{
|
||||||
|
var batch = await _svc.CreateBatchAsync("c1", "alice", CancellationToken.None);
|
||||||
|
await _svc.StageRowsAsync(batch.Id, [Row("z-1")], [], CancellationToken.None);
|
||||||
|
await _svc.FinaliseBatchAsync(batch.Id, 1, "drv", "line", CancellationToken.None);
|
||||||
|
|
||||||
|
await Should.ThrowAsync<ImportBatchAlreadyFinalisedException>(
|
||||||
|
() => _svc.FinaliseBatchAsync(batch.Id, 2, "drv", "line", CancellationToken.None));
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task Finalise_MissingBatch_Throws()
|
||||||
|
{
|
||||||
|
await Should.ThrowAsync<ImportBatchNotFoundException>(
|
||||||
|
() => _svc.FinaliseBatchAsync(Guid.NewGuid(), 1, "drv", "line", CancellationToken.None));
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task Stage_After_Finalise_Throws()
|
||||||
|
{
|
||||||
|
var batch = await _svc.CreateBatchAsync("c1", "alice", CancellationToken.None);
|
||||||
|
await _svc.StageRowsAsync(batch.Id, [Row("z-1")], [], CancellationToken.None);
|
||||||
|
await _svc.FinaliseBatchAsync(batch.Id, 1, "drv", "line", CancellationToken.None);
|
||||||
|
|
||||||
|
await Should.ThrowAsync<ImportBatchAlreadyFinalisedException>(
|
||||||
|
() => _svc.StageRowsAsync(batch.Id, [Row("z-2")], [], CancellationToken.None));
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task ListByUser_FiltersByCreator_AndFinalised()
|
||||||
|
{
|
||||||
|
var a = await _svc.CreateBatchAsync("c1", "alice", CancellationToken.None);
|
||||||
|
var b = await _svc.CreateBatchAsync("c1", "bob", CancellationToken.None);
|
||||||
|
await _svc.StageRowsAsync(a.Id, [Row("z-a")], [], CancellationToken.None);
|
||||||
|
await _svc.FinaliseBatchAsync(a.Id, 1, "d", "l", CancellationToken.None);
|
||||||
|
_ = b;
|
||||||
|
|
||||||
|
var aliceOpen = await _svc.ListByUserAsync("alice", includeFinalised: false, CancellationToken.None);
|
||||||
|
aliceOpen.ShouldBeEmpty("alice's only batch is finalised");
|
||||||
|
|
||||||
|
var aliceAll = await _svc.ListByUserAsync("alice", includeFinalised: true, CancellationToken.None);
|
||||||
|
aliceAll.Count.ShouldBe(1);
|
||||||
|
|
||||||
|
var bobOpen = await _svc.ListByUserAsync("bob", includeFinalised: false, CancellationToken.None);
|
||||||
|
bobOpen.Count.ShouldBe(1);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task DropBatch_Unknown_IsNoOp()
|
||||||
|
{
|
||||||
|
await _svc.DropBatchAsync(Guid.NewGuid(), CancellationToken.None);
|
||||||
|
// no throw
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -31,6 +31,8 @@ public sealed class SchemaComplianceTests
|
|||||||
"DriverHostStatus",
|
"DriverHostStatus",
|
||||||
"DriverInstanceResilienceStatus",
|
"DriverInstanceResilienceStatus",
|
||||||
"LdapGroupRoleMapping",
|
"LdapGroupRoleMapping",
|
||||||
|
"EquipmentImportBatch",
|
||||||
|
"EquipmentImportRow",
|
||||||
};
|
};
|
||||||
|
|
||||||
var actual = QueryStrings(@"
|
var actual = QueryStrings(@"
|
||||||
|
|||||||
Reference in New Issue
Block a user