dohertj2/lmxopcua
1
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

OPC UA SDK logging is discarded (no-op telemetry): server-side identity/certificate rejections leave no log line #874

New Issue
Closed
opened 2026-11-11 16:34:48 -05:00 by dohertj2 · 1 comment
dohertj2 commented 2026-11-11 16:34:48 -05:00
Owner
Copy Link
Copy Source

Found by the #800 partial Windows validation on windev: the server rejected API-key logins with BadIdentityTokenInvalid (see the clock-skew issue) and logged nothing. The OPC UA application host gives the SDK a no-op telemetry logger (DefaultTelemetry.Create(_ => { }) in OpcUaApplicationHost.cs), so SDK-side rejections are invisible: identity-token decryption failures, certificate validation failures and secure-channel faults.

Fix: route SDK telemetry into the host's Serilog ILoggerFactory at Warning and above, with a category such as Opc.Ua. Without that, an operator cannot diagnose these refusals from the server side.

Found by the #800 partial Windows validation on windev: the server rejected API-key logins with `BadIdentityTokenInvalid` (see the clock-skew issue) and logged **nothing**. The OPC UA application host gives the SDK a no-op telemetry logger (`DefaultTelemetry.Create(_ => { })` in `OpcUaApplicationHost.cs`), so SDK-side rejections are invisible: identity-token decryption failures, certificate validation failures and secure-channel faults. **Fix:** route SDK telemetry into the host's Serilog `ILoggerFactory` at Warning and above, with a category such as `Opc.Ua`. Without that, an operator cannot diagnose these refusals from the server side.
dohertj2 added the type:bugpriority:p2 labels 2026-11-11 16:34:48 -05:00
dohertj2 commented 2026-11-11 18:08:01 -05:00
Author
Owner
Copy Link
Copy Source

Fixed, pushed to master in 43f8b8e8 (2e948d31). The hosted service now creates one ServerSdkTelemetry context from its ILoggerFactory, shared by OtOpcUaSdkServer and the ApplicationInstance and released on dispose. It forwards Warning and above under the SDK's own categories, rate-limited to 20 per minute per category, so a client retrying in a loop cannot flood the log. Test: Sdk2TrustedChannelTests.An_sdk_side_refusal_reaches_the_server_log (an untrusted client's rejection reaches the captured log). The full local suite is green.

Fixed, pushed to master in `43f8b8e8` (`2e948d31`). The hosted service now creates one `ServerSdkTelemetry` context from its `ILoggerFactory`, shared by `OtOpcUaSdkServer` and the `ApplicationInstance` and released on dispose. It forwards Warning and above under the SDK's own categories, rate-limited to 20 per minute per category, so a client retrying in a loop cannot flood the log. Test: `Sdk2TrustedChannelTests.An_sdk_side_refusal_reaches_the_server_log` (an untrusted client's rejection reaches the captured log). The full local suite is green.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto-managed
queue management
 blocked
Blocked by dependency or external hold
 cross-driver
queue management
 cross-repo
Needs coordinated change in another family repo (wire contract etc.)
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 migrated
Migrated from a markdown backlog (2026-11 standardization)
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 priority:p0
Must-have / blocking
 priority:p1
High priority
 priority:p2
Normal priority
 priority:p3
Low priority / nice to have
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
 type:bug
Defect in shipped behaviour
 type:debt
Technical debt / hygiene
 type:deploy-gate
Rollout/deploy/migration step not yet done on an environment
 type:docs
Documentation work
 type:feature
Feature implementation
 type:followup
Follow-up deferred from a plan, PR or gate
 type:infra
Infrastructure and scaffolding
 type:review-finding
Unfixed finding from an architecture/code review
 type:test
Test work
No Label priority:p2 type:bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#874
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?