dohertj2/lmxopcua
1
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

Heidenhain: Tool/Number, Tool/Index and Tool/AxisCode published as Double instead of Int64/Int32 #867

New Issue
Closed
opened 2026-11-11 12:18:10 -05:00 by dohertj2 · 1 comment
dohertj2 commented 2026-11-11 12:18:10 -05:00
Owner
Copy Link
Copy Source

Found by the #829 live gate on 2026-11-11 against four real iTNC 530 controls. In HeidenhainSession.Leaf, the case Lsv2Tool t switch arms mix long, int and double?. C# unifies them to double?, so OPC UA clients receive Double values on nodes that advertise Int64/Int32. The neighbouring Program case avoids this with an (object) cast.

The unit test Tool_without_geometry_is_not_supported_not_zero doesn't catch it, because Shouldly treats 7.0 as equal to 7L, and otopcua-cli prints 49 either way.

Fix: cast to object per arm, and add a test that asserts the runtime type of the value. Recheck live (read-only).

Found by the #829 live gate on 2026-11-11 against four real iTNC 530 controls. In `HeidenhainSession.Leaf`, the `case Lsv2Tool t` switch arms mix `long`, `int` and `double?`. C# unifies them to `double?`, so OPC UA clients receive Double values on nodes that advertise Int64/Int32. The neighbouring Program case avoids this with an `(object)` cast. The unit test `Tool_without_geometry_is_not_supported_not_zero` doesn't catch it, because Shouldly treats 7.0 as equal to 7L, and `otopcua-cli` prints 49 either way. **Fix:** cast to object per arm, and add a test that asserts the runtime type of the value. Recheck live (read-only).
dohertj2 added the priority:p2type:bug labels 2026-11-11 12:18:11 -05:00
dohertj2 commented 2026-11-11 14:53:55 -05:00
Author
Owner
Copy Link
Copy Source

Done. Tool/Number is Int64 and Tool/Index and Tool/AxisCode are Int32. A runtime-type test now covers every leaf, and a new live test was verified read-only on Hermle59 and Hermle70. Pushed to master in e857135e..7a27ef1f; full suite green (20 projects, 0 failures, 0 warnings).

Done. Tool/Number is Int64 and Tool/Index and Tool/AxisCode are Int32. A runtime-type test now covers every leaf, and a new live test was verified read-only on Hermle59 and Hermle70. Pushed to master in `e857135e..7a27ef1f`; full suite green (20 projects, 0 failures, 0 warnings).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto-managed
queue management
 blocked
Blocked by dependency or external hold
 cross-driver
queue management
 cross-repo
Needs coordinated change in another family repo (wire contract etc.)
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 migrated
Migrated from a markdown backlog (2026-11 standardization)
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 priority:p0
Must-have / blocking
 priority:p1
High priority
 priority:p2
Normal priority
 priority:p3
Low priority / nice to have
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
 type:bug
Defect in shipped behaviour
 type:debt
Technical debt / hygiene
 type:deploy-gate
Rollout/deploy/migration step not yet done on an environment
 type:docs
Documentation work
 type:feature
Feature implementation
 type:followup
Follow-up deferred from a plan, PR or gate
 type:infra
Infrastructure and scaffolding
 type:review-finding
Unfixed finding from an architecture/code review
 type:test
Test work
No Label priority:p2 type:bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#867
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?