dohertj2/lmxopcua
1
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

AdminUI equipment page: Remove reference / Delete virtual tag buttons do nothing outside the Alarms tab #832

New Issue
Closed
opened 2026-11-11 00:48:15 -05:00 by dohertj2 · 1 comment
dohertj2 commented 2026-11-11 00:48:15 -05:00
Owner
Copy Link
Copy Source

Found during the #803 docker-dev live gate (predates it; origin a4cdedc3). On /uns/equipment/{id}, the Tags tab's Remove (tag reference) and the virtual-tag Delete buttons appear to do nothing. The shared <RawConfirmDialog …> in src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Uns/EquipmentPage.razor (~lines 317-318) sits inside the else if (_activeTab == "alarms") branch (~260-319), so it renders only on the Alarms tab. Repro: Tags tab → Remove → nothing; switch to Alarms → the pending "Remove reference" confirm is there. Fix: render the dialog outside the tab branches; live-verify (no bUnit).

Found during the #803 docker-dev live gate (predates it; origin a4cdedc3). On `/uns/equipment/{id}`, the Tags tab's **Remove** (tag reference) and the virtual-tag **Delete** buttons appear to do nothing. The shared `<RawConfirmDialog …>` in `src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Uns/EquipmentPage.razor` (~lines 317-318) sits inside the `else if (_activeTab == "alarms")` branch (~260-319), so it renders only on the Alarms tab. Repro: Tags tab → Remove → nothing; switch to Alarms → the pending "Remove reference" confirm is there. Fix: render the dialog outside the tab branches; live-verify (no bUnit).
dohertj2 added the type:bugpriority:p2 labels 2026-11-11 00:48:15 -05:00
dohertj2 commented 2026-11-11 05:24:35 -05:00
Author
Owner
Copy Link
Copy Source

Fixed (merge 2a87d96f). Pushed to master in d1b6cad2. The confirm dialog moved out of the Alarms tab, so Remove reference / Delete virtual tag work on every tab; verified live.

Fixed (merge `2a87d96f`). Pushed to master in `d1b6cad2`. The confirm dialog moved out of the Alarms tab, so Remove reference / Delete virtual tag work on every tab; verified live.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto-managed
queue management
 blocked
Blocked by dependency or external hold
 cross-driver
queue management
 cross-repo
Needs coordinated change in another family repo (wire contract etc.)
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 migrated
Migrated from a markdown backlog (2026-11 standardization)
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 priority:p0
Must-have / blocking
 priority:p1
High priority
 priority:p2
Normal priority
 priority:p3
Low priority / nice to have
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
 type:bug
Defect in shipped behaviour
 type:debt
Technical debt / hygiene
 type:deploy-gate
Rollout/deploy/migration step not yet done on an environment
 type:docs
Documentation work
 type:feature
Feature implementation
 type:followup
Follow-up deferred from a plan, PR or gate
 type:infra
Infrastructure and scaffolding
 type:review-finding
Unfixed finding from an architecture/code review
 type:test
Test work
No Label priority:p2 type:bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#832
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?